From patchwork Mon Jun 21 01:34:27 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 464479 Delivered-To: patch@linaro.org Received: by 2002:a05:6638:102:0:0:0:0 with SMTP id x2csp2116672jao; Sun, 20 Jun 2021 18:45:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxTqJ3R4DE+s84t6l70M74PkQ0MmuZO4aY50JVf4S71rWLfAupE+El8h9k824B4q/tZE8RC X-Received: by 2002:a0c:cb8a:: with SMTP id p10mr11445396qvk.56.1624239940883; Sun, 20 Jun 2021 18:45:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624239940; cv=none; d=google.com; s=arc-20160816; b=KjdnuBJM0CIiWNOWwgXOPI0+TXSC1MkxeRoKaLo7rhyIicfLk/XW+hSspRE+ES542F rDYyEIGAY//ZwzX6hVVDml2MXBldmC9YT19IXb0bagi6RCaT93i1k9q8csNSVt4i3O0p uou16Rx/a/adRy+s8Bti7Jqzo39fiRM2PFT/NS5WCH5sPGsqAPMT8kILpqOtLwEhbEtT oS8AgbvHyawH31cC9JGJwIRNevrms2oSfS6PsWxDxu0q5mRsn9m1ErGg2X3erbg7zSN1 jLWpMwFwCzGqJzncJRCpEwQqo50glsUk7My+ODMh9u6q0lNuHBJ9PxifJKUlclbJZz0h hhqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=wtlIXfVTIDAcxOMm3S62qcgJG1xzrj7M5573CnR6cAM=; b=FlLMYy8ILQLEN6lBx6MINMMhlLHuEQLX59CZKCQuce1xdsATc+fP7/HB5wj9Z25CCZ fxZHs4qrKJNl48vW/YBy/o6yPCSxreNMVG7Y5scw50zLBuACRNApohv2B1f0agc9SxAO 9DM0CMsXNpJB4aA++CY/2offiCGbeob/nf7dZ6nDqWzVo/DosfgkO8dZE+u951xMLqV6 2fGUJ68koIx7xFgi/qnRerFs7iFQl0RHJwWsdafONeWCT5dtYvR+BGlMXEZzPx/JeWAI vjJl193Dg5KalUKlePBthRgvLumSdex7RaDHprbTvtwfA5PmKHs4Q5bT1KGYRK6bpswo O+jw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZPxUmzqV; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id k4si4927730qvj.169.2021.06.20.18.45.40 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 20 Jun 2021 18:45:40 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZPxUmzqV; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:38630 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lv90O-0008Og-8e for patch@linaro.org; Sun, 20 Jun 2021 21:45:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40032) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lv8q8-0003wn-6i for qemu-devel@nongnu.org; Sun, 20 Jun 2021 21:35:05 -0400 Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]:40466) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lv8pu-0005CX-AQ for qemu-devel@nongnu.org; Sun, 20 Jun 2021 21:35:03 -0400 Received: by mail-pf1-x42b.google.com with SMTP id q192so5839041pfc.7 for ; Sun, 20 Jun 2021 18:34:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wtlIXfVTIDAcxOMm3S62qcgJG1xzrj7M5573CnR6cAM=; b=ZPxUmzqV8Qx/mMGuqNNL0Yd/NspN+N7734ReQNBEblNncmLWjNIpE0d0GmwHUFSMKv 7LaV7ehjWMRJLnWrSvyu9qLaZwnnZv8ZWCfxCHLUepMDN3YjRuuL5Zu9ov83cXNYku3S O+3TKyk5MHO5Pgple5C9N2B/PhGh7KiNpTeNX082tJeDsqioYImjC+rVjP6DC2P+Awe+ WtoVvT8Rm2Wz/qcHEUXrGOndLBSk/LhrkKd7GsxAUAy3KFN6oulWb6o3N+k+OdWJcwyC s6FrpotJgAH/Uq0IVRbzoY9IZdFct6twKEL6saTkTwQuyjuAFkoT8i5ocWHaCi2T1ZVC A40w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wtlIXfVTIDAcxOMm3S62qcgJG1xzrj7M5573CnR6cAM=; b=jpW1U2c9Dets1suCVCkaUH4mccOW0AjML2HnO3Vcoy/yu5OS/rdgN+zsFq5UOrHLa1 WviqSP58Yj47I5AdoRVNxBok112lRvplJfL4KNUXgJFk4Ltg6SLzCDSAsrFvn+q4MLFF hiYFAaCk4FPHpmQMP51dfTdIo4RIk8KyqdXuZ9BmmTbCDRDDP9wYMR3K8GCw6PWvkqe3 +w7Wnf48k/pzO8FGRBTptp+qX7ffHhjRho6RJuMXTtDgRYrfY7m2UFzN9Gn4pfzJg9E/ HYBm2H17KDUmw8GOMzyi7WoNRigIKaBhr5bGnpVZ3iJRL0eo/O9oWScVXqUQsLwvFV1N wXqw== X-Gm-Message-State: AOAM531HP+obZf8rj6ltaZ67EV/u1pGEOvSeViNVN4wtnIOQGlKEgwxx PqduuGQZCdiry7yIXCV3MKX5BW3jhb371g== X-Received: by 2002:a05:6a00:810:b029:301:f08c:6b0d with SMTP id m16-20020a056a000810b0290301f08c6b0dmr7830708pfk.8.1624239289106; Sun, 20 Jun 2021 18:34:49 -0700 (PDT) Received: from localhost.localdomain ([71.212.149.176]) by smtp.gmail.com with ESMTPSA id s27sm1495628pfg.169.2021.06.20.18.34.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Jun 2021 18:34:48 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 14/26] target/mips: Fix missing else in gen_goto_tb Date: Sun, 20 Jun 2021 18:34:27 -0700 Message-Id: <20210621013439.1791385-15-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210621013439.1791385-1-richard.henderson@linaro.org> References: <20210621013439.1791385-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::42b; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Do not emit dead code for the singlestep_enabled case, after having exited the TB with a debug exception. Cc: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/mips/tcg/translate.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.25.1 Reviewed-by: Philippe Mathieu-Daudé diff --git a/target/mips/tcg/translate.c b/target/mips/tcg/translate.c index d59986b340..99827ee740 100644 --- a/target/mips/tcg/translate.c +++ b/target/mips/tcg/translate.c @@ -5030,8 +5030,9 @@ static void gen_goto_tb(DisasContext *ctx, int n, target_ulong dest) if (ctx->base.singlestep_enabled) { save_cpu_state(ctx, 0); gen_helper_raise_exception_debug(cpu_env); + } else { + tcg_gen_lookup_and_goto_ptr(); } - tcg_gen_lookup_and_goto_ptr(); } }