From patchwork Mon Jun 21 16:27:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 464532 Delivered-To: patch@linaro.org Received: by 2002:a05:6638:102:0:0:0:0 with SMTP id x2csp2749491jao; Mon, 21 Jun 2021 09:30:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzK8OBNU9s5JCP7rptygEsWAEhTaBEz4ZbuJHRhxQn3zddT6IhaUoPSPHwrgdp3t9d6KeAS X-Received: by 2002:aa7:da14:: with SMTP id r20mr21495330eds.36.1624293012426; Mon, 21 Jun 2021 09:30:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624293012; cv=none; d=google.com; s=arc-20160816; b=0bZC1tD3jN/caMI0AfkBAM9aox6NIqdRfbwhSPaQXX1LsvKllqBBlnDCBE4hte/TTB t40x0P0KHiwrxzhojSJxd3TbxnVLElOkp9Ug/j+tUdfIyESlLwfq1ICxxTP6T5opx+ZL 4X8UmfRJ8eR7NpPNXbrTH+Wsjk2671HrlBlNDK+16A5tp8nAIb++h3GR967mjwNGNQl2 e9hPnOzzzIBEdMzcGzYG7iFuW6pFNS4Hu9lgNsoGgofhbxszkVxmBS/JbasEYFIsEhPB jmRt9KxN34Bl5kWr4fYOsMq14nfF1NCyv6ZqXXaFyk8bxunY66OZFM3kNLped2ZEYbDZ kE3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=aSH8hZzqUbwXhs7mRt/BblY/GXHC1/m8vJZj8ueb44k=; b=Nq8CMhSmW66+n5n6raUIF5ltA3Ym1bcbDE6+Ehv1iMDti7SUUebtyZOTURMy8uxG/F vcaR+HrcvsY1vkhZm7n51LB07FobPGAFa0cntrCjSzwbhjnmKgnB4SDvgvvw/PudQmBl dkOIb5bZ7QXv4h317NNDw2fL6DDS5sFypkrK3rlV5UrhX9y5WuTDvLbVLldUsC6C4Nfj qS9fpZRcSEVfGfQBcD1YST9trwnXJIjJBfY1zkgOQBHp7xleMjjyqP8OV9hWFJolZft+ wEcOoVkAC44MXh/K/TrETBsn07/c/zTFmXGlfzH0isj3fkJdwJv19RAQ0qe35iaBP8mB rmpA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ssoWPFSL; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 24si11191109eji.692.2021.06.21.09.30.11 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 21 Jun 2021 09:30:12 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ssoWPFSL; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:35024 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lvMoL-00076f-52 for patch@linaro.org; Mon, 21 Jun 2021 12:30:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33094) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lvMn1-00073h-AL for qemu-devel@nongnu.org; Mon, 21 Jun 2021 12:28:47 -0400 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]:41686) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lvMmz-0007WZ-Ab for qemu-devel@nongnu.org; Mon, 21 Jun 2021 12:28:47 -0400 Received: by mail-wm1-x335.google.com with SMTP id y13-20020a1c4b0d0000b02901c20173e165so434795wma.0 for ; Mon, 21 Jun 2021 09:28:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=aSH8hZzqUbwXhs7mRt/BblY/GXHC1/m8vJZj8ueb44k=; b=ssoWPFSLkBrnz+/GuLzI93IRVpJzQM2oUd0TyRv2ZjDWzHWI/bgG22EddzRDUhtbDJ 5ubQfUxIThES9cuCq37nIoYeE5j+B+ZrKroEzvTMgsxzWxdQRMWYCMgV8OSTWl3eepqA zVtIFy6FEDcjf7yhR/Q7Yij49Swm1F6rtPCfwvsaSt1VF4KqgURBpTexdN5PMaiIFs8l Vy7vqWJzjSWEmwOdC32QaDggiUPAiePIJuwawl4iI2531RnNy/P+MXERW09Vz/uIhxxW u3KgrvdCthM6sAKfz4orSiwEJvkCB0okzvpR9kGeDeaV/T2blwmt2n9soSx2DFQvi2un vbGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=aSH8hZzqUbwXhs7mRt/BblY/GXHC1/m8vJZj8ueb44k=; b=GVkGdrWLlj7dUDo6VUslVuSOSZJ3v7ePUQFfoIeo7a5to6tBKChoSvZjpYZXDM2kaT Atf7j48nXo14Agwytq6E+d20WpCYWDthFD+LsoEsqzVzMq0/3SQ8xg9PSTqBPM9++vsh rlT3JUD2sqVGQEMQrc0IThDdteFxQmd2EfDfCFpTeqULt8J5krXrrHGxiSnKTfUF3SeQ PrOvHwSVjCn2x/QxizcRiX4rTd71sl3auIrNods4mUNTHgkI2vWMODlKz/2a//Eo3MUd uI+UtQ8Q+YH9cnDPeptZIj4y+YOM7VnLKnsLgXeYiEWNT0yogkPE1yVkM3fIiL87bZ82 3tcg== X-Gm-Message-State: AOAM532B8leriraJnK3hJILfXVuBgJaf1Ao/I4jLJeyrjTjPssuTcd6t c7yDuWOTIDfsU6ZsdWWuJ9R3ToH2op1T4ImN X-Received: by 2002:a05:600c:3791:: with SMTP id o17mr14709726wmr.187.1624292924077; Mon, 21 Jun 2021 09:28:44 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id n65sm11615496wme.21.2021.06.21.09.28.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Jun 2021 09:28:43 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 11/57] target/arm: Handle FPU check for FPCXT_NS insns via vfp_access_check_m() Date: Mon, 21 Jun 2021 17:27:47 +0100 Message-Id: <20210621162833.32535-12-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210621162833.32535-1-peter.maydell@linaro.org> References: <20210621162833.32535-1-peter.maydell@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x335.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Instead of open-coding the "take NOCP exception if FPU disabled, otherwise call gen_preserve_fp_state()" code in the accessors for FPCXT_NS, add an argument to vfp_access_check_m() which tells it to skip the gen_update_fp_context() call, so we can use it for the FPCXT_NS case. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Message-id: 20210618141019.10671-8-peter.maydell@linaro.org --- target/arm/translate-a32.h | 2 +- target/arm/translate-m-nocp.c | 10 ++-------- target/arm/translate-vfp.c | 13 ++++++++----- 3 files changed, 11 insertions(+), 14 deletions(-) -- 2.20.1 diff --git a/target/arm/translate-a32.h b/target/arm/translate-a32.h index abb3ecb6bc9..23264053006 100644 --- a/target/arm/translate-a32.h +++ b/target/arm/translate-a32.h @@ -32,7 +32,7 @@ bool disas_neon_shared(DisasContext *s, uint32_t insn); void load_reg_var(DisasContext *s, TCGv_i32 var, int reg); void arm_gen_condlabel(DisasContext *s); bool vfp_access_check(DisasContext *s); -void gen_preserve_fp_state(DisasContext *s); +bool vfp_access_check_m(DisasContext *s, bool skip_context_update); void read_neon_element32(TCGv_i32 dest, int reg, int ele, MemOp memop); void read_neon_element64(TCGv_i64 dest, int reg, int ele, MemOp memop); void write_neon_element32(TCGv_i32 src, int reg, int ele, MemOp memop); diff --git a/target/arm/translate-m-nocp.c b/target/arm/translate-m-nocp.c index 312a25f0589..5eab04832cd 100644 --- a/target/arm/translate-m-nocp.c +++ b/target/arm/translate-m-nocp.c @@ -371,9 +371,7 @@ static bool gen_M_fp_sysreg_write(DisasContext *s, int regno, * otherwise PreserveFPState(), and then FPCXT_NS writes * behave the same as FPCXT_S writes. */ - if (s->fp_excp_el) { - gen_exception_insn(s, s->pc_curr, EXCP_NOCP, - syn_uncategorized(), s->fp_excp_el); + if (!vfp_access_check_m(s, true)) { /* * This was only a conditional exception, so override * gen_exception_insn()'s default to DISAS_NORETURN @@ -381,7 +379,6 @@ static bool gen_M_fp_sysreg_write(DisasContext *s, int regno, s->base.is_jmp = DISAS_NEXT; break; } - gen_preserve_fp_state(s); } /* fall through */ case ARM_VFP_FPCXT_S: @@ -527,9 +524,7 @@ static bool gen_M_fp_sysreg_read(DisasContext *s, int regno, * otherwise PreserveFPState(), and then FPCXT_NS * reads the same as FPCXT_S. */ - if (s->fp_excp_el) { - gen_exception_insn(s, s->pc_curr, EXCP_NOCP, - syn_uncategorized(), s->fp_excp_el); + if (!vfp_access_check_m(s, true)) { /* * This was only a conditional exception, so override * gen_exception_insn()'s default to DISAS_NORETURN @@ -537,7 +532,6 @@ static bool gen_M_fp_sysreg_read(DisasContext *s, int regno, s->base.is_jmp = DISAS_NEXT; break; } - gen_preserve_fp_state(s); tmp = tcg_temp_new_i32(); sfpa = tcg_temp_new_i32(); fpscr = tcg_temp_new_i32(); diff --git a/target/arm/translate-vfp.c b/target/arm/translate-vfp.c index d89c7834faa..86e43c02dcd 100644 --- a/target/arm/translate-vfp.c +++ b/target/arm/translate-vfp.c @@ -109,7 +109,7 @@ static inline long vfp_f16_offset(unsigned reg, bool top) * Generate code for M-profile lazy FP state preservation if needed; * this corresponds to the pseudocode PreserveFPState() function. */ -void gen_preserve_fp_state(DisasContext *s) +static void gen_preserve_fp_state(DisasContext *s) { if (s->v7m_lspact) { /* @@ -218,8 +218,9 @@ static bool vfp_access_check_a(DisasContext *s, bool ignore_vfp_enabled) * If VFP is enabled, do the necessary M-profile lazy-FP handling and then * return true. If not, emit code to generate an appropriate exception and * return false. + * skip_context_update is true to skip the "update FP context" part of this. */ -static bool vfp_access_check_m(DisasContext *s) +bool vfp_access_check_m(DisasContext *s, bool skip_context_update) { if (s->fp_excp_el) { /* @@ -239,8 +240,10 @@ static bool vfp_access_check_m(DisasContext *s) /* Trigger lazy-state preservation if necessary */ gen_preserve_fp_state(s); - /* Update ownership of FP context and create new FP context if needed */ - gen_update_fp_context(s); + if (!skip_context_update) { + /* Update ownership of FP context and create new FP context if needed */ + gen_update_fp_context(s); + } return true; } @@ -252,7 +255,7 @@ static bool vfp_access_check_m(DisasContext *s) bool vfp_access_check(DisasContext *s) { if (arm_dc_feature(s, ARM_FEATURE_M)) { - return vfp_access_check_m(s); + return vfp_access_check_m(s, false); } else { return vfp_access_check_a(s, false); }