From patchwork Tue Jun 29 18:54:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 468337 Delivered-To: patch@linaro.org Received: by 2002:a02:c94a:0:0:0:0:0 with SMTP id u10csp5254503jao; Tue, 29 Jun 2021 12:31:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwYBYAqfvKps8RdtCNrX7YS6LPOzRDCESl5OH5ZInNlYQ7dJaTdW5XoE1eFKAXgtW8pJIqa X-Received: by 2002:a25:1c86:: with SMTP id c128mr6344006ybc.81.1624995115884; Tue, 29 Jun 2021 12:31:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624995115; cv=none; d=google.com; s=arc-20160816; b=f9G4BFrSfgYc3P2pFPKAnKygB16MzYCRN5jz2ZuAeY44J2rLu5zuUimCdv+MVZvh2N 4a8X7EzdZlReh6q2UyOYMBtgX4Rr5Te7GfPvmxiQe4kqNLQrYP/AuDolh1PxV35IjGsz JEp1YMAZSg/CBPiqkQvlOyylnHldA/A7ignDuXoaLE8W2GxSJ6LOt+H26RhQK0U0Q3qN WEpWcm6Eeg5o5HYHrLlwDno4EoPlM1NlVXEnDGzhvXg9lAgbs6oKqW1XW4iNBxlaJtXX qoikaU5VyEzs1bygdrzmS4eH3QHTmKYWSTAWlsS+O9rXk7ws2yXVXjrutczF9DZpNhw1 jSNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=1eZd84MrBkQ4EtK0PZ1SOJT9XE+/f091S9/PfyqFFNM=; b=Ogd5na1IrqTF4udKPyYNXLEFVPiqyD4ZWMsDQPoAmHNvOMfU4nDjf/qsq7tvelw6N1 dG0jWjiOZqy3902/1Rhq4fysXJGc2QqLpPO8uE7Pss6TLnDqD5MY86mT4enedNA5WGCw fUQ0PYTTL32Pxy4t1+xebq4JBbvZu1gzz9V0VGihqWrwoqhNLo8tftoI7WREE2ttTCpC /yGOauMVFDjGAmzbQNb6VBe23WO1XH57EtwzoWWjZPlgWH6AFp68zpQY/Ip60r+O0hBa NNHfLurqIpVkQVglKRFyw8Y8X6/tIcE8R+720e1mUHvPyQW8uT/9W0zmC+TUOCY3Qebx spGQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jQp7NEdl; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id a18si18833304ybc.456.2021.06.29.12.31.55 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 29 Jun 2021 12:31:55 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jQp7NEdl; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:57350 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lyJSd-0005rW-83 for patch@linaro.org; Tue, 29 Jun 2021 15:31:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38554) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lyItF-0008BA-8a for qemu-devel@nongnu.org; Tue, 29 Jun 2021 14:55:21 -0400 Received: from mail-pf1-x42f.google.com ([2607:f8b0:4864:20::42f]:39481) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lyItA-0000tj-2R for qemu-devel@nongnu.org; Tue, 29 Jun 2021 14:55:20 -0400 Received: by mail-pf1-x42f.google.com with SMTP id g192so99559pfb.6 for ; Tue, 29 Jun 2021 11:55:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1eZd84MrBkQ4EtK0PZ1SOJT9XE+/f091S9/PfyqFFNM=; b=jQp7NEdldcfa5yQ4mQ8N/t7nyrZtU/bzgPnsjGRG0z/aDxEGc0kzFBtDhig9j9QcLq fTIFmDbImVST3PQBDEAU5RFa8og0++ptRmw8t4XSdPUSRonZkYzmsXD2LY5FMQ5PXAGL Wl02vB1pzFheMl+62MZaNFEuG7VZjzWiTGpsvFWJwxDDrV7jg14Yb+mopGi3XjwVs7pa G35pJsxMpie0TB+l2iVMJEPYUgZMRV7WikV0hBxTsSiMlScq7XYDZ5z92Jf4iPGV5ztk AVsKmzJ4oTpGCuvo9bixN+5mOL6YN2hCA1sByBV4t/UPSXsoX7l2T9d4XBh02u/vOrmn 2x5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1eZd84MrBkQ4EtK0PZ1SOJT9XE+/f091S9/PfyqFFNM=; b=U+oQ305tw/LV4M5w5ULOSmdl3lJpq7qJqHOZv9xznxGgfhODqnfvsQjPXD9T8WMBjW caUxRNgZlFBNqBOpXZcmrmd9x3lC8UWOc9Qgx6JFTIiOftgIIodS7DraqI68iVHTv4zB fWOG3WEzdPAi+M744C+G2lbb0vTKweBTPxeuRaN0NG8lMOluQnrHTG90DGiU9Nl63iRM OIawMcVxHMwGUbHOL8AQz5sLjw5fEOeBG7xo3MPW8sV3n4BKYCTckud3GYQ52b+YKU3e cVzQPJO2BNbFAs7rv+mcleIFarV16ZsRQCaN3TRGb/kPqpWWIRBn5C3v3pOTSrcs+PV4 emfw== X-Gm-Message-State: AOAM530/wZLk0OdrIL6CTZD1/x91vZN/6QirY7SbpoCu6+zmMOf/+NRI NoPdnZjNu59Wi8CoqBqu2UGwqUDw6zagrQ== X-Received: by 2002:a63:5d5:: with SMTP id 204mr29525072pgf.72.1624992908561; Tue, 29 Jun 2021 11:55:08 -0700 (PDT) Received: from localhost.localdomain ([71.212.149.176]) by smtp.gmail.com with ESMTPSA id j2sm18811253pfb.53.2021.06.29.11.55.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Jun 2021 11:55:08 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 22/63] target/cris: Set cpustate_changed for rfe/rfn Date: Tue, 29 Jun 2021 11:54:14 -0700 Message-Id: <20210629185455.3131172-23-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210629185455.3131172-1-richard.henderson@linaro.org> References: <20210629185455.3131172-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::42f; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Edgar E . Iglesias" Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" These insns set DISAS_UPDATE without cpustate_changed, which isn't quite right. Reviewed-by: Edgar E. Iglesias Tested-by: Edgar E. Iglesias Signed-off-by: Richard Henderson --- target/cris/translate.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.25.1 diff --git a/target/cris/translate.c b/target/cris/translate.c index 80276ae84d..df92b90d4e 100644 --- a/target/cris/translate.c +++ b/target/cris/translate.c @@ -2880,6 +2880,7 @@ static int dec_rfe_etc(CPUCRISState *env, DisasContext *dc) cris_evaluate_flags(dc); gen_helper_rfe(cpu_env); dc->base.is_jmp = DISAS_UPDATE; + dc->cpustate_changed = true; break; case 5: /* rfn. */ @@ -2887,6 +2888,7 @@ static int dec_rfe_etc(CPUCRISState *env, DisasContext *dc) cris_evaluate_flags(dc); gen_helper_rfn(cpu_env); dc->base.is_jmp = DISAS_UPDATE; + dc->cpustate_changed = true; break; case 6: LOG_DIS("break %d\n", dc->op1);