From patchwork Wed Jun 30 18:32:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 468735 Delivered-To: patch@linaro.org Received: by 2002:a02:c94a:0:0:0:0:0 with SMTP id u10csp624469jao; Wed, 30 Jun 2021 11:58:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx9nl2Y+0qFlOHiqwFSjr50+Ym7KTQKQUajX5pazuwtIvax1aROsdee9c4l67Nsa+x11ZNo X-Received: by 2002:a5b:bc4:: with SMTP id c4mr10824789ybr.299.1625079489521; Wed, 30 Jun 2021 11:58:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625079489; cv=none; d=google.com; s=arc-20160816; b=WpGwlU/qHq7xmbHM7vWcZljwahojDh2vSVYqkaVZ+TVPDNyMfD0Ox6UMwqUaVVIQ8o WTZhRW/U6uvrNI3RzJO3qT4CBGgG8zdEmgOtr8ldMypj2H57cdDXeCEKhfg3PRy4/3p7 ya0IZgnsFc+LrHiXviqDDqEuuClIC/c7h4Ji75vxiokZbldgetkmCkMo/XdHw12c+CYL ebDXUnggbBTyW/1mb6gIpw0yfcpb4sCfSe2+235sJ4tITM3VkIg+hF6EUtSs7QhDUEPX wXY2c2foWw0jBCnz3irI8RESmMWAmYsGzFpjjIGUd3lQzDvIMIH267wi1Tpoau1vCWWe AX5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=pff8c+CXaZuYQN3AC9HgnBb8y6h8lxovDgoF+viWASM=; b=OOPtsfGbEGk0oymbyAALn4GFtQ6dhP5aMrl/Vp7KqTdv6ZpdDmZqWtPhTdHxdK0oBM KZT19Jyc7C/nj7JRfrpOLQ8y+4eI/KKMGTyZUE9tFzxn/1NbPbHkehPSXiScDnVeqS+c rbK2V9qRunM75F2Xl+CNHK7RyIvPqd4SSn8Uy9lmpvyaFNwOjwKsXLPmapIx6n3nhZE9 tkTLJLsdizDH3kyREnEc8ODjZPhMYN+YFZs6jvTcR0gldM+mwU8C72LfDxEZVD+4vgkk Bzqed9HSSkO917d2MCZ80F2hXIfUN6bTAfZtPf1ILkL3I2RHcf8H1fa7FUMagPscf0qE g2Nw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=RUck+Mox; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id k16si19247995ybp.113.2021.06.30.11.58.09 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 30 Jun 2021 11:58:09 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=RUck+Mox; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:41534 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lyfPU-0004ZX-UO for patch@linaro.org; Wed, 30 Jun 2021 14:58:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45610) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lyf0t-0005W1-3x for qemu-devel@nongnu.org; Wed, 30 Jun 2021 14:32:43 -0400 Received: from mail-pj1-x1035.google.com ([2607:f8b0:4864:20::1035]:35509) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lyf0o-00024I-H6 for qemu-devel@nongnu.org; Wed, 30 Jun 2021 14:32:42 -0400 Received: by mail-pj1-x1035.google.com with SMTP id pf4-20020a17090b1d84b029016f6699c3f2so4949695pjb.0 for ; Wed, 30 Jun 2021 11:32:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pff8c+CXaZuYQN3AC9HgnBb8y6h8lxovDgoF+viWASM=; b=RUck+Moxk5bH3lg6sK9LjSOnLcST6ee635ckGnNir+1HW6yM6NWBMQ+BSm2HVdgWiG ged+KzAZ70Ipi7b+IVa07cMv9LV4Fnv6lONyAoJve+vNTKlUFiC+U9fkxAj2ZKUqZe/l dcw9zS/w2EOKLOvG2QpAiMz2tAEiEsTBdmZfOLuuFxBH4hjLOJhHiDicaIfWBUxpkXae U+LbFQEemHKmTqNIQ0pOiJngbkPARVdY7bk/Tt54sXks6avz+cGZLP2YEunTJx+2GZJ/ UHu0Jobxe6lFAoaU4CRJIFjOiuQBdhx08CMS38oON3UkYMRExRSibLKwDBceazNZPIMn ZZSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pff8c+CXaZuYQN3AC9HgnBb8y6h8lxovDgoF+viWASM=; b=KktUGcBZy26iw29c5KZe+0Tk9fguKA684wFt35KTO0zaDjEJmTBLwhMlc6NEFq2tI5 7ggjjP0aID5yodo2uuQtxjzwACmelLQelSCqKCWJh0rxw2MIJv5RxLEriIqpaHr++hdv nEYIwdv+hC6TiAlxgu01Gb+dqtKMlSWgiGH9hBa1Zaz71ACeOMB/s6C0OiVsrhjBAyOI iBcPyMuMpx38jwt0vDsepudMedBpvxyG7eg5C6rYuDdO6k42eTskjmK2DtPkjrHEG91w TbkJ/aJbgkJLAucd/UEs2xkNFQa/Yqvt/wT+UwXWAMjd8UDQRaf5DctEfca2jiCBTpOB YEeg== X-Gm-Message-State: AOAM533x5cfEYsmddpgGkWgHwOkqyA/Go5MEn1X1i3lxKkYC7fug0ot1 x5F+V6D6lNT8wCEqM0EjS9y1p7vWM5ENYg== X-Received: by 2002:a17:902:b082:b029:113:e50d:c404 with SMTP id p2-20020a170902b082b0290113e50dc404mr32923002plr.5.1625077957259; Wed, 30 Jun 2021 11:32:37 -0700 (PDT) Received: from localhost.localdomain ([71.212.149.176]) by smtp.gmail.com with ESMTPSA id m18sm23909517pff.88.2021.06.30.11.32.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Jun 2021 11:32:37 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v2 16/28] target/mips: Fix missing else in gen_goto_tb Date: Wed, 30 Jun 2021 11:32:14 -0700 Message-Id: <20210630183226.3290849-17-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210630183226.3290849-1-richard.henderson@linaro.org> References: <20210630183226.3290849-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::1035; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1035.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Do not emit dead code for the singlestep_enabled case, after having exited the TB with a debug exception. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/mips/tcg/translate.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.25.1 diff --git a/target/mips/tcg/translate.c b/target/mips/tcg/translate.c index 52ae88b777..17e79f3de3 100644 --- a/target/mips/tcg/translate.c +++ b/target/mips/tcg/translate.c @@ -5030,8 +5030,9 @@ static void gen_goto_tb(DisasContext *ctx, int n, target_ulong dest) if (ctx->base.singlestep_enabled) { save_cpu_state(ctx, 0); gen_helper_raise_exception_debug(cpu_env); + } else { + tcg_gen_lookup_and_goto_ptr(); } - tcg_gen_lookup_and_goto_ptr(); } }