diff mbox series

[v2,22/28] target/s390x: Use translator_use_goto_tb

Message ID 20210630183226.3290849-23-richard.henderson@linaro.org
State Superseded
Headers show
Series accel/tcg: Introduce translator_use_goto_tb | expand

Commit Message

Richard Henderson June 30, 2021, 6:32 p.m. UTC
Cc: David Hildenbrand <david@redhat.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

---
 target/s390x/translate.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

-- 
2.25.1

Comments

David Hildenbrand July 1, 2021, 7:42 a.m. UTC | #1
On 30.06.21 20:32, Richard Henderson wrote:
> Cc: David Hildenbrand <david@redhat.com>

> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

> ---

>   target/s390x/translate.c | 7 +------

>   1 file changed, 1 insertion(+), 6 deletions(-)

> 

> diff --git a/target/s390x/translate.c b/target/s390x/translate.c

> index 03dab9f350..117a890ecd 100644

> --- a/target/s390x/translate.c

> +++ b/target/s390x/translate.c

> @@ -697,12 +697,7 @@ static bool use_goto_tb(DisasContext *s, uint64_t dest)

>       if (unlikely(use_exit_tb(s))) {

>           return false;

>       }

> -#ifndef CONFIG_USER_ONLY

> -    return (dest & TARGET_PAGE_MASK) == (s->base.tb->pc & TARGET_PAGE_MASK) ||

> -           (dest & TARGET_PAGE_MASK) == (s->base.pc_next & TARGET_PAGE_MASK);

> -#else

> -    return true;

> -#endif

> +    return translator_use_goto_tb(&s->base, dest);

>   }

>   

>   static void account_noninline_branch(DisasContext *s, int cc_op)

> 


Reviewed-by: David Hildenbrand <david@redhat.com>


-- 
Thanks,

David / dhildenb
diff mbox series

Patch

diff --git a/target/s390x/translate.c b/target/s390x/translate.c
index 03dab9f350..117a890ecd 100644
--- a/target/s390x/translate.c
+++ b/target/s390x/translate.c
@@ -697,12 +697,7 @@  static bool use_goto_tb(DisasContext *s, uint64_t dest)
     if (unlikely(use_exit_tb(s))) {
         return false;
     }
-#ifndef CONFIG_USER_ONLY
-    return (dest & TARGET_PAGE_MASK) == (s->base.tb->pc & TARGET_PAGE_MASK) ||
-           (dest & TARGET_PAGE_MASK) == (s->base.pc_next & TARGET_PAGE_MASK);
-#else
-    return true;
-#endif
+    return translator_use_goto_tb(&s->base, dest);
 }
 
 static void account_noninline_branch(DisasContext *s, int cc_op)