From patchwork Wed Jun 30 18:32:24 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 468727 Delivered-To: patch@linaro.org Received: by 2002:a02:c94a:0:0:0:0:0 with SMTP id u10csp617266jao; Wed, 30 Jun 2021 11:47:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJycGyjV+jquilkJBlpf7zraXhVp6UvPz+pPAqpL99Q1U4mMXYq8K8tP9/W7jUIqcSzbCI+K X-Received: by 2002:a1f:1603:: with SMTP id 3mr29852907vkw.0.1625078859837; Wed, 30 Jun 2021 11:47:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625078859; cv=none; d=google.com; s=arc-20160816; b=BMl2W1QO8RFWEIa+5DslUrQI6gdGmySv3f72zQytyxzLUnBYb9mvusMXDz1B0lQSUA xwIQbBTe9/0vlKUjYwGe3vtxZewgHpmMgeG4f9+Sf8gqfXXYTEK+bnLsGEkcBpD3iJn7 qUr3jGov69HvwCWmPSAEuyZrHANYkOJSLCCu+wVbWl2BvCxAEkJY/EvtWrr2/ZNqL1XX Jo5h0xFCTlD/4t4/vsg31Qe+C5zzahPKh0MSEGuEPDsCBbN7d2iXRpfvUbGJS4ZSd1DL S5adPG4GCE7h75ycuUGSmCodwRTpjiSnkUEaKgBLBYkr8Iw/kaWbIk5heo/o/nicxwyy Tlbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=HmrvZ2YDmFmQRowDiyGgkhSWbFuv8fekjQLGpsBU/NM=; b=DFyqW6X+0dnGNZbLZWcA9i3I7l1jNVW4vJdMUc9xW16o3TQnZQ4AhCx+hJc93mfOW8 qF+Ot/bbnFCZ0b99DhHcYQftPBpoGCVinlkJod6SCgHnwyHxsRHrRiwu/3sL7xixh5o7 67Fo9AJjM4KUJDHJlN7nRGEI82qcR5F/BplH5X2MT83i/ybXUUDbpOXy3jGs6ZkAj/sP 54q2OMYYCkg0sWDUZelKJYac38+fS06lX6eavZC9XUlcu1tiaW9Gv5DM5IdM7PH3+SeY Qzo9gqr4cZD6RUaqUxWM19F88FSKxhRPDkK68xrzVON0jBUUFJ5S4wRLrTZX2apZcB6z j79g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ekLix1XC; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id x62si3267731vkd.84.2021.06.30.11.47.39 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 30 Jun 2021 11:47:39 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ekLix1XC; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:43032 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lyfFL-0003OD-7M for patch@linaro.org; Wed, 30 Jun 2021 14:47:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45698) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lyf0w-0005iU-Eq for qemu-devel@nongnu.org; Wed, 30 Jun 2021 14:32:46 -0400 Received: from mail-pf1-x435.google.com ([2607:f8b0:4864:20::435]:44761) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lyf0u-000295-Kh for qemu-devel@nongnu.org; Wed, 30 Jun 2021 14:32:46 -0400 Received: by mail-pf1-x435.google.com with SMTP id g21so3294057pfc.11 for ; Wed, 30 Jun 2021 11:32:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HmrvZ2YDmFmQRowDiyGgkhSWbFuv8fekjQLGpsBU/NM=; b=ekLix1XCLSvz6b8h7f8cx7/My6vueHR/trnQ/pu1a/YM14JF5iRUiL2iJxpF2Jsjn3 9/lstKSfp9+WNxVau8TVNPQx+haTrDQy6JQVXZnKEZikaUxlEkobfqvVXc9jt4OtQ9Yy 5uInSLRq5ua/AvsNbWd70cuBGcTz/OSytxFYu+H2OmzBd7yDxw6cG7F2nU8YntnL+zOy 0THvF+Clw7O4b3an0nI62pXfNNkA5mQ/YJBPb8qQzoxwjE9/U++2969znzO25h04/YEo U36iTwCjSuZ9X7kqmhJCFvwX8Pt3qNLFMpS4CaSNLOJCrTillFyLT/uj/rMIPLZ4Vzjb 0JAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HmrvZ2YDmFmQRowDiyGgkhSWbFuv8fekjQLGpsBU/NM=; b=hrW+DGr5r41RlKfFOO/cjwYJ3J3kWaX6zitn+us4ROjXUQmyA16BLsMQbkks/mZvdp UuM1mM9jA9iseWU0M5ObuWM7Kn7QZ3aNGP7aL4Hc4k+rxAsOGfPPMzG6oC7H13FspXdY +jkphn7hMTUJx4xkFg/I37aK4espJuiOmxa1WL8FdRJh2EL3w4x5EvYSmTMsFk68UWfq uWQSzbGuSTgqfa+lhggWWXqiGmv1OOI50ar4YZxNutZqI1tMs0Zb97Mdo2SxsWoqBneY HWhfYPqRxRbt7IrqWUydfu5rOtSRRM1cwPSKfVFBUFXBd0+wGMOPFqzx+rN9GYmmi7m/ lmIw== X-Gm-Message-State: AOAM5317gwqhtUA6z0y84ZXnPeuW8ma02ZnPdpWJOSrawSAabON4OOXV zHc81fq7UVON9OffQeeua3lGNvc/IbirnA== X-Received: by 2002:a63:3704:: with SMTP id e4mr34965806pga.310.1625077963390; Wed, 30 Jun 2021 11:32:43 -0700 (PDT) Received: from localhost.localdomain ([71.212.149.176]) by smtp.gmail.com with ESMTPSA id m18sm23909517pff.88.2021.06.30.11.32.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Jun 2021 11:32:43 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v2 26/28] target/tricore: Use translator_use_goto_tb Date: Wed, 30 Jun 2021 11:32:24 -0700 Message-Id: <20210630183226.3290849-27-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210630183226.3290849-1-richard.henderson@linaro.org> References: <20210630183226.3290849-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::435; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x435.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bastian Koppelmann Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Just use translator_use_goto_tb directly at the one call site, rather than maintaining a local wrapper. Reviewed-by: Bastian Koppelmann Signed-off-by: Richard Henderson --- target/tricore/translate.c | 17 ++--------------- 1 file changed, 2 insertions(+), 15 deletions(-) -- 2.25.1 diff --git a/target/tricore/translate.c b/target/tricore/translate.c index 2a814263de..09465ea013 100644 --- a/target/tricore/translate.c +++ b/target/tricore/translate.c @@ -3225,19 +3225,6 @@ static inline void gen_save_pc(target_ulong pc) tcg_gen_movi_tl(cpu_PC, pc); } -static inline bool use_goto_tb(DisasContext *ctx, target_ulong dest) -{ - if (unlikely(ctx->base.singlestep_enabled)) { - return false; - } - -#ifndef CONFIG_USER_ONLY - return (ctx->base.tb->pc & TARGET_PAGE_MASK) == (dest & TARGET_PAGE_MASK); -#else - return true; -#endif -} - static void generate_qemu_excp(DisasContext *ctx, int excp) { TCGv_i32 tmp = tcg_const_i32(excp); @@ -3246,9 +3233,9 @@ static void generate_qemu_excp(DisasContext *ctx, int excp) tcg_temp_free(tmp); } -static inline void gen_goto_tb(DisasContext *ctx, int n, target_ulong dest) +static void gen_goto_tb(DisasContext *ctx, int n, target_ulong dest) { - if (use_goto_tb(ctx, dest)) { + if (translator_use_goto_tb(&ctx->base, dest)) { tcg_gen_goto_tb(n); gen_save_pc(dest); tcg_gen_exit_tb(ctx->base.tb, n);