diff mbox series

[08/11] linux-user/syscall: Remove unused variable from execve

Message ID 20210712215535.1471256-9-richard.henderson@linaro.org
State Superseded
Headers show
Series Fixes for clang-13 plus tcg/ppc | expand

Commit Message

Richard Henderson July 12, 2021, 9:55 p.m. UTC 
From clang-13:
linux-user/syscall.c:8503:17: error: variable 'total_size' set but not used \
    [-Werror,-Wunused-but-set-variable]

Cc: Laurent Vivier <laurent@vivier.eu>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

---
 linux-user/syscall.c | 3 ---
 1 file changed, 3 deletions(-)

-- 
2.25.1

Comments

Laurent Vivier July 13, 2021, 1:57 p.m. UTC | #1 
Le 12/07/2021 à 23:55, Richard Henderson a écrit :
> From clang-13:

> linux-user/syscall.c:8503:17: error: variable 'total_size' set but not used \

>     [-Werror,-Wunused-but-set-variable]

> 

> Cc: Laurent Vivier <laurent@vivier.eu>

> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

> ---

>  linux-user/syscall.c | 3 ---

>  1 file changed, 3 deletions(-)

> 

> diff --git a/linux-user/syscall.c b/linux-user/syscall.c

> index 2e826206d2..c27debba8c 100644

> --- a/linux-user/syscall.c

> +++ b/linux-user/syscall.c

> @@ -8500,7 +8500,6 @@ static abi_long do_syscall1(void *cpu_env, int num, abi_long arg1,

>              abi_ulong guest_envp;

>              abi_ulong addr;

>              char **q;

> -            int total_size = 0;

>  

>              argc = 0;

>              guest_argp = arg2;

> @@ -8532,7 +8531,6 @@ static abi_long do_syscall1(void *cpu_env, int num, abi_long arg1,

>                      break;

>                  if (!(*q = lock_user_string(addr)))

>                      goto execve_efault;

> -                total_size += strlen(*q) + 1;

>              }

>              *q = NULL;

>  

> @@ -8544,7 +8542,6 @@ static abi_long do_syscall1(void *cpu_env, int num, abi_long arg1,

>                      break;

>                  if (!(*q = lock_user_string(addr)))

>                      goto execve_efault;

> -                total_size += strlen(*q) + 1;

>              }

>              *q = NULL;

>  

> 


Acked-by: Laurent Vivier <laurent@vivier.eu>
diff mbox series

Patch

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 2e826206d2..c27debba8c 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -8500,7 +8500,6 @@  static abi_long do_syscall1(void *cpu_env, int num, abi_long arg1,
             abi_ulong guest_envp;
             abi_ulong addr;
             char **q;
-            int total_size = 0;
 
             argc = 0;
             guest_argp = arg2;
@@ -8532,7 +8531,6 @@  static abi_long do_syscall1(void *cpu_env, int num, abi_long arg1,
                     break;
                 if (!(*q = lock_user_string(addr)))
                     goto execve_efault;
-                total_size += strlen(*q) + 1;
             }
             *q = NULL;
 
@@ -8544,7 +8542,6 @@  static abi_long do_syscall1(void *cpu_env, int num, abi_long arg1,
                     break;
                 if (!(*q = lock_user_string(addr)))
                     goto execve_efault;
-                total_size += strlen(*q) + 1;
             }
             *q = NULL;