From patchwork Wed Jul 21 19:59:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 483332 Delivered-To: patch@linaro.org Received: by 2002:a02:c94a:0:0:0:0:0 with SMTP id u10csp6522794jao; Wed, 21 Jul 2021 13:10:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwj3seRWtJyc979FSMNXcOeIJDR1fdskQkH8qxVwRNP57pnIKt26tBbX2W4VUfdif/PthtO X-Received: by 2002:a1f:1d94:: with SMTP id d142mr33885932vkd.6.1626898258620; Wed, 21 Jul 2021 13:10:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626898258; cv=none; d=google.com; s=arc-20160816; b=so4TlQF7Ach8DbCFFjI0o/IXcd5/fi6g0KT8JMgl+a0c4Mo2NMzx435HQso4RvQFEm FLbgOUXvNUnYCl5pVrqJZv+9zC/xkrG9bhCPUzEybYM5iTdvqLJ/dBZ1bRLk2lkKsN6k xNfEOIUrdfsX7w/6uGKyawZevGD76NZM/pIKR891Jp2I4y317S0H/SMk5TI4BWF7Q3PU oAjVNJIiaDcHiiWXEOQWOR5BJAyQX2Cs/assWPqcw96br5D1WDocXZN5Bi3qA5tJRcgo 9uUI8Dap0PySNIoyZxlUZgIORqXmhvJ4m7tqLU8kFCunDRboxMncswGPzJ7CMi7jD6ZA 62Vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=5munM6eZd/uk4n4hD7SHb+ixOouAZHeY9ReXlmZhFgI=; b=PzCyoBADZQjuH4vS8bqFC7DMVG+EB1AzpBjD/CR4TtsNy46x9fQiTGFFTPb0LioPCL XT9n1bpdkArdbg7eosevYuKP03+0TfQJ5L2R2H9ydx8FOUBpEdf7eTsYSrHwuXFq9Yzr lI65R3L0uWFlBXKRs2F0/v9HRYUfw8dU6Tnp4E6Am0vOvD9GwUmdWgg0hAIBWYOgsrbk d16Zlet6EPdosWufvXECw7Ok3M9iB1lE9ATpI1QQR7S3z9OY1yRV6+/ERJBVOExH1nv+ iGDb97eM7IeCumqkAjKo138/OQT76bomY6BO8w7o+rC0jon9PzRLJU5ZGaopdRCD+il4 rDmw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=viTLpVQE; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id v25si7380637vsi.356.2021.07.21.13.10.58 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 21 Jul 2021 13:10:58 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=viTLpVQE; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:49916 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m6IYU-0005SJ-0X for patch@linaro.org; Wed, 21 Jul 2021 16:10:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36660) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6IOA-0002sn-5M for qemu-devel@nongnu.org; Wed, 21 Jul 2021 16:00:18 -0400 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]:43523) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m6IO8-0005mC-CC for qemu-devel@nongnu.org; Wed, 21 Jul 2021 16:00:17 -0400 Received: by mail-pl1-x62e.google.com with SMTP id b12so1631148plh.10 for ; Wed, 21 Jul 2021 13:00:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5munM6eZd/uk4n4hD7SHb+ixOouAZHeY9ReXlmZhFgI=; b=viTLpVQEsZL+8QAxFbaPI6rVcRXgOVtwgaOYJDgajeXL453XnRJRNAKo2v3TynVoBH uAXZQiiUcrosc5Yht8YK8ThnOnaqfk5FjQPp4Ok7qjia+TkSDr7pKhHJCYUjxVLXWOe7 /gu4J8JQP6SxbEJAOLDO/UwNBdKCwy+XKclLniQ36P/zlYmd7j27c3ENcF7A7HzrVDag IXJk+iNe1bK/5MKJGdwV60XJtxnMV+XIzm8xfKKi0ib2CSiX5TPWsPEub6m+cOXAdumz daawhG3uTBJMghfBE3+l3VPWS2GIrwel3zgBYhMvxL7x0vx8PdyjRXhNgLh4byB3YtVM O50A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5munM6eZd/uk4n4hD7SHb+ixOouAZHeY9ReXlmZhFgI=; b=PkktjTtMjMv06iknfrs7udRTja1vD21JhGQrJtIyuGKBwkIWn7cwMQsg+KsyjnFTD7 epUCze8JGHGv0c4k3RDiK203awSOfzNhgkrFt47KYxxyn/MZUsqCyjRaKxudvv84aONQ t9X5rK4F6NWatWZxVP9l8VbgpK6oXLCE8G6A7bybXP0mmUqEEE5a2GOz6QG1QRmoUjvl rkxj1hzyTpQnSHp1Ab68pWtw/ncNs/HiF2aaHjE+HVsWl9GZEt1yyHFSkKoXoOpObNDs WtRdHK6hVmhmCOqTRqG+eQrg8oXfpKdxnacWNIQOgefN2t7NmYL+fOz43J58ieianqid IAnw== X-Gm-Message-State: AOAM530Z11AqU3oeQdf+3GPwoUYHDd7pRKnTb3uROZNxBSWcUGJKHWZG ufkXojT5Up+17binq0ItPbUdBFztxT6gnw== X-Received: by 2002:a63:9d46:: with SMTP id i67mr37992809pgd.225.1626897615033; Wed, 21 Jul 2021 13:00:15 -0700 (PDT) Received: from localhost.localdomain (204-210-126-223.res.spectrum.com. [204.210.126.223]) by smtp.gmail.com with ESMTPSA id w3sm706028pjq.12.2021.07.21.13.00.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jul 2021 13:00:14 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 13/27] target/alpha: Drop goto_tb path in gen_call_pal Date: Wed, 21 Jul 2021 09:59:40 -1000 Message-Id: <20210721195954.879535-14-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210721195954.879535-1-richard.henderson@linaro.org> References: <20210721195954.879535-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::62e; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" We are certain of a page crossing here, entering the PALcode image, so the call to use_goto_tb that should have been here will never succeed. We are shortly going to add an assert to tcg_gen_goto_tb that would trigger for this case. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/alpha/translate.c | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) -- 2.25.1 diff --git a/target/alpha/translate.c b/target/alpha/translate.c index 103c6326a2..949ba6ffde 100644 --- a/target/alpha/translate.c +++ b/target/alpha/translate.c @@ -1207,19 +1207,8 @@ static DisasJumpType gen_call_pal(DisasContext *ctx, int palcode) ? 0x2000 + (palcode - 0x80) * 64 : 0x1000 + palcode * 64); - /* Since the destination is running in PALmode, we don't really - need the page permissions check. We'll see the existence of - the page when we create the TB, and we'll flush all TBs if - we change the PAL base register. */ - if (!ctx->base.singlestep_enabled) { - tcg_gen_goto_tb(0); - tcg_gen_movi_i64(cpu_pc, entry); - tcg_gen_exit_tb(ctx->base.tb, 0); - return DISAS_NORETURN; - } else { - tcg_gen_movi_i64(cpu_pc, entry); - return DISAS_PC_UPDATED; - } + tcg_gen_movi_i64(cpu_pc, entry); + return DISAS_PC_UPDATED; } #endif }