| Message ID | 20210730105947.28215-6-peter.maydell@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | softmmu: Clean up arch_init.c | expand |
On 7/30/21 12:59 PM, Peter Maydell wrote: > When Hexagon was added we forgot to add it to the QEMU_ARCH_* > enumeration. This doesn't cause a visible effect because at the > moment Hexagon is linux-user only and the QEMU_ARCH_* constants are > only used in softmmu, but we might as well add it in, since it's the > only architecture currently missing from the list. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > --- > include/sysemu/arch_init.h | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
On 7/30/21 12:59 AM, Peter Maydell wrote: > When Hexagon was added we forgot to add it to the QEMU_ARCH_* > enumeration. This doesn't cause a visible effect because at the > moment Hexagon is linux-user only and the QEMU_ARCH_* constants are > only used in softmmu, but we might as well add it in, since it's the > only architecture currently missing from the list. > > Signed-off-by: Peter Maydell<peter.maydell@linaro.org> > --- > include/sysemu/arch_init.h | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
> -----Original Message----- > From: Qemu-devel <qemu-devel- > bounces+tsimpson=quicinc.com@nongnu.org> On Behalf Of Peter Maydell > Sent: Friday, July 30, 2021 5:00 AM > To: qemu-devel@nongnu.org > Cc: Paolo Bonzini <pbonzini@redhat.com>; Markus Armbruster > <armbru@redhat.com>; Eduardo Habkost <ehabkost@redhat.com> > Subject: [PATCH for-6.2 5/8] arch_init.h: Add QEMU_ARCH_HEXAGON > > When Hexagon was added we forgot to add it to the QEMU_ARCH_* > enumeration. This doesn't cause a visible effect because at the moment > Hexagon is linux-user only and the QEMU_ARCH_* constants are only used > in softmmu, but we might as well add it in, since it's the only architecture > currently missing from the list. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > + QEMU_ARCH_HEXAGON = (1 << 22), Reviewed-by: Taylor Simpson <tsimpson@quicinc.com>
diff --git a/include/sysemu/arch_init.h b/include/sysemu/arch_init.h index 57caad1c675..60270c5ad15 100644 --- a/include/sysemu/arch_init.h +++ b/include/sysemu/arch_init.h @@ -23,6 +23,7 @@ enum { QEMU_ARCH_RISCV = (1 << 19), QEMU_ARCH_RX = (1 << 20), QEMU_ARCH_AVR = (1 << 21), + QEMU_ARCH_HEXAGON = (1 << 22), QEMU_ARCH_NONE = (1 << 31), };
When Hexagon was added we forgot to add it to the QEMU_ARCH_* enumeration. This doesn't cause a visible effect because at the moment Hexagon is linux-user only and the QEMU_ARCH_* constants are only used in softmmu, but we might as well add it in, since it's the only architecture currently missing from the list. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> --- include/sysemu/arch_init.h | 1 + 1 file changed, 1 insertion(+) -- 2.20.1