From patchwork Wed Sep 29 13:05:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 514843 Delivered-To: patch@linaro.org Received: by 2002:a05:6638:4087:0:0:0:0 with SMTP id m7csp21801jam; Wed, 29 Sep 2021 06:23:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxX+/pGSMQ4S6vZNFuIwWY26yx7TWFoXRD1SGsrWE767dayGHP4EX7Gf5YLAecT10MQzdBT X-Received: by 2002:a1c:29c7:: with SMTP id p190mr10481065wmp.65.1632921819640; Wed, 29 Sep 2021 06:23:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632921819; cv=none; d=google.com; s=arc-20160816; b=r4TGjGgysfX6vIbQ77goYt0p+mlQ98r3+ZpOP+Pk1V4RofzkWykDmlkxeUkmKbtpux xojxosDOUypRsYq86v+rj1yAFjHuI5ih7JZbYg4xr0dBEgUwHpxuYYxctsXnG+U30cHI vcjgHkNIgjDl3T3JQMvvp8k3ctmuwBD6wnbUAR+e4LGKhyYM+/CWAMkPI4D3bxFmJtVP YfaVwZPmUwJvE9228uEXr/xz22ywJjoKhC7ecD2GSl1R3VxfQ7zzWi2y3MeBWS5McNyH jLcjFzppntNZ/oIeLsMDTrMy587neYJhsMc5WpuSgnCprOkOTQrJ8cxu08SHSJnbNUad lBZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=kxfPZ7H57dcm7rNQ+f9pWEPpiqUmhBqRaotBBFRVjb0=; b=eQpKxwEiVxtT5iNZHp11wLSuekHCR2Y9dW7tcMke+F9a/YqCA2c7QvO2xDAXN/e5B6 M3fTlhGTALg29pRWj7+5MOzib3CqFpBdDOCvXnub+UKgpaEus6IOnLZ+Qv4QaHfMmu7L wQ2Sg2utIqCg/DPz+yjcuOpGVDF6t/ryE7ugjFPEab8asAUaUvspx78LoaA9RJGyKuO7 3gsc7Af9cpxB8dS1+mtn58u1V5UbOVMrRPyML3iUGcNz1uYFt+MNZMv4QseTbsaKoACj KdViK2u4xrsRsLexuNWiICuk6woswqTBgc+ipYWMGs+u+m/yNFkhiBNB9cRhI+Od5BqL T51Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=duCHCXaH; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id c14si3459416wri.266.2021.09.29.06.23.39 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 29 Sep 2021 06:23:39 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=duCHCXaH; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:41348 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mVZYg-0007Nt-Md for patch@linaro.org; Wed, 29 Sep 2021 09:23:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39368) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVZI7-00076w-CT for qemu-devel@nongnu.org; Wed, 29 Sep 2021 09:06:31 -0400 Received: from mail-oi1-x234.google.com ([2607:f8b0:4864:20::234]:40457) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mVZI5-0006Gk-J3 for qemu-devel@nongnu.org; Wed, 29 Sep 2021 09:06:31 -0400 Received: by mail-oi1-x234.google.com with SMTP id t189so2790451oie.7 for ; Wed, 29 Sep 2021 06:06:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kxfPZ7H57dcm7rNQ+f9pWEPpiqUmhBqRaotBBFRVjb0=; b=duCHCXaHJUtA2SEMwqZKrJXZqWrsAz+Ay1RWsWOWtboCEhd9PbuaNKAYLl21mE/Ul+ sLF5GDJFtYid0Wiqfcskn5ObFOMDILyLJtlzTjxZoOe19xWuVcXOuwmJxryy03nOGYCi c8sy5zYH//fQ64N0NSZ9PJIQkRJ/aa9Bg3TL2Ncd/aB42ny1pZxf5222APqLWhtXmPj7 sGHAMOTecc48hk4dTYM1LssxgeJWNed1SK/yHTURshD/RQq/tTHxLWDTfzE4B8RgiclP 0UovcmiQ6sU/SDs6vDuWMTEFzdbYZldgPl1fymtL4nuvJ1xxpMZ/l8QfLwhJmYxDgDNE 6+0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kxfPZ7H57dcm7rNQ+f9pWEPpiqUmhBqRaotBBFRVjb0=; b=i0AhHkJD1ylW/lu6ju5meGWw1fl3uCY3y6pponGZqy+TJzLpEhAvQ4p7q17tOVnlZs zTaiPxNzjgBxuTd5CMtp83x3eSjs5zbd7w/c0SewLtEGCxK6ouZt5+XT7Itxrinz/GMg lSSgrGeSdaG3CfZUc1bDZFY8tbARh0fNSI19AjIbPiPAUUVaMegQ+P3JeVC/aN5aRMmU 8I8qaaRGOOimzx6yHpkqJYnul9aPGBGjODUdpJUG7i3+cTrXMHniTzp/5jCz/YGwfe6y DdnKCYug719/7ih/CuRTn3oe/guzqWX12byvlYk7YF8MTbpQzL5id5VdUs+1OnlOM5Tr jXdQ== X-Gm-Message-State: AOAM533FBZtlnfg5wyS9+8rncRK0GAjBm/jILtFEa0eZWFrdpqKQkdAX Kvo2FeCqDwpvIF/K5CBDNjmTeC9a/YNBnA== X-Received: by 2002:a05:6808:180c:: with SMTP id bh12mr7956316oib.78.1632920788466; Wed, 29 Sep 2021 06:06:28 -0700 (PDT) Received: from localhost.localdomain ([172.58.171.248]) by smtp.gmail.com with ESMTPSA id w1sm442823ote.41.2021.09.29.06.06.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Sep 2021 06:06:28 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v5 14/26] linux-user/mips: Tidy install_sigtramp Date: Wed, 29 Sep 2021 09:05:41 -0400 Message-Id: <20210929130553.121567-15-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210929130553.121567-1-richard.henderson@linaro.org> References: <20210929130553.121567-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::234; envelope-from=richard.henderson@linaro.org; helo=mail-oi1-x234.google.com X-Spam_score_int: -1 X-Spam_score: -0.2 X-Spam_bar: / X-Spam_report: (-0.2 / 5.0 requ) DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org, laurent@vivier.eu, =?utf-8?q?Philippe_Mathieu-?= =?utf-8?b?RGF1ZMOp?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The return value is constant 0, and unused as well -- change to void. Drop inline marker. Change tramp type to uint32_t* for clarity. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- linux-user/mips/signal.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) -- 2.25.1 diff --git a/linux-user/mips/signal.c b/linux-user/mips/signal.c index d174b3453c..64072779b9 100644 --- a/linux-user/mips/signal.c +++ b/linux-user/mips/signal.c @@ -87,10 +87,8 @@ struct target_rt_sigframe { }; /* Install trampoline to jump back from signal handler */ -static inline int install_sigtramp(unsigned int *tramp, unsigned int syscall) +static void install_sigtramp(uint32_t *tramp, unsigned int syscall) { - int err = 0; - /* * Set up the return code ... * @@ -100,7 +98,6 @@ static inline int install_sigtramp(unsigned int *tramp, unsigned int syscall) __put_user(0x24020000 + syscall, tramp + 0); __put_user(0x0000000c , tramp + 1); - return err; } static inline void setup_sigcontext(CPUMIPSState *regs,