From patchwork Fri Oct 15 04:10:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 515831 Delivered-To: patch@linaro.org Received: by 2002:ac0:da11:0:0:0:0:0 with SMTP id d17csp150603imi; Thu, 14 Oct 2021 21:46:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyGy8RKZSJOp/Acmg+AuIHO40sLiZWIZSAcdRGDKUFmUPAVhv/wpJjiFUQcvbvHb577dCrx X-Received: by 2002:a25:d290:: with SMTP id j138mr11745029ybg.381.1634273192467; Thu, 14 Oct 2021 21:46:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634273192; cv=none; d=google.com; s=arc-20160816; b=NaDbsohTk4neTUu0PvvXUpj9PnnTGtTohAclaYv08tUpje3ydJRDIiHC8mPcjOjze9 6U/cCQVL02gOd2f7wdQCONFaj+WP/ngAX4ktf9XYrdsWk4F597QxJ/e0UMrJbCkKmMNu w9PVNXMMZ5m3Kcngruw0JXH9bqPrNMp+82UFgAvcWPINmIWwzX2ad6IN/WpeuMetOD9D B1Izs5OSDanlu2g6oJpaGiX8gT63hbDW0Mx0UmCFwx5VBs7tUf0EN0/ZStEsMIOYHZLL k3rLbihl2haRxpiReO4wzBkEYdY2cwBS0VirPDza4FJ1R66bSftZ2k9hd1bWqXVSINlI ixHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=P+LiSx7CkE3blKbhg5ALaxOT08dtFOhalcqlNc9ibvc=; b=m/8NQNTCaK/ubm108eJ1YCxL0yaaze++gg8hWv9ma1P0lKvNaJyZXRuXZuWA3f1T7q s1AW1OUFJR279SckxJY8WycBf5Tzv6MLZqY6Wtjm3Rb97wHFCffiXoPFA+3zPSPpYIxJ q6TeYdaDE6nhkmrOlNjlmQSazFkE6U3Ob1Z8NpiAYi2Ph2iiIcvNsBf/YA4z2bKFhPB8 yTIJI0UYpHKqEFly1Zs9Ej1N2PN9ROlt1HggF+h443KsjuWwYBec0hlbOln2OlV5tYbn AMsBYzNvyOBAmnsGMpTvZoiIIqPCYkQgqphRhm7bFLXjAjlUpcOAnNkbYN9JxF1eVd88 Cxyw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=fkD5lzW8; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id c187si5390115ybb.58.2021.10.14.21.46.32 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 14 Oct 2021 21:46:32 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=fkD5lzW8; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:47568 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mbF71-0005Oz-OK for patch@linaro.org; Fri, 15 Oct 2021 00:46:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39632) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mbEcD-0006tE-Jx for qemu-devel@nongnu.org; Fri, 15 Oct 2021 00:14:43 -0400 Received: from mail-pf1-x435.google.com ([2607:f8b0:4864:20::435]:46614) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mbEcC-0002ul-24 for qemu-devel@nongnu.org; Fri, 15 Oct 2021 00:14:41 -0400 Received: by mail-pf1-x435.google.com with SMTP id i76so5155377pfe.13 for ; Thu, 14 Oct 2021 21:14:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=P+LiSx7CkE3blKbhg5ALaxOT08dtFOhalcqlNc9ibvc=; b=fkD5lzW8XEdW/8JddIYnS/3TBxtw+Z4dI0TbGhaI8Owa2wXINxDYLYYG4N0ClA3Xy5 dhDSus9p4jC14sPZXFqh/5UkbhTjlcZyyXyG91Pc1iMvM+H4ALkI8K1yTYG3WR6ltsDu Hym9K1DLHee57sI1ZPRMWz+K0/X8AWVEFEPHOXQfCqqzTfS1JHM5yh29ZRBtmCcTKSYE T34yzzIkzG8r00mnTgYPVuGP2AW8hGXvzBQOp9Yh8LqJWKvFAhBuVdLvVpRVT5uOKpeA eXG1K2QfwdE22EpTNl6Ay8mHRSBlIS3+3RLxvh6Sqo1outCX4mPwXXKpdT4q6XUN56gy zM/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=P+LiSx7CkE3blKbhg5ALaxOT08dtFOhalcqlNc9ibvc=; b=0H4ZZ0/6vDxD5ue4Uv3d2sfGhoiyN0pDRJobSQNepeQOQcDrMZ1Ik5fYFemyvuPNCx obxgKGhmxlfYdRIc7K88JfTH347NdE6mW98wx0itD556QGmt3e6j5eGXWBQ+b4PVllTQ yMRPxe5CDp8V2/fu9FyeOvzsNcSC40AAYHac6iX8qk5aTAiDWp7ftXIk3cDCuKFiIRTd o4/j1UBHUEphGdJIJ4JTYlnScYwRSr7fBTMNp7/TSHHDpiBcZnlmMICPdB4aH7fSod/d IXdTefPjzBFEhBhtwN55jhm6Wg0C4eql0oDC0Qe0uVeG5d1ndPXPI6LOY48tJBTHgHvc Bc/A== X-Gm-Message-State: AOAM5327KRvoBiREg1589wcPGIez2KbEj8J/wekSXYUtKuUxhBzI9iLl lFCvRRS5ra35qEZq7kO+YqTucPllO9oMbQ== X-Received: by 2002:a63:f313:: with SMTP id l19mr7496427pgh.40.1634271278750; Thu, 14 Oct 2021 21:14:38 -0700 (PDT) Received: from localhost.localdomain ([71.212.134.125]) by smtp.gmail.com with ESMTPSA id q8sm10236885pja.52.2021.10.14.21.14.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Oct 2021 21:14:38 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v5 55/67] target/sparc: Remove DEBUG_UNALIGNED Date: Thu, 14 Oct 2021 21:10:41 -0700 Message-Id: <20211015041053.2769193-56-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211015041053.2769193-1-richard.henderson@linaro.org> References: <20211015041053.2769193-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::435; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x435.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Cave-Ayland , alex.bennee@linaro.org, laurent@vivier.eu, imp@bsdimp.com, =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?b?w6k=?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The printf should have been qemu_log_mask, the parameters themselves no longer compile, and because this is placed before unwinding the PC is actively wrong. We get better (and correct) logging on the other side of raising the exception, in sparc_cpu_do_interrupt. Reviewed-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/sparc/ldst_helper.c | 9 --------- 1 file changed, 9 deletions(-) -- 2.25.1 diff --git a/target/sparc/ldst_helper.c b/target/sparc/ldst_helper.c index bbf3601cb1..0549b6adf1 100644 --- a/target/sparc/ldst_helper.c +++ b/target/sparc/ldst_helper.c @@ -27,7 +27,6 @@ //#define DEBUG_MMU //#define DEBUG_MXCC -//#define DEBUG_UNALIGNED //#define DEBUG_UNASSIGNED //#define DEBUG_ASI //#define DEBUG_CACHE_CONTROL @@ -364,10 +363,6 @@ static void do_check_align(CPUSPARCState *env, target_ulong addr, uint32_t align, uintptr_t ra) { if (addr & align) { -#ifdef DEBUG_UNALIGNED - printf("Unaligned access to 0x" TARGET_FMT_lx " from 0x" TARGET_FMT_lx - "\n", addr, env->pc); -#endif cpu_raise_exception_ra(env, TT_UNALIGNED, ra); } } @@ -1968,10 +1963,6 @@ void QEMU_NORETURN sparc_cpu_do_unaligned_access(CPUState *cs, vaddr addr, SPARCCPU *cpu = SPARC_CPU(cs); CPUSPARCState *env = &cpu->env; -#ifdef DEBUG_UNALIGNED - printf("Unaligned access to 0x" TARGET_FMT_lx " from 0x" TARGET_FMT_lx - "\n", addr, env->pc); -#endif cpu_raise_exception_ra(env, TT_UNALIGNED, retaddr); } #endif