From patchwork Wed Oct 20 17:27:42 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jean-Philippe Brucker X-Patchwork-Id: 516028 Delivered-To: patch@linaro.org Received: by 2002:ac0:cd8c:0:0:0:0:0 with SMTP id d12csp2032444imp; Wed, 20 Oct 2021 10:42:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzQlryHd6+eL1lLpfqZhn8X490/cfOfh4zHZ0MOLGj09216lzhqOgy30pWp64Fab8LBztyD X-Received: by 2002:a67:ec55:: with SMTP id z21mr486460vso.29.1634751759978; Wed, 20 Oct 2021 10:42:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634751759; cv=none; d=google.com; s=arc-20160816; b=oS42evr+uHFApQgLW01aA10A3sgjDGNp9mLXaXNg3JnnaFbx+UuqOiB7HsxjIRaa4/ 9231NWo7iISwpbhrtNENNQXLcKl9X24ZrjYXkIQe5UMJIV19kOeC/vxrcutshcemf0ei Ywj0toabfq8U0HrRk4X/uXmaY0riUX1PIKNaYllU7MyHXXEf3fzw4SzwscVYa3j/F9u2 Q7yLoIKONjsOSp6uNdYVz6oSr4goK7jS9dRiBFiSOzHoMmmHne+QgfC6BKI1rLnIlzzF jVxjfC8uMQBuL/psJU6Zf43SsZlDhFOlghdwzuKadE6oN9VJeuJXIDsaoDoKRwmvR224 gKFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=MQaHeRwjBXtlwH+HWJdlO988bBQFl1PSkeW02oBI2yE=; b=n1vJNmq6FXMU+Z+ywNmpKC5E6nQzAlHGsWNRzCBpCNDeFbeKtKXKFXlXuM1tfDtC/F q0jGpDifT5HzbSSU228O7oxWYPgQCg1B/Du625He4aHSh7jtKzDkeuOOqfIneqpOx4sk r/JhXL5W+WoPMTqh/rfYpvZvUHXnRkiAvxEvgjLfEZfF7cSTd1dk2ht0lER3JFN4hNww Ma3MXbwMYdeH0RxxflLJdPWxa/wZZL30soYS1LbxMIFZ9HgCp0ZUEbciDn+KObkbqg1j K6yndAtbk0Xblk1BC4PBQII2RIkgsZ0GlUITJndLLg0u6mUQrCFfsE+6E5YhqFa7p6YB nFnw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=cnvSmzp5; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id q185si3074527vkg.98.2021.10.20.10.42.39 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Oct 2021 10:42:39 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=cnvSmzp5; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:44306 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mdFbr-0003PK-C9 for patch@linaro.org; Wed, 20 Oct 2021 13:42:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37524) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mdFUb-0005FL-HG for qemu-devel@nongnu.org; Wed, 20 Oct 2021 13:35:09 -0400 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]:37571) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mdFUZ-0002eu-P7 for qemu-devel@nongnu.org; Wed, 20 Oct 2021 13:35:09 -0400 Received: by mail-wm1-x333.google.com with SMTP id g79-20020a1c2052000000b00323023159e1so3419162wmg.2 for ; Wed, 20 Oct 2021 10:35:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MQaHeRwjBXtlwH+HWJdlO988bBQFl1PSkeW02oBI2yE=; b=cnvSmzp5Q5I2fhVe8VKQflUG8EBRmB7TnGd+GGy+RlewS6eQFKzYmUXNbh4AxF91Hp 5UT4MA6u6aC7nkqjsvkvVZemBaagF26NqnCjPBjsnNGF8r/7pW1nsfFgaf39t0yOINr/ /k7kMl85EU0lV2wE5s1SeQPesy5JbtnJ2GNmNAZqRCtji+ISFur4/0jdltyQyIU+JKfO H9aUWbvrQXYetFarD+02xCWEPRHy+z/CqFkjrylyC34oDIfc8G8Lt0ZfKa2l2kdeqCRd MLpM3TOnP/8GlM1677chK4nA0pvLSZlJlnyg3TP2LZQlRebKK4vN4cPdzj4NOD1BtT5O pVXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MQaHeRwjBXtlwH+HWJdlO988bBQFl1PSkeW02oBI2yE=; b=PPflgwACaTAjV0Rr+BlPr+bSQJuq9sXj9HgQc4ukBmguQ8lMmoUxyXaCylcK05r1Em RcqOS4JCmfO80CGGPpLZ1oryHbN4ZmtYpvuUDE5g9JFf0ARAAupK0E8suaUSgdrvbIZT DxeLe+RtgfqBiyC9a1C8ikT1nvTH7ptqovEYk0mq1GLv7Pbd7ZmqfxXXLqqLV9z3nado Jc+Xa3sFsPFbAlXnFjsHXSbKpSvqHPTJFzzk0tXlEVZxDFUcwXV6SmRswgJC8zodoEW1 sBEAQzeuaV1vMbxRpbW2Vl5wzr5tAHUhcpQO/Xq3zOw0Dr95Mz//6M1e0epytYOOpax/ WZNg== X-Gm-Message-State: AOAM530y3iO+WEc2SnneIj8KmrEC9SrWMELjMBwij40KJ0AhFmrvHsFf J1/31i+/yq5Q1e26goZbsZyXWA== X-Received: by 2002:a05:600c:1d19:: with SMTP id l25mr671862wms.119.1634751306327; Wed, 20 Oct 2021 10:35:06 -0700 (PDT) Received: from localhost.localdomain (cpc92880-cmbg19-2-0-cust679.5-4.cable.virginm.net. [82.27.106.168]) by smtp.gmail.com with ESMTPSA id n7sm2662270wrp.17.2021.10.20.10.35.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Oct 2021 10:35:05 -0700 (PDT) From: Jean-Philippe Brucker To: mst@redhat.com, imammedo@redhat.com, peter.maydell@linaro.org Subject: [PATCH v5 08/12] hw/arm/virt: Use object_property_set instead of qdev_prop_set Date: Wed, 20 Oct 2021 18:27:42 +0100 Message-Id: <20211020172745.620101-9-jean-philippe@linaro.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211020172745.620101-1-jean-philippe@linaro.org> References: <20211020172745.620101-1-jean-philippe@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=jean-philippe@linaro.org; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jean-Philippe Brucker , ehabkost@redhat.com, eric.auger@redhat.com, jasowang@redhat.com, richard.henderson@linaro.org, qemu-devel@nongnu.org, peterx@redhat.com, shannon.zhaosl@gmail.com, qemu-arm@nongnu.org, ani@anisinha.ca, pbonzini@redhat.com Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" To propagate errors to the caller of the pre_plug callback, use the object_poperty_set*() functions directly instead of the qdev_prop_set*() helpers. Suggested-by: Igor Mammedov Reviewed-by: Eric Auger Reviewed-by: Igor Mammedov Signed-off-by: Jean-Philippe Brucker --- hw/arm/virt.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -- 2.33.0 diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 25db8d4262..7a061ab401 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -2465,8 +2465,9 @@ static void virt_machine_device_pre_plug_cb(HotplugHandler *hotplug_dev, db_start, db_end, VIRTIO_IOMMU_RESV_MEM_T_MSI); - qdev_prop_set_uint32(dev, "len-reserved-regions", 1); - qdev_prop_set_string(dev, "reserved-regions[0]", resv_prop_str); + object_property_set_uint(OBJECT(dev), "len-reserved-regions", 1, errp); + object_property_set_str(OBJECT(dev), "reserved-regions[0]", + resv_prop_str, errp); g_free(resv_prop_str); } }