From patchwork Sat Oct 30 17:16:23 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 516512 Delivered-To: patch@linaro.org Received: by 2002:ad5:5208:0:0:0:0:0 with SMTP id p8csp1459686iml; Sat, 30 Oct 2021 11:30:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx5eRm24F5O24Me5sW9aZoWCG/kLhLPYTTmGJM3/rB5GSwu+C1wuBb2VLoxGxVSdWLLZ31S X-Received: by 2002:a05:6808:1988:: with SMTP id bj8mr13173440oib.32.1635618608128; Sat, 30 Oct 2021 11:30:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635618608; cv=none; d=google.com; s=arc-20160816; b=SvYx2hu568uCbbmj+2PfB8K1UqiudvOOgLrjDjQaROsEwQHSd2M1rAcwaLNLMPfZVD SZYYSJ3VGb8i//zduW1Kon3onaEyUzDKkqhq3AVKJ0HYPBucQN/bKFjHlXPFgeq2QfX2 ywqXBUpXz3K/c620C2M/ENGIJlNkGvSqPRS3Drq9q961t7CsJYEyTKw3kWku+qLGVUyT t3NR4iNw1QyvfZk6a4Rg7u40EF5hDiTNjcNV5UcdYjLAo5ji7e24vFrMIhHs6Y7j17Hk +fi6sr3ubu6bxBn9VfIB8FYEf9ydK/9zxUT0LrsFjsfw+R0k0hE9jvy4uWEfFLPsPwvW b/yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=P+LiSx7CkE3blKbhg5ALaxOT08dtFOhalcqlNc9ibvc=; b=IO+gaxHcQ9v/kF2HppKZVzPYZsOWwWEhR6XU3oDXNrsVVv0O7vVDq8Ig37bIvc8ixy vo2M5PSpmO4d1bogMNfCZ8R95ZDHtTTSZ1VVcoTE/jQuNoFNUGPCsVFpwF6ufgSXVhTU hKUZ5UFxDTfaGG3H0rOM9EfHrwW79bKRZNv+2z45qG+NpeSXVPTdEIaVcqKe6iK4f+OX +qPDwnn5ZYZ7Eyzaeph/Fy/uG0xTyFZbekCZtiQf3ybyNyEVD/qwhXPVqNih/MF2J+LG F9snf6iKBn9TWXouDwGBzip+PGjZpyzMeCO3uvwF7lTq0R8aumjm5NdXe+VBBRv+6pPt RfWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=Os4XC7xz; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id w3si2254014otm.187.2021.10.30.11.30.08 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 30 Oct 2021 11:30:08 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=Os4XC7xz; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:46824 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mgt7H-0003tL-ET for patch@linaro.org; Sat, 30 Oct 2021 14:30:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58788) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mgs1v-0001Yx-LE for qemu-devel@nongnu.org; Sat, 30 Oct 2021 13:20:32 -0400 Received: from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434]:38681) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mgs1r-0002DO-Ud for qemu-devel@nongnu.org; Sat, 30 Oct 2021 13:20:31 -0400 Received: by mail-pf1-x434.google.com with SMTP id l1so5883362pfu.5 for ; Sat, 30 Oct 2021 10:20:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=P+LiSx7CkE3blKbhg5ALaxOT08dtFOhalcqlNc9ibvc=; b=Os4XC7xz6OE376lMGaw9BdNtb0/eK6y4plZLVIEqixEnuGmuzbgFQ8CbmcF/M1BYy1 uHaTqevjdhlADWORORgQwL7rzVf0S9txLdsouVEzE+yOPWCKD04NvrlWNSKWJPQybOEQ zzaDdooye3tbLPZIZqW/aGooaVla6hdpmdOdF6CAJDqP+OTnvdY5ufsdcKZvv8w869sM yGxkpGKeliwLQVVAOkTa+tG3JISQsj3a6nGy9VGUsid9BnaQgZ31kaW3KpgO6PhZ/RYY 00/qOiSo0MC00u8FTEtfl09kwAfWOPeVnNpvSE8m0pzXkfYmFrB6LyWZVuEjNK+JeH2D gRtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=P+LiSx7CkE3blKbhg5ALaxOT08dtFOhalcqlNc9ibvc=; b=HAOsRrJjfxZ0ysOMPC8aCNPZKrNwe0cPub1HPBtxfgkj5da8ShDy3879ZXMUiKCMgc ezVCfStSAHVl8qc/ApcSMVRLbCN1yhxIoJvx+XLrCUkGwSYn4x/rZmOcgXu3+8kr+jqZ +9FkREjrnLywRHaz9Fb7S0Y90rIoLVsBPyRoUB517eUtHD7ThnW9B+hYA143XfcNipWz TEn3m/NijFZFGr5q0/Fc9MrDW2jqFMl6JHgQnUcDNyLbPQqXFOuFRKpM43RbKTv3cbyo PVYsCbMOKPrg2ykQ+XEv3HRRCVj/cXGc1KI0Y4hbwI4xjOSGmW+yta++D2E+z4nLNFW9 0N2g== X-Gm-Message-State: AOAM531eyouKbU4GXrgMYeh38rMViUGqn6Un3RGwM17Hf/N6zScIuf9T UinkBcr40Fembhv6Z+i4v6/ZWxGre3uv2w== X-Received: by 2002:a62:e901:0:b0:47b:f1bc:55e4 with SMTP id j1-20020a62e901000000b0047bf1bc55e4mr18596171pfh.0.1635614426387; Sat, 30 Oct 2021 10:20:26 -0700 (PDT) Received: from localhost.localdomain (174-21-75-75.tukw.qwest.net. [174.21.75.75]) by smtp.gmail.com with ESMTPSA id k14sm9584798pji.45.2021.10.30.10.20.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 Oct 2021 10:20:25 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v6 54/66] target/sparc: Remove DEBUG_UNALIGNED Date: Sat, 30 Oct 2021 10:16:23 -0700 Message-Id: <20211030171635.1689530-55-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211030171635.1689530-1-richard.henderson@linaro.org> References: <20211030171635.1689530-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::434; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Cave-Ayland , alex.bennee@linaro.org, laurent@vivier.eu, imp@bsdimp.com, f4bug@amsat.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The printf should have been qemu_log_mask, the parameters themselves no longer compile, and because this is placed before unwinding the PC is actively wrong. We get better (and correct) logging on the other side of raising the exception, in sparc_cpu_do_interrupt. Reviewed-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/sparc/ldst_helper.c | 9 --------- 1 file changed, 9 deletions(-) -- 2.25.1 diff --git a/target/sparc/ldst_helper.c b/target/sparc/ldst_helper.c index bbf3601cb1..0549b6adf1 100644 --- a/target/sparc/ldst_helper.c +++ b/target/sparc/ldst_helper.c @@ -27,7 +27,6 @@ //#define DEBUG_MMU //#define DEBUG_MXCC -//#define DEBUG_UNALIGNED //#define DEBUG_UNASSIGNED //#define DEBUG_ASI //#define DEBUG_CACHE_CONTROL @@ -364,10 +363,6 @@ static void do_check_align(CPUSPARCState *env, target_ulong addr, uint32_t align, uintptr_t ra) { if (addr & align) { -#ifdef DEBUG_UNALIGNED - printf("Unaligned access to 0x" TARGET_FMT_lx " from 0x" TARGET_FMT_lx - "\n", addr, env->pc); -#endif cpu_raise_exception_ra(env, TT_UNALIGNED, ra); } } @@ -1968,10 +1963,6 @@ void QEMU_NORETURN sparc_cpu_do_unaligned_access(CPUState *cs, vaddr addr, SPARCCPU *cpu = SPARC_CPU(cs); CPUSPARCState *env = &cpu->env; -#ifdef DEBUG_UNALIGNED - printf("Unaligned access to 0x" TARGET_FMT_lx " from 0x" TARGET_FMT_lx - "\n", addr, env->pc); -#endif cpu_raise_exception_ra(env, TT_UNALIGNED, retaddr); } #endif