From patchwork Wed Nov 3 15:04:28 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 516770 Delivered-To: patch@linaro.org Received: by 2002:adf:eccd:0:0:0:0:0 with SMTP id s13csp725679wro; Wed, 3 Nov 2021 08:21:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyscgVv8iRwDiXYu0QUTlX/xRJN0R+d1y5c0jzOGG0T3lmvNjW1Wyg97HL71NVEmF1p7OSI X-Received: by 2002:a05:6808:ecf:: with SMTP id q15mr11150649oiv.57.1635952884850; Wed, 03 Nov 2021 08:21:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635952884; cv=none; d=google.com; s=arc-20160816; b=J4i+gM0cZGGtEsr0dx3Op1nBxOV+YLuvlWu9f8qUahYWpEoxrR3OMsk40hOFW9YgDx /XXaJjmreSXYbJ8SI5ES/CaXvmPb0aUPtOuAolvzKZRPjoC3u7hFJjZFyX6M6qGglWSM WYhKV8Z2dECUQIDZPGDXgE24wlVUCU1x6TGlOV3s+lxYjEiRhBVHcQnx+1W+2nKuFIdO 1Fc8MuKIfLVkpMnB3c6SpnlPgL7UoqFael2/1onsFxIAPCFDSib1uwPVEKgP4pJ3krED Xdx90c9tR+3Ne5Sny2LubDPiqC2tTJKpKmDwBLlUKVXPd/J7oUNPKacDd5arBf/b5JMY aKUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=rnSjJep00PuWrOp9q/49ZO8vTrCgwf3MZFCi6UASDb4=; b=rJUcYig5pxcPsuVzK8t1BNGspLVt38w4+kUH0na9qmsGExkpcSla7yeWpc9iHq7Rmu exq2b0sFRSUWLqMPmCunw9ElLAD+GHXReOoB9mSrruS7MDcK8sg2b/b+FYCtU7bjtGNe PTeI4fKEuSKcNaIXQmTxKvwg3GbHxbQlHX1QYCMZP8fNDo2P5nBKEVmzC7yVqqWSES5c tckMTCSpIbeKne5sARlBa49Y2Woy5aaws7OSAdWnVEHin+y21L6HbW3CM+pKb5yellDe eY1foyYCobQaKnFAwQkqvW3KpO4ID/NXnq9mDyzxLj+3lmrwkwAJ/F83DSsj9NndOH4p il+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20210112 header.b=RU+tuUJp; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id u6si4840602oiw.189.2021.11.03.08.21.24 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 03 Nov 2021 08:21:24 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20210112 header.b=RU+tuUJp; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:60556 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1miI4q-0002g3-6H for patch@linaro.org; Wed, 03 Nov 2021 11:21:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52136) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1miHp8-0003UY-TN; Wed, 03 Nov 2021 11:05:12 -0400 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]:43534) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1miHoz-0000YY-Mx; Wed, 03 Nov 2021 11:05:10 -0400 Received: by mail-wr1-x42b.google.com with SMTP id t30so4023620wra.10; Wed, 03 Nov 2021 08:05:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rnSjJep00PuWrOp9q/49ZO8vTrCgwf3MZFCi6UASDb4=; b=RU+tuUJp+V8KINeMxy4e7TN7PJ6Mw9ZQ3n+xB8KTEsVv29nLMsQhD1Dk6y+fBnPOzm IHkNVN+i6chyZN2gGQh309VtmuIe/n1m0JSyVbkqv6upUFc0VMgcFmBMtdFZMV616x1B CJJOtTbltL3m3INnSpQQ3mizzENssJB/9yBBOEuI6o54ImI1lsM6+UFT25X7/1noLqRz DFqaqrithXsMzlpgHVpYSglY3ohmTkOO7IzHYcfPN+ZIZdhzWP/8Pq29f+GNw43WxI+f IaSPXYB8PeMFqohOFumPncTB27mgx8swNSW73vkcQeuPBas6zdB0bBeufhGnNIpv8jXO eJkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=rnSjJep00PuWrOp9q/49ZO8vTrCgwf3MZFCi6UASDb4=; b=AW5KEFje3Cu5sEOyWSSOv53KZp05VR2gbm+lAhU0RL0OnhwCk50Jz7gr/CMzAMiNT0 WYubnDOgPbzpQ4t7q32UaO8BPATitL0fCNhfW2KvT4UM/XpU0PT4iqDuvxBfNjEbiDj7 MQ5fxHSEgNHQOa0QLgviBD8lTS9NFMoe5WKi6dQgsRpcExK6ebTRcR4kTFIxrSn8s29t y9Z7RK/keBVxq8s0U9CfYn9m0PyzRkUGcHVoB3zEXFuDn4k8fBjEoBtIEmRaQhFLdxoN p0PevzAWq46ZNaOBLnSooTx9pD9USJWFjyRMAMnNSMdaAI24rnwkL3/xcDP9cZ0iJqgx 4keg== X-Gm-Message-State: AOAM530Pg9EtcguRYpnDRnF/rSYvee7hiM7Gg36ctbopSzkA8Q4rizkZ 4sPre1a23knr5JW9Fd4zBNAqOPrmQF4= X-Received: by 2002:a5d:6449:: with SMTP id d9mr30395276wrw.332.1635951899677; Wed, 03 Nov 2021 08:04:59 -0700 (PDT) Received: from avogadro.lan ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id h16sm2488797wrm.27.2021.11.03.08.04.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Nov 2021 08:04:59 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Subject: [PULL 13/27] hw/i386: Rename default_bus_bypass_iommu Date: Wed, 3 Nov 2021 16:04:28 +0100 Message-Id: <20211103150442.387121-14-pbonzini@redhat.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211103150442.387121-1-pbonzini@redhat.com> References: <20211103150442.387121-1-pbonzini@redhat.com> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42b; envelope-from=paolo.bonzini@gmail.com; helo=mail-wr1-x42b.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jean-Philippe Brucker , =?utf-8?q?Philippe_M?= =?utf-8?q?athieu-Daud=C3=A9?= , qemu-stable@nongnu.org, Eric Auger Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Jean-Philippe Brucker Since commit d8fb7d0969d5 ("vl: switch -M parsing to keyval"), machine parameter definitions cannot use underscores, because keyval_dashify() transforms them to dashes and the parser doesn't find the parameter. This affects option default_bus_bypass_iommu which was introduced in the same release: $ qemu-system-x86_64 -M q35,default_bus_bypass_iommu=on qemu-system-x86_64: Property 'pc-q35-6.1-machine.default-bus-bypass-iommu' not found Rename the parameter to "default-bus-bypass-iommu". Passing "default_bus_bypass_iommu" is still valid since the underscore are transformed automatically. Fixes: c9e96b04fc19 ("hw/i386: Add a default_bus_bypass_iommu pc machine option") Reviewed-by: Eric Auger Reviewed-by: Philippe Mathieu-Daudé Tested-by: Eric Auger Signed-off-by: Jean-Philippe Brucker Message-Id: <20211025104737.1560274-1-jean-philippe@linaro.org> Cc: qemu-stable@nongnu.org Signed-off-by: Paolo Bonzini --- hw/i386/pc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.31.1 diff --git a/hw/i386/pc.c b/hw/i386/pc.c index fcfb7f7139..ac5af274cd 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -1718,7 +1718,7 @@ static void pc_machine_class_init(ObjectClass *oc, void *data) object_class_property_add_bool(oc, "hpet", pc_machine_get_hpet, pc_machine_set_hpet); - object_class_property_add_bool(oc, "default_bus_bypass_iommu", + object_class_property_add_bool(oc, "default-bus-bypass-iommu", pc_machine_get_default_bus_bypass_iommu, pc_machine_set_default_bus_bypass_iommu);