From patchwork Sat Mar 26 13:24:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 554351 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:1248:0:0:0:0 with SMTP id z8csp6425840mag; Sat, 26 Mar 2022 06:32:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxnW14M+UJ9tjS4lq5nE1Tx/q7k9ST9VWGlX85T+SyUhywxOaBUN128X0bWNS9jSUwEOa/R X-Received: by 2002:a05:622a:1aaa:b0:2e1:a40d:8253 with SMTP id s42-20020a05622a1aaa00b002e1a40d8253mr13812388qtc.135.1648301558541; Sat, 26 Mar 2022 06:32:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648301558; cv=none; d=google.com; s=arc-20160816; b=raj8A2SdmUxLadxYM0EwDSe5yW9AgwPoOfVsX5FQ4PAjr4AorDNrLjRkfaT0lsKDFW yg1Jw+N3umD9d6Rkxfe3tb4LDtRsHl0+1b0yan/B/LbMLNOTzWae3TY8Y0kctiW73w0h Rg/vOKlFZ/ugQNTUPiAZJXP4ZUfZLoD59y/C6qv+vC9bp+NEPlFLAzpvfBnZdYfjVGfg eX01pRCB1vXHb84pcx0Rj3hl6jtR7IA/AHSy/zz7+niz35276U8e35xkH2mdbD5RQ3TE ixQ8gwIpN2j2D4u4/lQIeKN6TAsHiDkygRUIBdxMrIiJwbcP8ggZHCm5AZZUgz8nVpAG nTWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=26hq51RiROI5XzJelEXkN2uWQhOSPbaaTZ3h8qaX6EQ=; b=C5AAjkdcW+NRRpSy94ALb2oBpmVKDxlXXavbN9vQNZWXcgU2FCmxKLuqh2RZcyGFww kcSI4jf7SnZKJxTTa6W114TIexrKR3aRtJ9RA4xCb0kuu1xF2WRaubloW5UzndrT3UTT HglCQlIiirusYJrP0mqz2QqMaG34vDvKlW5dWVZGMk76zd4JexNRWS8hlv25aUPL85pn LYd6U6ATFXGhqjG3DctCbWohTjQQxPsSrX0d0+wy2mC9SGqP4xmZinpnEpRYDn3s7Ia/ uaDhkwqL3Bf6tI1qoyg+GwjBGkdXVId/U7y74iJacKIMMUDh8eOIe8SYr+HuoIu3g4Ra gKNA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=tmp1KyD2; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id t128-20020a37aa86000000b0067e4be23a6esi2613072qke.691.2022.03.26.06.32.38 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 26 Mar 2022 06:32:38 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=tmp1KyD2; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:42320 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nY6X0-0004g0-3x for patch@linaro.org; Sat, 26 Mar 2022 09:32:38 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33832) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nY6QT-0006s4-Fv for qemu-devel@nongnu.org; Sat, 26 Mar 2022 09:25:53 -0400 Received: from [2001:4860:4864:20::2d] (port=43740 helo=mail-oa1-x2d.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nY6QR-0005LI-Vz for qemu-devel@nongnu.org; Sat, 26 Mar 2022 09:25:53 -0400 Received: by mail-oa1-x2d.google.com with SMTP id 586e51a60fabf-de2cb87f6aso10701951fac.10 for ; Sat, 26 Mar 2022 06:25:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=26hq51RiROI5XzJelEXkN2uWQhOSPbaaTZ3h8qaX6EQ=; b=tmp1KyD2RxKn8kkjT/Pq/xtKXGmQuRbrstjmfzhPbR2m3ehHWVK7Qihw7UoLYgIQQ+ CburleEMw7mmkyscoqqSU0cKSn+RU3jkueJfIAOrZKujoC9jCwVm7OchO2XbTW6fyyxj QvrzjkpNHfbZY6EqnOtmwYC5YB95uEJWhpJLkJzgFtSbgFPLv/MG7fG+g/to7gbq01LH 06NTba4kr17+0Ve9jbAfdB7qwqI2bW1u+4Dn89/gSxtA1htaPaaarEgb02PMCEE+mIIe Laa+lyxksZrKBGO/hkQOSapZ9y1nCWRFMtpAQhKplqoPZXtoeMN1mm7w8yHOkZrormCZ TYkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=26hq51RiROI5XzJelEXkN2uWQhOSPbaaTZ3h8qaX6EQ=; b=otsr+34VDebvEJUQTa45lKhyL46aQl9Je8duDGLetopfgtnyMJ2VTe8hrM44/O/c99 sqZl3tc9FRmQgOgiQmzEhCx3GWJgKJk5kdn3NXHcnkyhwofkzyM//XFDSfd3MPlJP90a s079p00GMUowTQu0Mk2v5RTGzT0ejMU7bmCLfmiMiw4gasZzwevfyIOIvpB5tlC+9CJc 2QtJ3uHlBLs8zyFM725/ViTI1oYH+ovYVXXadnYG+0ykNRzWZS8o9knyAS2WCzJ4UIgJ VXhDAYKSvw3HWNUQUSCYVEbkBZC9tZnpOrAKph73JesoZyUgPZz0yo/jHbmMGyCjBrQg zQAQ== X-Gm-Message-State: AOAM533N+ePPnXapf4wErRdNG16kE5MXgNe4R/yzZJd0oW9Faq7yxwxr gpkQujEY+KS9k4nAC5HxI8jrn/MQLiraYc2a X-Received: by 2002:a05:6870:3394:b0:dd:cfdd:34c9 with SMTP id w20-20020a056870339400b000ddcfdd34c9mr11506299oae.31.1648301147081; Sat, 26 Mar 2022 06:25:47 -0700 (PDT) Received: from localhost.localdomain (168.189-204-159.bestelclientes.com.mx. [189.204.159.168]) by smtp.gmail.com with ESMTPSA id n62-20020acaef41000000b002ef646e6690sm4610331oih.53.2022.03.26.06.25.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Mar 2022 06:25:46 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v2 4/8] linux-user/nios2: Adjust error return Date: Sat, 26 Mar 2022 07:24:54 -0600 Message-Id: <20220326132534.543738-8-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220326132534.543738-1-richard.henderson@linaro.org> References: <20220326132534.543738-1-richard.henderson@linaro.org> MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2001:4860:4864:20::2d (failed) Received-SPF: pass client-ip=2001:4860:4864:20::2d; envelope-from=richard.henderson@linaro.org; helo=mail-oa1-x2d.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.659, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Follow the kernel assembly, which considers all negative return values to be errors. Signed-off-by: Richard Henderson --- linux-user/nios2/cpu_loop.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/linux-user/nios2/cpu_loop.c b/linux-user/nios2/cpu_loop.c index a285781fc5..969460df58 100644 --- a/linux-user/nios2/cpu_loop.c +++ b/linux-user/nios2/cpu_loop.c @@ -55,9 +55,14 @@ void cpu_loop(CPUNios2State *env) env->regs[7], env->regs[8], env->regs[9], 0, 0); + /* + * See the code after translate_rc_and_ret: all negative + * values are errors (aided by userspace restricted to 2G), + * errno is returned positive in r2, and error indication + * is a boolean in r7. + */ env->regs[2] = abs(ret); - /* Return value is 0..4096 */ - env->regs[7] = ret > 0xfffff000u; + env->regs[7] = ret < 0; break; case 1: