From patchwork Sun Apr 17 18:29:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 562894 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:6886:0:0:0:0 with SMTP id m6csp1888068map; Sun, 17 Apr 2022 12:07:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyVDVnKaS63V7E3Rfk5N1hedWtxkYhG6zAn94i3VBpMu105PsmIhT/DBrV8/IAw18Wg+Iy1 X-Received: by 2002:a37:5583:0:b0:69e:8c2c:8f89 with SMTP id j125-20020a375583000000b0069e8c2c8f89mr1787301qkb.571.1650222437002; Sun, 17 Apr 2022 12:07:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650222436; cv=none; d=google.com; s=arc-20160816; b=qP0PY41Iq1hxMtLJeS4LLBdCEea1ds8voTz0U2sIchg/R8ZplJ6NBKEjHA2fy5ftkl zX90dHK3WXNV/KfrX0GK/Tn6kjx//+ZYS0TVrGXCQCGeAQn5ZymEWd0m0k14viPF3RvS pYyj6+okXZMgFLw8PdVP4XAlFTTSgukY9+Xjv1S45sd9XxAAihIUJmMoOnElU61cwGKJ TNJjt21vBATOmg1dffvgUIqID20NxxXRq6BTkkUnAUtwptlIYzNNvgAAFS3oZjNU1JfM kfTdhXPcZP2OwXsLSXz/sD+qEzEOdUUebj48tluTDw8PP2UcRMu892AIarasM2CUbROU au5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=BY6AMJvNmzcszeZ7iu4WSrEG8O0G/uroM/T7KokfH/A=; b=wPs/li0Xj6qlK/t6F9j/EIJUXfgOAQ3Qs9cuDcnhhkOwSVcexX171THKc6HDaMX3m4 7uNcIUig9dTi8F9441bxmrOTIVGoxuQ9uMfkA5MyaKg8XvoVWmwD61Rz0FmDsJPEZMiF JCBBYw7QAFPkb/mJv9fk01iHxuvy//H2zHw1pYFs0MBg4qK33bQwAEulTQ3YKMP2CYmu WaNPBUwJpgd5e6aerI/epNumjcU819KfWxhqgy2LNJV+diXISCIQObo0KRzmSKyp0SbJ m01HbwbcjyhibXD5i+Ety4FnYnJtHmGydW2PYLqHgRYUdnu7ED1uoYu97V1ia5uemsZy 1FxA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=bNoB1C5V; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id k66-20020a378845000000b0069bdcd494basi2122692qkd.369.2022.04.17.12.07.16 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 17 Apr 2022 12:07:16 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=bNoB1C5V; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:33998 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ngAEu-0004oo-IP for patch@linaro.org; Sun, 17 Apr 2022 15:07:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57314) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ng9fW-0000Tw-MQ for qemu-devel@nongnu.org; Sun, 17 Apr 2022 14:30:46 -0400 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]:36643) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ng9fS-0001nP-WF for qemu-devel@nongnu.org; Sun, 17 Apr 2022 14:30:41 -0400 Received: by mail-pl1-x632.google.com with SMTP id q3so10807078plg.3 for ; Sun, 17 Apr 2022 11:30:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BY6AMJvNmzcszeZ7iu4WSrEG8O0G/uroM/T7KokfH/A=; b=bNoB1C5VKWK3iJZ8IPwwSXCPs9nlf+deYNvwl8JEalPdYgZvjK5Yg386pY5gXHCiN5 Yy6TpfvNcxfkNUPz/K5FggzYVcdMpEuaOQ/1w2T7NgdERJcKCsKC1OneaMKC3/tMX4+8 18K1AjxnM5JCpC8fotDmayhihr/KHvjUZy/sH7VPm/ygW+uDBV/zdTJQPVUdTeSUQDll zbRtpdshFuQp63oqH0ILfyj94NGmiqZXW+Or7YkbAZ7tuEdLfG7bMc9yiPKDSU3mNp1i dEgLJ0dqty5bXFk6xqToBXWFUBPqP+vVuhX/w35m6TqcIT1knOkGDH/aXt4RwobOATd/ UOqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BY6AMJvNmzcszeZ7iu4WSrEG8O0G/uroM/T7KokfH/A=; b=f5mvmKVj+edC7KfiDM2B3cjU86IFCNABIwi33Rd7jQbUBLUE8/xNRXO4Hki9gqsL3M VIt7sG9I9XBIvkUizpepbh5Z53V4wKLjqG8SqSdPBeu5kSZ1yN6ZaNhe+ovi7jlgQS3s DFHW29G4tDDoywL98F0beHECHfmrAf8v5j19uGGWg19hcTFvBQZij5c8UBDJELR0yNND s3W20Ymt96iKvhxIjYia2KMqlXUFMP7WG+h0fC7t5YtOKgwwziy5WbB8AOR/kbNamNC9 URLh+FXdTg09I4KW9ojLYWsOsCzfdwyCMHUo1T/sRdl4sxf/pZ4ez8ImK2z1qMA/FCQI tGjw== X-Gm-Message-State: AOAM533CKfbt1mIxcXm202nm+c3VXPcRNd9wxr3h828Zdm1FzxBq/eD3 s2L+P3wFuWAgqnBPHgybZ9XTd82zVzw4xQ== X-Received: by 2002:a17:903:240c:b0:153:c8df:7207 with SMTP id e12-20020a170903240c00b00153c8df7207mr7803432plo.44.1650220235867; Sun, 17 Apr 2022 11:30:35 -0700 (PDT) Received: from localhost.localdomain (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id on10-20020a17090b1d0a00b001d08a7d569csm8154011pjb.56.2022.04.17.11.30.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Apr 2022 11:30:35 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v3 18/39] util/log: Mark qemu_log_trylock as G_GNUC_WARN_UNUSED_RESULT Date: Sun, 17 Apr 2022 11:29:58 -0700 Message-Id: <20220417183019.755276-19-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220417183019.755276-1-richard.henderson@linaro.org> References: <20220417183019.755276-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::632; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x632.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Now that all uses have been updated, consider a missing test of the result of qemu_log_trylock a bug and Werror. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- include/qemu/log.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/qemu/log.h b/include/qemu/log.h index 2d9455dc85..3a1f3a6020 100644 --- a/include/qemu/log.h +++ b/include/qemu/log.h @@ -67,7 +67,7 @@ static inline bool qemu_log_separate(void) /* Lock/unlock output. */ -FILE *qemu_log_trylock(void); +FILE *qemu_log_trylock(void) G_GNUC_WARN_UNUSED_RESULT; void qemu_log_unlock(FILE *fd); /* Logging functions: */