From patchwork Thu Apr 28 14:39:36 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 567192 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:6886:0:0:0:0 with SMTP id m6csp5563364map; Thu, 28 Apr 2022 08:27:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzBpwiblVmDuoAEcTOwWUsJDYSky6uXHLgePNTZ3DB71XzQfVhnTMcFelspKFXMFxke9Hlq X-Received: by 2002:a81:1107:0:b0:2f7:cf9a:bd7 with SMTP id 7-20020a811107000000b002f7cf9a0bd7mr25115159ywr.482.1651159646404; Thu, 28 Apr 2022 08:27:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651159646; cv=none; d=google.com; s=arc-20160816; b=xWMXjxh1OQuy60MlJI0JAF3oahC5k0bTVNRHkvKJnbBjO5vukVHAYg7P7LcOV/V9WA dfUSu6GzKcQf45YC+dd2YtgpJNbOqhsRmCHIVzbuoehSOAqmhoYqHF2HTZoAeS8/NTJL 14DdsqYmqu1Xz4hiZ7pyZKimV8VmcVN+tDPD9w3S0zqlshBIcV69KdVwXzL8Xu4Bt3eQ d2yRo1krOhE3YLYs14WlVmO3pCU+mwquPAq2Sf0xT+8lFLjBMSggUZ4rJgYLkx7wYN3A LUEK8g8AqepgBx42aaUvbnMuK8/A4QCrefJ4WjPRu8FX2Jx+oFxVSu+O/j8ivqe6lr9W bmxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=dqByHTIpXckxQO3WSn8IGmqemM6gCwyzc86ernwmw6M=; b=AhJ9Po0cekLmUXy7KQ3wgL2hyxAyswMWkuvpK6ENY8LX8FcqfzQW9osfSbBeR+YzOs rCwtql6Y0yO5ebV94vGqOOwPDk4df4J2AWHdzphVEri36TDewa/SjjEI68kgDo92RbAd 24BpxmClK+DEuXp86t/qqQl0wGmtXwIXBXxbod6CiszcBe56Fc9AtGG3VyVq/8FJ7Zmq tDvrlW0lcgpPqpXFnk8BcF2cL/Fx4hZFN+mzZKC1yjOnfaAd4bkp3KGOnryxE95DAneD qL4Ir2lN3WlV5rjwUKv5Za76QS+rqrJSwarIYGYaw3SweknTXTH0uirwUWhTWyXPi32I NSDg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=nflfjNKY; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id o7-20020a257307000000b00648bad1d648si3992787ybc.153.2022.04.28.08.27.26 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 Apr 2022 08:27:26 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=nflfjNKY; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:37722 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nk636-0007LX-Bk for patch@linaro.org; Thu, 28 Apr 2022 11:27:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45436) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nk5Jx-0005ak-Gc for qemu-devel@nongnu.org; Thu, 28 Apr 2022 10:40:43 -0400 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]:33710) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nk5Ju-0006Qr-Gq for qemu-devel@nongnu.org; Thu, 28 Apr 2022 10:40:41 -0400 Received: by mail-wr1-x433.google.com with SMTP id x18so7136318wrc.0 for ; Thu, 28 Apr 2022 07:40:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=dqByHTIpXckxQO3WSn8IGmqemM6gCwyzc86ernwmw6M=; b=nflfjNKYsi6vIAUJHxcCd8cfkFM7uknq9ePBq1fceos2+INjvz2/3DtN+Z8DHYl0j8 YgT6uMeYqu3wYy0FyjcO5MxAGE89jyZbaOU9Hr07BxJIaodEeiGT13NpHap1hTloHns2 2ZUkCzCSCQzi3ONox5e3CTsXQX65C4AUkHwaG0wNyR8NkADjoxu56wqGBO6ZgwaVHFWj v/nnpwyXJDXMmZ3tt+qN4plamzaDnoJ/hGVgXmQj9URkOpx4zHODX513RoDGyBLbK9Zy TdHCrV3CtsigLd9oNTu3ryiGKTyFrQmr7UNLshUL7r8QV2Zvkzm9WgPiLQkeR3v6yOiZ tQ2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dqByHTIpXckxQO3WSn8IGmqemM6gCwyzc86ernwmw6M=; b=Qodf2R4PQ3pb1chby4ha8Ab9RFoJOp/feQl7Ty73DCTH/HfP9j35P3i3/JdW1wVFU/ uOSg8VKQTVpX6T3gf4l8ehRGt/CuoThlWdi5BRSmBYPZwwMQd/YncQ4YLznh+9fWYVSg +IFPoNz1C+V7gySi7gZxQBFWCzxZhbVXzbWX5DhWkJDkzEu1bgdFPGXq/F99FeR0jwPs 9R1HYPfxS9OWO7jRq5A0aK4ecbD6LD3bu6FvdM/9bR9sSMgdXkfA05uBaX+Pu+0CjkEd 696rwBQAA5aURhQEBUquwsaaWng9QVHJDJuyvwIvntXypf2Wr22nnAFwyH+t+r+dxXUo l7iA== X-Gm-Message-State: AOAM533QV6X2ICZe3liMjgDg9HfUdtLzmVaVJ/Leluv2G6cAQNrGfrPt pXAzpltP7ZSCKfvM+/7w42YDGgxQsimWfA== X-Received: by 2002:adf:ee81:0:b0:206:1b32:d6f2 with SMTP id b1-20020adfee81000000b002061b32d6f2mr26114538wro.144.1651156832862; Thu, 28 Apr 2022 07:40:32 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id bh26-20020a05600c3d1a00b003928db85759sm130221wmb.15.2022.04.28.07.40.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Apr 2022 07:40:32 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 32/54] target/arm: Use tcg_constant in LDM, STM Date: Thu, 28 Apr 2022 15:39:36 +0100 Message-Id: <20220428143958.2451229-33-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220428143958.2451229-1-peter.maydell@linaro.org> References: <20220428143958.2451229-1-peter.maydell@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::433; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x433.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Richard Henderson Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Message-id: 20220426163043.100432-33-richard.henderson@linaro.org Signed-off-by: Peter Maydell --- target/arm/translate.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 24e522e1d6e..e0469da0a16 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -8050,7 +8050,7 @@ static bool op_stm(DisasContext *s, arg_ldst_block *a, int min_n) { int i, j, n, list, mem_idx; bool user = a->u; - TCGv_i32 addr, tmp, tmp2; + TCGv_i32 addr, tmp; if (user) { /* STM (user) */ @@ -8080,9 +8080,7 @@ static bool op_stm(DisasContext *s, arg_ldst_block *a, int min_n) if (user && i != 15) { tmp = tcg_temp_new_i32(); - tmp2 = tcg_const_i32(i); - gen_helper_get_user_reg(tmp, cpu_env, tmp2); - tcg_temp_free_i32(tmp2); + gen_helper_get_user_reg(tmp, cpu_env, tcg_constant_i32(i)); } else { tmp = load_reg(s, i); } @@ -8123,7 +8121,7 @@ static bool do_ldm(DisasContext *s, arg_ldst_block *a, int min_n) bool loaded_base; bool user = a->u; bool exc_return = false; - TCGv_i32 addr, tmp, tmp2, loaded_var; + TCGv_i32 addr, tmp, loaded_var; if (user) { /* LDM (user), LDM (exception return) */ @@ -8166,9 +8164,7 @@ static bool do_ldm(DisasContext *s, arg_ldst_block *a, int min_n) tmp = tcg_temp_new_i32(); gen_aa32_ld_i32(s, tmp, addr, mem_idx, MO_UL | MO_ALIGN); if (user) { - tmp2 = tcg_const_i32(i); - gen_helper_set_user_reg(cpu_env, tmp2, tmp); - tcg_temp_free_i32(tmp2); + gen_helper_set_user_reg(cpu_env, tcg_constant_i32(i), tmp); tcg_temp_free_i32(tmp); } else if (i == a->rn) { loaded_var = tmp;