From patchwork Thu May 19 17:36:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 574222 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:1f0e:0:0:0:0 with SMTP id hs14csp1547316mab; Thu, 19 May 2022 10:46:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJziSWs7cQMz30zPex7dYekANpnD3NTARJf6HAhF8bul9a9AE46wJ/YsK01cC0P+pe+EFVFg X-Received: by 2002:a05:6214:f06:b0:45b:127b:7dc9 with SMTP id gw6-20020a0562140f0600b0045b127b7dc9mr5060013qvb.8.1652982364074; Thu, 19 May 2022 10:46:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652982364; cv=none; d=google.com; s=arc-20160816; b=PqAfKJr+DcSwcvloBMNwNaYynpXJPrVYqbb3/eTTZ7jr4B3+fau2ufSual29bEO8OP 0IV6sqCxh8FTukh7P+MA2rrckcsW3HgQ/wegjJepJpxWARSVKOUaEF+lxiukftAst1z/ nBPsr+yQSD4hbzsoK0aCrVoQOtN2djDdAY9LHIsi3BDjwdrC3lxx4wgYGfJWnVSOzLOp jdpGP8epF69FzUEd3GHf9xDX7OoFsFA/+NMxCC+sU6qPC+F5PlGrdQ+oYHuT2wqItLXG RU/XH9pzCmFl4JtoA7cnr09bWZ/tQzcRmvz+iNiplrcmo4V1cZck2U4Y1LpR8BkdaBZW uSfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=oBDjhrpGMhR2z79//kfK50qDWOF/ekZ8L6UpCnRNBpM=; b=dFr6/3dSXizGrZbNekHQtq3n3iRsYncySvW52jIS9oXw7JTDB6KfYVYYR9GcNjhp1J L2VG+/vBOSbM9oC1Uhhjdo6o8o/yXEehocS77EXF6n0TMGdFPYsYvQqJ442wcsCNfHlX +Yr46+XCIs/P8cbzBrtNUQQjCDTholLi9NLpQDEsE5n8IFXIfNB6Cu+JNXuhfP5/e24h arPbMMTktTlf3w30VseZnoCvQc943WmgikFCQ0ZTgpDxv1bPP23RA2oikBDabO/B6A01 MD6WH5OhFt+uS26cAptgeVLOFLOVsK5LDGKXZvNq0ES2plEWPP1qe9nuzOwyD+d3I4ri +OVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DDU44fJ6; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 8-20020ac85948000000b002f3da34beeasi1479958qtz.463.2022.05.19.10.46.04 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 19 May 2022 10:46:04 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DDU44fJ6; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:45948 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nrkDr-00055L-LU for patch@linaro.org; Thu, 19 May 2022 13:46:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59554) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nrk5H-0006LF-1U for qemu-devel@nongnu.org; Thu, 19 May 2022 13:37:11 -0400 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]:52028) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nrk5F-0000qV-GV for qemu-devel@nongnu.org; Thu, 19 May 2022 13:37:10 -0400 Received: by mail-wm1-x330.google.com with SMTP id k26so3287566wms.1 for ; Thu, 19 May 2022 10:37:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=oBDjhrpGMhR2z79//kfK50qDWOF/ekZ8L6UpCnRNBpM=; b=DDU44fJ6lK5Ug8qYN5ULQt7qcoz5+U4ylK/XKZf0/S5BJCXAZjlyaPl9//JNso+WbP 9WfBRwmnDddNxqeJxg3EF8hbb3A47WeLtpXkCVaCMfrqRcA9wd/CEPG9LmZfzn40bUwa 3ydsvxzHWRtpJJi0gGoxxC6ZZSBSOH42I3f9EXNxQ6xpRfdHxbaaZWbYknIt3sTn7mps FYQrWXOveRtBH82SATKeL/NwLx+BrvNwxBVvcMakmyou7fmAMcfDXobCy67EmfTy4fJC aFqxL04MrNiTsL3U44qWik/gIMCUeEOHDUu6kaJh57+dGp7y2J4028ZB9+/y5BfjBRaI 4uRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=oBDjhrpGMhR2z79//kfK50qDWOF/ekZ8L6UpCnRNBpM=; b=jw9cYbsKp9uL5GmOALxjH1g0wC6yk9O7p0YjF/KRC9CmZVxF9AI4UnHQN6vo9mI94x H3m+VeppX00jGntQgcoU1bKHIV+qicFe9Cw0XFwbNxELbviO7R3HamydCHTQTx7MY6H1 m+u7w6x/cxkYim5TgtpBINMnS30hCHogjJo3MAiSJvsTO+jXW3XMDsoat1s49BJzKrAW FKRXkGZa/RLG8I3+kC9sKE/UZVIlaywGzaHpirJ9xhhhdCcLpr36bMSs3+VtyCjC424P GDAHjNh/nCC2DE0W0EOE8IG2VvagX13uTOJ9Xbf8KPEG/okdpSC9b8BOStw2601IzaKl EwwQ== X-Gm-Message-State: AOAM532A9GcVq2xW8nbYGYCHnAeD2aYCo4/qEY/2eejK+Cy+Q17B+793 rjA4UHIRZi0gZQpOVkqiV0hGI1ie5RaLAg== X-Received: by 2002:a05:600c:4f52:b0:394:61af:a168 with SMTP id m18-20020a05600c4f5200b0039461afa168mr5277158wmq.114.1652981828542; Thu, 19 May 2022 10:37:08 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id e2-20020adfa742000000b0020c5253d8f2sm180183wrd.62.2022.05.19.10.37.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 May 2022 10:37:08 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 18/22] hw/arm/virt: Drop #size-cells and #address-cells from gpio-keys dtb node Date: Thu, 19 May 2022 18:36:47 +0100 Message-Id: <20220519173651.399295-19-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220519173651.399295-1-peter.maydell@linaro.org> References: <20220519173651.399295-1-peter.maydell@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x330.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The virt board generates a gpio-keys node in the dtb, but it incorrectly gives this node #size-cells and #address-cells properties. If you dump the dtb with 'machine dumpdtb=file.dtb' and run it through dtc, dtc will warn about this: Warning (avoid_unnecessary_addr_size): /gpio-keys: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property Remove the bogus properties. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Message-id: 20220513131316.4081539-3-peter.maydell@linaro.org --- hw/arm/virt.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 587e885a98c..097238faa7a 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -925,8 +925,6 @@ static void create_gpio_keys(char *fdt, DeviceState *pl061_dev, qemu_fdt_add_subnode(fdt, "/gpio-keys"); qemu_fdt_setprop_string(fdt, "/gpio-keys", "compatible", "gpio-keys"); - qemu_fdt_setprop_cell(fdt, "/gpio-keys", "#size-cells", 0); - qemu_fdt_setprop_cell(fdt, "/gpio-keys", "#address-cells", 1); qemu_fdt_add_subnode(fdt, "/gpio-keys/poweroff"); qemu_fdt_setprop_string(fdt, "/gpio-keys/poweroff",