From patchwork Tue Jun 21 20:46:36 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 583620 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:5036:0:0:0:0 with SMTP id e22csp2043811mab; Tue, 21 Jun 2022 13:52:55 -0700 (PDT) X-Google-Smtp-Source: AGRyM1twnOZS607IWk1XOQ66zs32PS7FBwwdVAONA3udIQnEEmlNgxOT5G6AzgtrgtCKqFwe4wcR X-Received: by 2002:a05:620a:4409:b0:6a7:8480:a89d with SMTP id v9-20020a05620a440900b006a78480a89dmr21159911qkp.9.1655844775248; Tue, 21 Jun 2022 13:52:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655844775; cv=none; d=google.com; s=arc-20160816; b=q/8y7zeyOqAkYkoqnRmE/aZrz7qltw9TXHgYwtnrp+JIHxqScLKDgTPNvFPvVEEgB0 pU+Qi/LFZmSdfbzzd+rSSKKkItEJNHE8X91DUU0tn+o6bxusAMgJ0Uid9JyFimtSEmH+ uOWOJGzvZjXhn4OKy+NuVLf3N7BgjH6j4UmeJHjz8gPOuHl8zdbaXauAsJ0B6nWAWRIH v68hH8lFpK4BpWd/lnm3yOuTCO5SyDYbaaWlZPC3ecWcuXQ6S+KDRcikQN8XHuewUMEu w8fHlO1n0U0iADHaNJk09AcDLjz96ki9UK/yf6VoFxzxrAua1qvAZDVlKO5pz36FJpfn /PMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=lmSLzTIbm+WJzToIYu7L7rIll0Ev3qx7GQceaN1q5e0=; b=LF+361rWiOyvQ2ilS1bhZOx0GxzHPEjaHp/l4g6h3VoFDot8mBijmXl2cwvgRzb6bg F3JrS2yG+CESTK/L3Dmi2Z17JNfvjQk2YBzB1YEM9gF8dlYKd8VXBqxZ3infl9p2jqqG Ba6xdrGx+8n2J9ZDrpNhWXpzHiE5DTSGmbT7X58yezmKo1QqFgmOYzH1w5q1smXYvN5l H+F3BXi1YY1mn9LiwCH70HrBgz+/cIp3xkSADP0m1VBPQ5AZF/oBPGzkjJGT7wiwux9V YJZmpUoQ1gsde6Vg0ab3sB/UxjiCBIgjDViHhNCMz4CzAQqFQ7/zng9HHgDijYX10hlF T5Nw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ljeYoYnr; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id k2-20020a0cd682000000b0046b8c458607si8476608qvi.354.2022.06.21.13.52.55 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 21 Jun 2022 13:52:55 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ljeYoYnr; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:56148 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o3krm-0004DB-Ry for patch@linaro.org; Tue, 21 Jun 2022 16:52:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54044) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o3kly-0006bz-Vc for qemu-devel@nongnu.org; Tue, 21 Jun 2022 16:46:57 -0400 Received: from mail-pf1-x42a.google.com ([2607:f8b0:4864:20::42a]:34645) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o3klv-00015F-Mr for qemu-devel@nongnu.org; Tue, 21 Jun 2022 16:46:54 -0400 Received: by mail-pf1-x42a.google.com with SMTP id t21so7901455pfq.1 for ; Tue, 21 Jun 2022 13:46:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lmSLzTIbm+WJzToIYu7L7rIll0Ev3qx7GQceaN1q5e0=; b=ljeYoYnrjZKh9qVTzpI0plB0wMr5HaLuUw2dr+DaPGQ/X/vj89jXkWojVI/Ultcdfk umSmn4pHOyPSwY/fknaks2giMHEijfv169uJ5JVcohFlagoPshREAAOeZ7G2sMeT3LGX dK8kXuPCebebIZWa4m9eSy4S5YIZfS1KKLWGR3Cqa2DsfdrBYCMQg/Yx1I5wBCKzyQhi nhe47LJycLzR2uv4U8ZWUqIogzIQbYIO7Cc6NoJPozIBV1lHqpMoKIXDogitYmSGy8ym y5gnjq3LmVAPAgO4wVhv/haF11THElTMlDhXjla9eFETovruIfEdqvGw+EqSuAjcBJCu ++cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lmSLzTIbm+WJzToIYu7L7rIll0Ev3qx7GQceaN1q5e0=; b=3igRJchG0QGkbuZML4vlzH6M0kqF1oc+1u5SUlJwEhtwy6N+qHfQ4STe3aONsJSxAS CcdLVF09WPNMOQLbE5SOgGn4WUSy6Enmsd591lOlLbsTBxWdQSlWe8yrmZ4ZZjcL037B TYDlVnt3AJ3v+Tl6GqFKRKzD0cgRo4A4RWcek8iD60vLiBS4AVy3YE9Gp0qIlOs2COe+ kiZglj2o5gd6nWsM6WQ7pFo0Vwv8QERZC8WevCS0gD/+XUCbZTfmUWWseh0Br+bsb/yJ p7Cx+Z4jb5haKNDqvjnUX3TY1Idx0P4noMoTJ2UHcjsGfr/nn6a1znWgJpp8xlKhto0k 6lQQ== X-Gm-Message-State: AJIora8gC/7KBTrXwJIsXZ7sc/lyU6E+s9veuGQT105DZlEHNSJzWaJW 0msUrd3KfFC7oXPUXhYPbhgphe1pGl19JA== X-Received: by 2002:a05:6a00:b81:b0:51c:3bfe:7d89 with SMTP id g1-20020a056a000b8100b0051c3bfe7d89mr31878592pfj.31.1655844406342; Tue, 21 Jun 2022 13:46:46 -0700 (PDT) Received: from stoup.. ([2602:47:d49e:3c01:8adc:a144:6ec2:4d71]) by smtp.gmail.com with ESMTPSA id p66-20020a625b45000000b005252defb016sm3649674pfb.122.2022.06.21.13.46.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jun 2022 13:46:45 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: Bin Meng , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PULL 2/9] target/avr: Drop avr_cpu_memory_rw_debug() Date: Tue, 21 Jun 2022 13:46:36 -0700 Message-Id: <20220621204643.371397-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220621204643.371397-1-richard.henderson@linaro.org> References: <20220621204643.371397-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::42a; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Bin Meng CPUClass::memory_rw_debug() holds a callback for GDB memory access. If not provided, cpu_memory_rw_debug() is used by the GDB stub. Drop avr_cpu_memory_rw_debug() which does nothing special. Signed-off-by: Bin Meng Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20220322095004.70682-1-bmeng.cn@gmail.com> Signed-off-by: Richard Henderson --- target/avr/cpu.h | 2 -- target/avr/cpu.c | 1 - target/avr/helper.c | 6 ------ 3 files changed, 9 deletions(-) diff --git a/target/avr/cpu.h b/target/avr/cpu.h index d304f33301..96419c0c2b 100644 --- a/target/avr/cpu.h +++ b/target/avr/cpu.h @@ -184,8 +184,6 @@ void avr_cpu_tcg_init(void); void avr_cpu_list(void); int cpu_avr_exec(CPUState *cpu); -int avr_cpu_memory_rw_debug(CPUState *cs, vaddr address, uint8_t *buf, - int len, bool is_write); enum { TB_FLAGS_FULL_ACCESS = 1, diff --git a/target/avr/cpu.c b/target/avr/cpu.c index 5d70e34dd5..05b992ff73 100644 --- a/target/avr/cpu.c +++ b/target/avr/cpu.c @@ -214,7 +214,6 @@ static void avr_cpu_class_init(ObjectClass *oc, void *data) cc->has_work = avr_cpu_has_work; cc->dump_state = avr_cpu_dump_state; cc->set_pc = avr_cpu_set_pc; - cc->memory_rw_debug = avr_cpu_memory_rw_debug; dc->vmsd = &vms_avr_cpu; cc->sysemu_ops = &avr_sysemu_ops; cc->disas_set_info = avr_cpu_disas_set_info; diff --git a/target/avr/helper.c b/target/avr/helper.c index c27f702901..db76452f9a 100644 --- a/target/avr/helper.c +++ b/target/avr/helper.c @@ -93,12 +93,6 @@ void avr_cpu_do_interrupt(CPUState *cs) cs->exception_index = -1; } -int avr_cpu_memory_rw_debug(CPUState *cs, vaddr addr, uint8_t *buf, - int len, bool is_write) -{ - return cpu_memory_rw_debug(cs, addr, buf, len, is_write); -} - hwaddr avr_cpu_get_phys_page_debug(CPUState *cs, vaddr addr) { return addr; /* I assume 1:1 address correspondence */