From patchwork Tue Jun 28 04:53:22 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 585513 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:5036:0:0:0:0 with SMTP id e22csp461905mab; Mon, 27 Jun 2022 23:09:43 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uj18a72zAnrOKW1zWCAAnCFY+5l/n0v4WnwcUw4KCooDRcy360xQ4A5mcfsmLu5ZHleFmP X-Received: by 2002:a05:6214:3002:b0:470:7273:bee5 with SMTP id ke2-20020a056214300200b004707273bee5mr2348957qvb.98.1656396583591; Mon, 27 Jun 2022 23:09:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656396583; cv=none; d=google.com; s=arc-20160816; b=hwTVbOXEAzVa0H/+LkzRAza+XhwFXUIz78vMZGonnLnk1fcZyuIBebRM8tHyJD0K08 /8foxAkSHZ2oxzTZF+UCS6H/7UDmGWdo/qEpz4cTZ/RcLvRJQmjV0dbSvItCxTxyGzmh +Kx9q4lsffH3LNOwSf7t53hIAHerJivVuNM8I9BpRyf60ZiRDZyHZ4JwaC6U7DZ/ILYJ xHABjoUcIgt74yjnyC8kkESAOBju/D4RXgXeUlO78PSSzITXPrCFxEL3rIqiDwqVOMqO nQa4+fHPFs6HOYsJ5WYwspZJ99/AEqIYoInNNwnVjtZcTwieZixZiR+MF+29Jk5pfw08 lqxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=h8LQotJB86tKW7baXHd45kRYb/tuL0ssQ0shlDYqkXc=; b=e9u98conTMOYGRZK/szmxUz5jt0OaKlm2uaeW1H1s4pDkkMiTmnW+tiGOWAXWOjYyj ckKHK7raJwXxTeKKyfvaCcXvCtxcJtOZOEHqtyNFJebNgM9bsCbwt449AaHXSAbukUBM cEbJMxrh64nXOrBpyIJJp9TxF8nhMdEQHWRRW6edGrV+rF0gjg3q/Fqz7GXFaUtbblIM HCq6OgyYSSu9gRfHT9ByNoFbb35PYve0cNbZ6vzw2WSCAeZO/nOnzdL8m++vo2z+cz9F gb1APMK9Gkl5ovFQhNeZ/DwotpzGqHl6JBVAMVEjlJaTj3lRCxFJOsyUYpx0LEan2BC+ FRgw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Yb0ZDcXD; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id m19-20020a05620a291300b006a72f26bb07si5149727qkp.429.2022.06.27.23.09.43 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 27 Jun 2022 23:09:43 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Yb0ZDcXD; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:57500 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o64Pv-0001xv-4z for patch@linaro.org; Tue, 28 Jun 2022 02:09:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43316) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o63FY-0003FC-Jc for qemu-devel@nongnu.org; Tue, 28 Jun 2022 00:54:58 -0400 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]:43737) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o63FW-0008Km-4J for qemu-devel@nongnu.org; Tue, 28 Jun 2022 00:54:55 -0400 Received: by mail-pl1-x634.google.com with SMTP id r1so10016460plo.10 for ; Mon, 27 Jun 2022 21:54:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=h8LQotJB86tKW7baXHd45kRYb/tuL0ssQ0shlDYqkXc=; b=Yb0ZDcXD0G11W8UTrUonyloyWUOMF66yZUfWAK4MBwt6rY0klsKxImqCKi1TdLDK7R Ht2AuDaMrCFXb0XFQNh0Gumawx4beJRx5+C8gVAUkBGIIlEtVcitZ9bfMNYQ8vNVguQI 9VMZuVDOXwralfeXE4Ehp3oVzxt2K80Lk9FQJcoUHIEm67BGm24oCoYXrxGVlJKMCBnb ZIcpypFEI7z0F7/FznaCvALM9DslKuev+qXPP6AGGCQ0XUnXnfizrpOdOXhQqmraVEdB te+IiKYgg+6eH+aMRrcVtyZQWdRR6RNNDSEZDSzCpjV6eQ5ZU5k+66bNEFWB62zCPs5v thIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=h8LQotJB86tKW7baXHd45kRYb/tuL0ssQ0shlDYqkXc=; b=oT0t1pQxSKVnFkUmhBH9DPpzgjymoA9RT4KTpidmvDkOZNPORqzqRokDv3RwCZhbHU EwrMLYzOOwN9ysPKHtfMr4qU2qZ8f3phDCeTCXjeYEPM1fggQJjR7ISLaoGEV6CkKkvF v20LEX3DxKRrvkV/KZZDJN6OAYQnqLgykdNzwrJcZ1emtrpjjyvt4mxgLGYigI5H0Xrw ISTTSVdGciL+3Hm7i9KjXncqZcJCVHuahW6xH3VsJDHfCp+Gwf7mntm86DTaBVJiT5hN P2sNv1dkOuLKMpwf5rMAgZg9UisVKYsWzwt4dWWm7Lw5e+6zyJfDDUsk1sJWjzf93qYW PWYg== X-Gm-Message-State: AJIora9qnHZeE+ne8nDRz+gx/RnYS0UoSME/dAx5q7KExkqET1qbaaVx AKlyoeX0o1AphtJ9sju6IuMIIIRYvUSuvA== X-Received: by 2002:a17:90a:dc81:b0:1ec:afea:3b17 with SMTP id j1-20020a17090adc8100b001ecafea3b17mr20353877pjv.203.1656392093386; Mon, 27 Jun 2022 21:54:53 -0700 (PDT) Received: from stoup.. ([122.255.60.245]) by smtp.gmail.com with ESMTPSA id w8-20020a1709026f0800b00168c523032fsm8073735plk.269.2022.06.27.21.54.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jun 2022 21:54:53 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: Luc Michel Subject: [PULL 19/60] gdbstub: Convert GDB error numbers to host error numbers Date: Tue, 28 Jun 2022 10:23:22 +0530 Message-Id: <20220628045403.508716-20-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220628045403.508716-1-richard.henderson@linaro.org> References: <20220628045403.508716-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::634; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x634.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Provide the callback with consistent state -- always use host error numbers. The individual callback can then decide if the errno requires conversion for the guest. Reviewed-by: Luc Michel Signed-off-by: Richard Henderson --- gdbstub.c | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) diff --git a/gdbstub.c b/gdbstub.c index 88a34c8f52..f3a4664453 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1886,6 +1886,37 @@ static void handle_file_io(GArray *params, void *user_ctx) } else { err = 0; } + + /* Convert GDB error numbers back to host error numbers. */ +#define E(X) case GDB_E##X: err = E##X; break + switch (err) { + case 0: + break; + E(PERM); + E(NOENT); + E(INTR); + E(BADF); + E(ACCES); + E(FAULT); + E(BUSY); + E(EXIST); + E(NODEV); + E(NOTDIR); + E(ISDIR); + E(INVAL); + E(NFILE); + E(MFILE); + E(FBIG); + E(NOSPC); + E(SPIPE); + E(ROFS); + E(NAMETOOLONG); + default: + err = EINVAL; + break; + } +#undef E + gdbserver_state.current_syscall_cb(gdbserver_state.c_cpu, ret, err); gdbserver_state.current_syscall_cb = NULL; }