From patchwork Mon Jul 11 13:57:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 589350 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:bb16:0:0:0:0 with SMTP id jd22csp3275845mab; Mon, 11 Jul 2022 07:04:55 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vZKe+nfZ454uIPA0p4wNpQ6YsVpP4+9fFZ5M35ffFSnMi8pNZIYUngcRzJ8MqNpWuqUzeP X-Received: by 2002:a05:6214:e69:b0:473:691d:e4cc with SMTP id jz9-20020a0562140e6900b00473691de4ccmr4795062qvb.58.1657548295105; Mon, 11 Jul 2022 07:04:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657548295; cv=none; d=google.com; s=arc-20160816; b=zQO/b1eV8YpQePDGdKC50L5FRGbUYeA2F/0s/DStgD7v411Foy0pCA65MIKZDHV7+N jaPYK17pDf9Hn3V4N+zJ56m3fRyOBSVyHok7lAE5o2u8r0zUbPf699CEBO2zcAtI62T8 f1b92yVg3Z1tAW/nM6CDFODinkzp/+55TGa4abAwkSbykGJysKT7XlTaqebKgdLXTyS+ Ip4h8iEv1gx3/V+fXEhZEfYY1u8B9rFBGtjii6wWorGfiNFZeKfBGQaquTKvLNbyvFAt szu+eLu7zJg3fM708857D3V5Re0DrCvOuqkd8vwlvp2J+wERELdGBNQZnmKR6V2bUR4a L4Fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=fI18+z5edTaeRfrH4Mp6ek59dUDomNqM3YPKq/pXVYg=; b=B/rxQMqIqKQB5rm9sfppY6NyPstTSTimBX/idx/CWCd9+l13+l4tUP/IXNINc7BxaZ 4N6CYpX4AFROh0sKc//GpPUjTx8GJ0bnBcXHlhDC1jkbm+bHpH9hIDRcph8TL+DtjGTJ oLaUD1ZT4dQx3dVk3O4ymQOTMAxTqb2j4GGLf7VdOQddMRIiQ1tEFqOqodeR3rOyRiXd yENPclJGkxXfTVoAcN14Zr1xI77wHx8qPsExDePLpU+lR0pEilqUYl/BkFL/QZTzRMxf PIgnAz8AE/N33x1Z4U3cEq9eE6JPnefHC8jmTDggkcB9Hwv8mIRGJ58Z3SW4CVyOkNqz othQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=N7nKfoda; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id s9-20020a05620a0bc900b006af33deed49si4909369qki.38.2022.07.11.07.04.55 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 11 Jul 2022 07:04:55 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=N7nKfoda; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:48686 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oAu1u-0004Ip-Je for patch@linaro.org; Mon, 11 Jul 2022 10:04:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42428) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oAtvF-0006No-8o for qemu-devel@nongnu.org; Mon, 11 Jul 2022 09:58:01 -0400 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]:42549) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oAtvC-0002nQ-KV for qemu-devel@nongnu.org; Mon, 11 Jul 2022 09:58:01 -0400 Received: by mail-wr1-x434.google.com with SMTP id bu1so5946594wrb.9 for ; Mon, 11 Jul 2022 06:57:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=fI18+z5edTaeRfrH4Mp6ek59dUDomNqM3YPKq/pXVYg=; b=N7nKfodaaa/h8ATKhvtMvX/S8Y45rlcFw8ZxMjRMPxlhszit/5PvFWcQ+YpFGdDjT6 lmuhjeRvaUhPcrw4uPp6qoRQ73W5eY4WXUaOEgE8FV3kmfH68Lj/ZU0Ce1irQvUINiXZ 6oGtI9NAvxJKEg0C2LDbPt/1T1FeU7/0J1G/vkshgjdWGwqPJgPwMNF429fvKDZiw2bp HRGe7anA1CpYbFPtmjpcdn5RJw2Z8l9PBGsfM6C7PrNxMpQzdtUdxesH/pFVExhIPdxq eRhNT5de9BDqYgAK/Tx+vfHmgZpD+7jgQrcFGaomIXP3kHbsoQRy8kKJZslvglty22qQ OSNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fI18+z5edTaeRfrH4Mp6ek59dUDomNqM3YPKq/pXVYg=; b=vpTV8wE3SMZUdUIEXAKznUo+mr1FaeBKBDdqqVdslw0TKMT0TwUoaAd0Z1OH5zwb1j Fv1wuNI+/py9nntzckB18Jwpl41jxBB0+RRv5nRj4eHqAgikK9GMGmdK3ROyN6uH/fkL 9zDSQKv8eJSJZsJ6HEvaVwA9FMxyJOXVtD29IjwkCnxJHD+t8CJVHy0pud9K5wxnJAtP vlm7gofUQFbwJy83w24ihpKN6xPetEjAKqwk9J+uTYVRv+fVrlPGX+pIh3U7tkzRFJDP yZZyqv6L87EhksjCsrg01AEBdjAZTHKvOAUCEUJUu8zSoOZ8tm4NukWEO/Wym6428mI+ TF0w== X-Gm-Message-State: AJIora/c0lEFjByoRHsOD8qpmQ2X0Q/ncIqbE1YdLOpH01nMmH3hXCUK AClO7OStkeqR+pFfDDEEGD2ZIZSEFjCILg== X-Received: by 2002:a5d:5a9d:0:b0:21b:8247:7ec4 with SMTP id bp29-20020a5d5a9d000000b0021b82477ec4mr16837271wrb.561.1657547876105; Mon, 11 Jul 2022 06:57:56 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id q123-20020a1c4381000000b00397402ae674sm7595596wma.11.2022.07.11.06.57.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jul 2022 06:57:55 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 04/45] target/arm: Mark ADR as non-streaming Date: Mon, 11 Jul 2022 14:57:09 +0100 Message-Id: <20220711135750.765803-5-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220711135750.765803-1-peter.maydell@linaro.org> References: <20220711135750.765803-1-peter.maydell@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Richard Henderson Mark ADR as a non-streaming instruction, which should trap if full a64 support is not enabled in streaming mode. Removing entries from sme-fa64.decode is an easy way to see what remains to be done. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20220708151540.18136-5-richard.henderson@linaro.org Signed-off-by: Peter Maydell --- target/arm/translate.h | 7 +++++++ target/arm/sme-fa64.decode | 1 - target/arm/translate-sve.c | 8 ++++---- 3 files changed, 11 insertions(+), 5 deletions(-) diff --git a/target/arm/translate.h b/target/arm/translate.h index cbc907c7516..e2e619dab25 100644 --- a/target/arm/translate.h +++ b/target/arm/translate.h @@ -566,4 +566,11 @@ uint64_t asimd_imm_const(uint32_t imm, int cmode, int op); static bool trans_##NAME(DisasContext *s, arg_##NAME *a) \ { return dc_isar_feature(FEAT, s) && FUNC(s, __VA_ARGS__); } +#define TRANS_FEAT_NONSTREAMING(NAME, FEAT, FUNC, ...) \ + static bool trans_##NAME(DisasContext *s, arg_##NAME *a) \ + { \ + s->is_nonstreaming = true; \ + return dc_isar_feature(FEAT, s) && FUNC(s, __VA_ARGS__); \ + } + #endif /* TARGET_ARM_TRANSLATE_H */ diff --git a/target/arm/sme-fa64.decode b/target/arm/sme-fa64.decode index 3d90837fc7c..73c71abc462 100644 --- a/target/arm/sme-fa64.decode +++ b/target/arm/sme-fa64.decode @@ -59,7 +59,6 @@ FAIL 0001 1110 0111 1110 0000 00-- ---- ---- # FJCVTZS # --11 1100 --1- ---- ---- ---- ---- --10 # Load/store FP register (register offset) # --11 1101 ---- ---- ---- ---- ---- ---- # Load/store FP register (scaled imm) -FAIL 0000 0100 --1- ---- 1010 ---- ---- ---- # ADR FAIL 0000 0100 --1- ---- 1011 -0-- ---- ---- # FTSSEL, FEXPA FAIL 0000 0101 --10 0001 100- ---- ---- ---- # COMPACT FAIL 0010 0101 --01 100- 1111 000- ---0 ---- # RDFFR, RDFFRS diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c index 62b5f3040c7..5d1db0d3ff9 100644 --- a/target/arm/translate-sve.c +++ b/target/arm/translate-sve.c @@ -1320,10 +1320,10 @@ static bool do_adr(DisasContext *s, arg_rrri *a, gen_helper_gvec_3 *fn) return gen_gvec_ool_zzz(s, fn, a->rd, a->rn, a->rm, a->imm); } -TRANS_FEAT(ADR_p32, aa64_sve, do_adr, a, gen_helper_sve_adr_p32) -TRANS_FEAT(ADR_p64, aa64_sve, do_adr, a, gen_helper_sve_adr_p64) -TRANS_FEAT(ADR_s32, aa64_sve, do_adr, a, gen_helper_sve_adr_s32) -TRANS_FEAT(ADR_u32, aa64_sve, do_adr, a, gen_helper_sve_adr_u32) +TRANS_FEAT_NONSTREAMING(ADR_p32, aa64_sve, do_adr, a, gen_helper_sve_adr_p32) +TRANS_FEAT_NONSTREAMING(ADR_p64, aa64_sve, do_adr, a, gen_helper_sve_adr_p64) +TRANS_FEAT_NONSTREAMING(ADR_s32, aa64_sve, do_adr, a, gen_helper_sve_adr_s32) +TRANS_FEAT_NONSTREAMING(ADR_u32, aa64_sve, do_adr, a, gen_helper_sve_adr_u32) /* *** SVE Integer Misc - Unpredicated Group