From patchwork Wed Jul 20 15:26:27 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 591869 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:5817:0:0:0:0 with SMTP id j23csp5059956max; Wed, 20 Jul 2022 08:28:41 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vdzYAxe59F1KH3ZXdGejCx6WoQZcBwyiUGJG8jfrmDsIeFgkdtB9WC3C9KL9vtYjCidj3+ X-Received: by 2002:a05:6214:500b:b0:473:561f:1295 with SMTP id jo11-20020a056214500b00b00473561f1295mr30178217qvb.23.1658330921839; Wed, 20 Jul 2022 08:28:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658330921; cv=none; d=google.com; s=arc-20160816; b=QqjvUugAhWuhpvSzxRnDgl9qZ30aHxvu+/KjmKv1EDpza3hQCiPAW9JJzZD+R2AowB 4kUgWSYOISsKzvJYEKGnHHGYMijoXboMU/qz1WPKQRmw4v/3geflB1HCv6eQrtPysFOj 3Psn3JpPYn3Z2Udl+zxzwmoEElWCmrV5nhfQF935865YFasAjJ70oxbBAEUu/P77IJ6F VHV4rrtKRjzv01wv7xLN93G1a1qBj3imziY4S05u1kXZFf2Xw+OH7Rzw76LXwJbkL95J Z8H/igxxdzCQXsGOkPfrxThQNmv0faVR1NWgdSqK0YKs/UimjzS/Z/aW5K5CMlwtE/TW wTTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=YO5oI71pbWpf1Cp3bbqdXyUqFH5RPgviSgLa1og9xxU=; b=KX5iNZSh9rgPpqTgyzDKCNhHcH8RYXTuNWh6xwxhw10ugpNfnDj38GSrx2r1hZhaNY DskDKDDrQq7NjtXOjvAnheXtAilJPvQdrZ33AICO8Cq7q/1RTGFJA+Cuqcs6qJhRs7dF ZXbeVrqad3b/zN7QoYgTOzPAlDo+PQ4kSa26++A6w2+OpQuUyn2I5050VDQEihl4CMiW RqddNstGRy0tJ8HKRaQtwiTjhPWzHo2CM6vgk9FFMgZXfONXuDFOjDqG2Hc2Jsyw8w29 Xl7SFfqR7afOg48+UWA6V+bZZtKupU0MbbBQtqeWQy+TNqdb9ayuEq1VWk2SHsY6KriL wg4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=YMi3r6Mg; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 202-20020a3705d3000000b006b55d58fb27si8271621qkf.153.2022.07.20.08.28.41 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Jul 2022 08:28:41 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=YMi3r6Mg; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:58978 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oEBcv-0002Ox-GN for patch@linaro.org; Wed, 20 Jul 2022 11:28:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36794) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oEBav-0002MT-QO for qemu-devel@nongnu.org; Wed, 20 Jul 2022 11:26:37 -0400 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]:45829) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oEBau-0005Bm-8i for qemu-devel@nongnu.org; Wed, 20 Jul 2022 11:26:37 -0400 Received: by mail-wr1-x434.google.com with SMTP id a5so26589028wrx.12 for ; Wed, 20 Jul 2022 08:26:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YO5oI71pbWpf1Cp3bbqdXyUqFH5RPgviSgLa1og9xxU=; b=YMi3r6Mgx9Su24p5f+ikpi0yRxA8+WW1IaOAUxP5RBZ3riNLssWNheTRcRjq5EcCZO Py5oYh3HOzKPcJ/2z473X5OCTeUiGAxAN7R9jTz01onvDaA0eOuf031LH1piiU1bfnEY LvdtG4ijYX7wqQ0jAP/lZFq90p0BN8EIB5Zll8Fwz2bpiZQ3/fqSeoarAbB0B4t1i3c+ S/z6IKqJG5oafl7mfCBHx7+MIO4FfrolZriMQeK+Nw++q9JKAxgFcagCjpzdnRWjqTLB tiBpEWLzZdJYu8RMNL2ybI9kW4d9dwO8hEdhHEIoljz5f338j8Z0hwr84vFHyoV66WU8 8EVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YO5oI71pbWpf1Cp3bbqdXyUqFH5RPgviSgLa1og9xxU=; b=600aJItoqzvBdGDVW585KH5RzDoDxZEOevX7OsTCNdexMQVWT1RPJwJmY32t9buAWh zhRzUY4CmOz7qbt0EcNDknLXjT6PlhsA53p8MUQNxCaJek2JggAreBo3kyl3yrDXZUPL kf/uK4nbfVZnMSZvjqGPT7LuCrcH5PM1SdPZ5cX+cCy9OfgyTj91CwUlv0VYFNu1FFsP YYwQnGyKI7tmj+pceX96RXN3jsS4JzdtYqgj1p0hATpZn1o8diP9fbogLnoIx+zmDDxc MQ2y6ZQRyY39AIUFF8PcbjQzeMYT3H/9rYNuMmtHwgf1uphByi6G37i0c5QzbepyUuD/ mA7A== X-Gm-Message-State: AJIora8aROTCfaj6vqw6TDCmiTiP+dHo6YFnqGtEWZye6pVYcVPUXgRh gvHXmXh1UYC3K/0gbqNbw/LVoAd96vXMWQ== X-Received: by 2002:adf:f108:0:b0:21d:7f0f:22db with SMTP id r8-20020adff108000000b0021d7f0f22dbmr30195610wro.187.1658330794841; Wed, 20 Jul 2022 08:26:34 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id r10-20020a056000014a00b0021d68a504cbsm16395987wrx.94.2022.07.20.08.26.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Jul 2022 08:26:34 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Cc: Paolo Bonzini , "Dr. David Alan Gilbert" , Thomas Huth , Richard Henderson Subject: [PATCH 1/5] configure: Add missing POSIX-required space Date: Wed, 20 Jul 2022 16:26:27 +0100 Message-Id: <20220720152631.450903-2-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220720152631.450903-1-peter.maydell@linaro.org> References: <20220720152631.450903-1-peter.maydell@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" In commit 7d7dbf9dc15be6e1 we added a line to the configure script which is not valid POSIX shell syntax, because it is missing a space after a '!' character. shellcheck diagnoses this: if !(GIT="$git" "$source_path/scripts/git-submodule.sh" "$git_submodules_action" "$git_submodules"); then ^-- SC1035: You are missing a required space after the !. and the OpenBSD shell will not correctly handle this without the space. Fixes: 7d7dbf9dc15be6e1 ("configure: replace --enable/disable-git-update with --with-git-submodules") Signed-off-by: Peter Maydell Reviewed-by: Thomas Huth Tested-by: Dr. David Alan Gilbert --- David Gilbert noted the OpenBSD issue on IRC -- I have not tested this fix there myself. --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 35e0b281985..dec6f030346 100755 --- a/configure +++ b/configure @@ -2425,7 +2425,7 @@ else cxx= fi -if !(GIT="$git" "$source_path/scripts/git-submodule.sh" "$git_submodules_action" "$git_submodules"); then +if ! (GIT="$git" "$source_path/scripts/git-submodule.sh" "$git_submodules_action" "$git_submodules"); then exit 1 fi