From patchwork Tue Jul 26 15:20:07 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 593456 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:b811:0:0:0:0 with SMTP id fc17csp3649464mab; Tue, 26 Jul 2022 08:31:59 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vIWVLG0wsl978ICIsHs8lx3u78Js+PXWcnxU0mB7GMiofc8PD3A2OAB0RVpnjMvMcQjhlQ X-Received: by 2002:a05:620a:4714:b0:6b5:f7b6:7d67 with SMTP id bs20-20020a05620a471400b006b5f7b67d67mr13119970qkb.469.1658849519254; Tue, 26 Jul 2022 08:31:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658849519; cv=none; d=google.com; s=arc-20160816; b=GVms/zlNz1SfoGoQUw1REeIndiuRDRIKuLa1OA5FiZ+2o8qlNTa0UXB0mvj2+y0KNc 4SO7dvQ2GzJHKlXSUxel/SJoHNvNeMaux8SNh9JwKeKeXJMK72Ke3dzev082BL2qdawi T5g+YNiP5UyR8SWOejmQBiHpAO7TWWcY6FqRBaOB8M8MAinT+lWymum2lP1gY1R99UIC rhoK5b5mpBeHAm6C2JNxNQpU1Mcl/0mD0EHKiKPHwgP+cOZmBGrMQhTRV2EBA7CGbsUJ MwktXv50RBoiOTyorFqJ4zjEtBMsKyq+rWjVMpIiw8PyEo+q9OvZMidKp+hqsQFQobSP 1yJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=N6+ztaKWxKiaj7O7Q3eQxFwJtwwHvO1y0ZcflvRK1lM=; b=ouLOymxLtheeWTyB4Lm6ta19lPxqOHXuzgWrO1+FMm1gD+iy0rtIgFaZpEFXfxnsZc 4Sp2w+92RsAN8vJG9OS1T81FH//pGVoxVrI5tTo6v0ctH3ftBSjGQuXdmfEy0R9KD3N3 5yQtvE5tlZ3bGmZK4beiqPTUQ8XjV6bLUj27vQ9T4H9NJ6eR5WEuNcSW5B27BUtsoPzL 1yQTr9Ah5Nr7yi96S6xNC4Q90uXRCzSi6U4x7ddCbgmoNhmSuZEKTLZbnJX4wRk4WSMf sWiS4cy3fdqyL2VXL9YtGwkNGbXngWS7w2sMk0AbB4UPp1JvIiExwnCouav6b91Wpjne Qsag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wNrUUwAs; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id a9-20020a0562140c2900b00470aaf52e01si8319872qvd.113.2022.07.26.08.31.59 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 26 Jul 2022 08:31:59 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wNrUUwAs; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:56904 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oGMXO-0004di-Pm for patch@linaro.org; Tue, 26 Jul 2022 11:31:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51968) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGMMG-0006RZ-L2 for qemu-devel@nongnu.org; Tue, 26 Jul 2022 11:20:28 -0400 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]:33603) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oGMMA-00062z-MI for qemu-devel@nongnu.org; Tue, 26 Jul 2022 11:20:28 -0400 Received: by mail-wr1-x42d.google.com with SMTP id h9so20667852wrm.0 for ; Tue, 26 Jul 2022 08:20:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=N6+ztaKWxKiaj7O7Q3eQxFwJtwwHvO1y0ZcflvRK1lM=; b=wNrUUwAse46VXkuSJN8mYTkeBG1xIHOQRiFbJagq9lof6c6db7UFjYGKpqdsiWq+lx jkq3rOW4M4jp5byJHbVouS1dbsqNO0eO+l39gVFaJ+Lr2F6b6whf5bblw2J0keFftOY7 L3EAdnxiK1H6aKRcCSkiFAc+FYJmDRZAO8o8KnoVh3hmrYMRBuAoCMAHq2HkQQXg+7V7 xYPmCbWlrRecp0+Lr1o+F1rLoNO8cLAPXfI//vubctRs80DMyVljOsv4/w/ERtyH/A1D uteu6p5r0Io39EgKMsyqOC2QoNm+4OjZqFCTM+lJ8Z5TPPgQ3MBIMtXK8CQtDO01OFod SQ+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=N6+ztaKWxKiaj7O7Q3eQxFwJtwwHvO1y0ZcflvRK1lM=; b=NKzT3ivQ/hHsMfpHA1WdE0xRJTyyn8Yy01FV4eIWW8sipAuIeYe9U1MAX3Xik2o6SF dPpw/uD3a48/Dd9SmVEgB0jtZNpkSfSx1k0v+rVo8EtpnDyCposr81A1SeeSTeH9u5pi 33rF+/eztuC+C/YLeh2iBCPjFbuZhhWrEbvpWNregeMJls1H/LwnT34U2ouok4//A+Wc QX/LUTq78YY9hPeOu0pEP7laD1He9osR+koXpyM2A56wMIR3uBGcn45ASAezBNpiVbwG XuCEvxPbaEr2zb3x/FQdnfGz3tDr5++UnhwA2zcQqNLFaoZWSoDF8ghnfzYsRU9qfefM YAPA== X-Gm-Message-State: AJIora844a6s8J61UElFsbNUIKzSan5XTdjeSibtP6QztPz82UFCRMi0 G3Us5eN1WiPT2XcHWa8jNAMa53M5rzo2wA== X-Received: by 2002:adf:d1ef:0:b0:21d:983f:4b8e with SMTP id g15-20020adfd1ef000000b0021d983f4b8emr11595443wrd.334.1658848819277; Tue, 26 Jul 2022 08:20:19 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id n5-20020a1c2705000000b003a1980d55c4sm21932739wmn.47.2022.07.26.08.20.18 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Jul 2022 08:20:18 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 4/9] configure: Add missing POSIX-required space Date: Tue, 26 Jul 2022 16:20:07 +0100 Message-Id: <20220726152012.1631158-5-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220726152012.1631158-1-peter.maydell@linaro.org> References: <20220726152012.1631158-1-peter.maydell@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" In commit 7d7dbf9dc15be6e1 we added a line to the configure script which is not valid POSIX shell syntax, because it is missing a space after a '!' character. shellcheck diagnoses this: if !(GIT="$git" "$source_path/scripts/git-submodule.sh" "$git_submodules_action" "$git_submodules"); then ^-- SC1035: You are missing a required space after the !. and the OpenBSD shell will not correctly handle this without the space. Fixes: 7d7dbf9dc15be6e1 ("configure: replace --enable/disable-git-update with --with-git-submodules") Signed-off-by: Peter Maydell Reviewed-by: Thomas Huth Tested-by: Dr. David Alan Gilbert Message-id: 20220720152631.450903-2-peter.maydell@linaro.org --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 35e0b281985..dec6f030346 100755 --- a/configure +++ b/configure @@ -2425,7 +2425,7 @@ else cxx= fi -if !(GIT="$git" "$source_path/scripts/git-submodule.sh" "$git_submodules_action" "$git_submodules"); then +if ! (GIT="$git" "$source_path/scripts/git-submodule.sh" "$git_submodules_action" "$git_submodules"); then exit 1 fi