From patchwork Thu Oct 20 11:52:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 616751 Delivered-To: patch@linaro.org Received: by 2002:a17:906:1c0f:b0:78b:b85f:9498 with SMTP id k15csp347779ejg; Thu, 20 Oct 2022 06:50:39 -0700 (PDT) X-Google-Smtp-Source: AMsMyM54D5QCNjHqulJi0fRgeNsFWpyzBBdNq0fvES4LbQ+YgCs7r+CKLqeKfjg/FfpVVbOuEeXk X-Received: by 2002:ac8:7f11:0:b0:39c:e908:6451 with SMTP id f17-20020ac87f11000000b0039ce9086451mr11102152qtk.560.1666273839258; Thu, 20 Oct 2022 06:50:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666273839; cv=none; d=google.com; s=arc-20160816; b=ZM3aIeNwxDSST1wRTFEZlhh2B0c7fhsQEE8ybnWIx6nnZMxTDulEEyqnCF23lX0pdI HQKBTNCeqzeomtqZCsb1Kus2XEenyHSG82fXp9ZNYsEamBagezt9isNSpP4RcNIAY2l/ 2nAWe7YDcwZWzpd0cErpoOWpp92hgD7U1xDqEQzQ+6k2cc6hDNu+PUFQbFELgTDSQMND CUDSD17hWsWApXP1mwYxraf9knUyy3xJxSfaeDf2nqCuUV4eWPSMltGlpxV95roL344u gzocNTBkuQNJNukqNvl/WM0AO9/QYH2ZEzS0BYberQ8fW4D2zOJDiuBHiOzqIkkGOoBJ yMhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ffAk/uKFmYMud8oNMjB2hkT94GX/9Rmm5gafjNWj2X0=; b=DJeFl50YITpBy1J3pnDVM08hmxv9/wPdnQjWeqaQOLhLDac9gefLLdQdVq830kVkQ6 F3H9UaIYp2yBGHAjxj5ceNDmAnDBQbl9cT1JSD+OczkFqwfsJzWCBteyoKaPN1G8Oogo d527+JXPymrH6T5jsSLFWQNhNRkySMivSJwM0eSiH9hFeJb105dmxrCoIpGbg83sRouh 0aUSGP98wxDFT5B/VFxWH5+5o7bqfb7ZlFxYMNSTI4H/IBTl/yPYriPxCGSnz915cOx0 GwZm6zb7Xs2wfnHMK0t5ID8Yq30926SwYFHxnLfWmbRr/GjE14oK0CIaeFJaecUcNahp 1xvA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XcTUuWoR; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 9-20020a056214202900b004ac6db3d22dsi9418152qvf.540.2022.10.20.06.50.38 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 20 Oct 2022 06:50:39 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XcTUuWoR; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:42652 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1olVw8-0007rG-Tb for patch@linaro.org; Thu, 20 Oct 2022 09:50:26 -0400 Received: from [::1] (helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1olVoY-0001ou-3e for patch@linaro.org; Thu, 20 Oct 2022 09:42:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41492) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1olU7L-0004Wc-9Q for qemu-devel@nongnu.org; Thu, 20 Oct 2022 07:53:43 -0400 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]:33310) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1olU7J-0000zf-LS for qemu-devel@nongnu.org; Thu, 20 Oct 2022 07:53:43 -0400 Received: by mail-pl1-x62e.google.com with SMTP id 10so20130614pli.0 for ; Thu, 20 Oct 2022 04:53:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ffAk/uKFmYMud8oNMjB2hkT94GX/9Rmm5gafjNWj2X0=; b=XcTUuWoRjKZiYqX8IUPix4HtsvJwNUmEVRyyzFOv6IyA5c3G0NoZORhswqa0AO5THe iVuh83AZCPODKIcwsi7GPm/+ForunJ8YSnCNnromosLM5RcNimXDc0XtKwkUuEJd6/Yl KOe4w1bV4dWeJ1Q+SY95DxhnTanLVvA7BhgnW1DwPwV8SYfG1EvDl5k6EA44fgrctCrN oYwKKjSOw5hPuvrPEnzw2DdGeUiVw43BcsiBA2bvCmaMUE/66vLslJLJHLzJTcNRYayR 8RlyTIv9BvVM1dAtkDUIB+pOSTIyG0CzB+yqVby/Mtt9BHiNR+j5lF/G3555nOdRRtN7 m2Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ffAk/uKFmYMud8oNMjB2hkT94GX/9Rmm5gafjNWj2X0=; b=JGWSv4rslkvsjEXOMVUVwj/EfwbC9RggoAXAm36vHQ/brKdO0rt8131eexItrx5NA5 t1aciJ9zEDgX7nP42k9/k0/KqqA++fMi2zVRsIY2eyDKO5Za8V42m2vaofq1MkBiCtVY QD3tUwaDfoHxrhJgGqGODtZPkKKtVuHqrX9dTXhXTe5JejqkY18Zqp+ieMeCJMO0TrMN LD776zkmnL49xrwi6UlaeFZbkdR9AvsX39dZ9FSSBnw7XH8rzkaReb8LwCF2uEkHY+0Y Ccf83cMY/AJimWZLmCGZpkNw2HMoZtxqjsKifs0K9jXubsYRDHQujIfOCcm7ZdV1HAdz viVA== X-Gm-Message-State: ACrzQf1tzxhYydsxdf+A1xAzWt18sFKH5N4MucvczGfr+s52FGSOxwvK RlKbUblSNVldIW5QDfgIJ1X/EyhS1unt4trY X-Received: by 2002:a17:902:e88b:b0:17f:93a4:e31b with SMTP id w11-20020a170902e88b00b0017f93a4e31bmr13817380plg.51.1666266820185; Thu, 20 Oct 2022 04:53:40 -0700 (PDT) Received: from localhost.localdomain ([149.135.10.35]) by smtp.gmail.com with ESMTPSA id w206-20020a627bd7000000b0056109e15638sm13065464pfc.54.2022.10.20.04.53.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Oct 2022 04:53:39 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: Mark Cave-Ayland Subject: [PATCH 08/31] target/sparc: Avoid TCGV_{LOW,HIGH} Date: Thu, 20 Oct 2022 21:52:19 +1000 Message-Id: <20221020115242.2301066-9-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221020115242.2301066-1-richard.henderson@linaro.org> References: <20221020115242.2301066-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::62e; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Use the official extend/extract functions instead of routines that will shortly be internal to tcg. Cc: Mark Cave-Ayland Signed-off-by: Richard Henderson --- target/sparc/translate.c | 21 ++++----------------- 1 file changed, 4 insertions(+), 17 deletions(-) diff --git a/target/sparc/translate.c b/target/sparc/translate.c index 2cbbe2396a..7e9631f004 100644 --- a/target/sparc/translate.c +++ b/target/sparc/translate.c @@ -163,13 +163,6 @@ static inline void gen_update_fprs_dirty(DisasContext *dc, int rd) /* floating point registers moves */ static TCGv_i32 gen_load_fpr_F(DisasContext *dc, unsigned int src) { -#if TCG_TARGET_REG_BITS == 32 - if (src & 1) { - return TCGV_LOW(cpu_fpr[src / 2]); - } else { - return TCGV_HIGH(cpu_fpr[src / 2]); - } -#else TCGv_i32 ret = get_temp_i32(dc); if (src & 1) { tcg_gen_extrl_i64_i32(ret, cpu_fpr[src / 2]); @@ -177,22 +170,16 @@ static TCGv_i32 gen_load_fpr_F(DisasContext *dc, unsigned int src) tcg_gen_extrh_i64_i32(ret, cpu_fpr[src / 2]); } return ret; -#endif } static void gen_store_fpr_F(DisasContext *dc, unsigned int dst, TCGv_i32 v) { -#if TCG_TARGET_REG_BITS == 32 - if (dst & 1) { - tcg_gen_mov_i32(TCGV_LOW(cpu_fpr[dst / 2]), v); - } else { - tcg_gen_mov_i32(TCGV_HIGH(cpu_fpr[dst / 2]), v); - } -#else - TCGv_i64 t = (TCGv_i64)v; + TCGv_i64 t = tcg_temp_new_i64(); + + tcg_gen_extu_i32_i64(t, v); tcg_gen_deposit_i64(cpu_fpr[dst / 2], cpu_fpr[dst / 2], t, (dst & 1 ? 0 : 32), 32); -#endif + tcg_temp_free_i64(t); gen_update_fprs_dirty(dc, dst); }