From patchwork Thu Oct 27 18:36:30 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 619226 Delivered-To: patch@linaro.org Received: by 2002:a17:522:c983:b0:460:3032:e3c4 with SMTP id kr3csp515712pvb; Thu, 27 Oct 2022 12:29:11 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6rTrc7LJfoQSoTVhBJO/MIVMf8s5eIqLp8msFSgA8JCgTBVvR4+lnvZV/A/F26FP3CV+2p X-Received: by 2002:a37:9584:0:b0:6ec:55b9:b8da with SMTP id x126-20020a379584000000b006ec55b9b8damr36723243qkd.735.1666898951363; Thu, 27 Oct 2022 12:29:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666898951; cv=none; d=google.com; s=arc-20160816; b=EoDTvLmpRx3uFM5hONzGi9F2EIERRLUpkxhtl/C/5l4YtbKpaUeR4Y57Vj1USvSdgU BoxGM3nXxMW1eTbvkZRuX7VbnXq4VxBTPy8FL4s86P5HhUGB6t4UoxWH/XwgAimylMGF gaKecsceD00E7btnNZlwkkQxl9wxG1IFPcX1t5gZNB5TmqW2sraLiXpDdABp4VU2rfBQ sXMCao3NoMpKpgA0R9Y1KDjbPBn9iZJzaEcrz2gPgXJN6kyq5fyQDmwVGMDYAHhy6aIS n58pDlGUqZdGkBTIqSv2kKoeyqe9uYmVbMI07JkrQcLyQPsU3P/+vQ0wqHH3TDcUO0Fs SOyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=7Q3YCOQ/uatq/vj7coPL1TuVcy0GWDngH2i5ai2OFfY=; b=QrzUf213zWN9GWTn8kP6sCA4iAGJQf5G6WMEXscuQRnYTCPReYR6bP816skR3wJCJA W3t3DHOEb5zD+R57odln2vKREgFmSGWe3AkXtPQZDsuW0HonHoPmTBZ5QDfBP2E1kaCP P7EnjkBuPJC96y/uuoZj9zrcfrHfRkd7M9M/MAc4MfOamyhOiHPiKfDvobJKC7/ZQ7uL rb7KYul4yNeHRaG73F2NqJGBFAgZF00UJ9Wl2t+1FqKgUSiAIiWyOdRnC0YfqzHLDcZL d1UnT2uy0sPnDVx4eG01Gate7x0D0B85Wa3NbUsx8reJ7n9p39eopTb81ZIUYn4iRIAu VUzQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=I7hlB2IZ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id x9-20020a05620a14a900b006f9c38c1e4csi1291726qkj.289.2022.10.27.12.29.11 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 27 Oct 2022 12:29:11 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=I7hlB2IZ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oo82N-0008WR-7o; Thu, 27 Oct 2022 14:55:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oo823-0008VB-81 for qemu-devel@nongnu.org; Thu, 27 Oct 2022 14:55:11 -0400 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oo81m-0006A3-D8 for qemu-devel@nongnu.org; Thu, 27 Oct 2022 14:55:10 -0400 Received: by mail-wr1-x42a.google.com with SMTP id w14so3741077wru.8 for ; Thu, 27 Oct 2022 11:54:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7Q3YCOQ/uatq/vj7coPL1TuVcy0GWDngH2i5ai2OFfY=; b=I7hlB2IZcpJRTrfOvVziq6StBilTSYSLefTTGh/FztEd539tyd/hbZQ8QjPEOAdA1W +ZYQhTqjsax/w4napLZr9C10nwBTtex0Ljo7b9PgVCXHXOA/4Er2MUzFB4YM9098UwOR kfugyxQwhGc76311DwKO3SJWbFdhvcP1pLMYRqgRPLg0aZ18IDtY2xFzFzE+px9Emvp3 XobIL6UCIFgtmy7wS5VQEIaafBZeFyLOjcfb/V3Z/cAcPbxUWH5r/AeAqwwoSjliDn4o mhW/sFcmFJlEL8Gi8+5ng5MdF6YKFT19fpdikS8ygF7md4KcE7NLSNY70R1bMesDbFVo 6e2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7Q3YCOQ/uatq/vj7coPL1TuVcy0GWDngH2i5ai2OFfY=; b=siGfF7CinPm2CypMTXpKYSsgthkmlSk93JUTZpoCE0l2em3bWlQuMVWiCI6w9oJjqo T5WpIcnzZzzdphSjMj37E8yPAph8CXWrtJPyH58rBHPblbb9tjQkjBBGHzDKGM4cnMVT 1oDPYRsaSUtkW8LEMEnoKiAYFHzlmR1InnYEcn6s45NHL9XPzv0vyjcTPFzoKVoThD+Y kG0PdCyQZVE11slzhS1/D2Z13hlQEndX+on+7j6ZWfB6KQDLC4Qo72ePgG8Cz36ggVPS a50iGCDCZCVVDBmxSbYrrVCQ098sZo5TLz6hVFlcdqQsf+rPTGDVo/jbOFO5Wrj4Ggp6 zP3g== X-Gm-Message-State: ACrzQf3kGoD6z4gdVfMp4GIWDk3nixpvpjQQ3Q7Ydtfk5SuCawENDBzE 484pBl2Zo5B+lUAVA/VtxY9u5g== X-Received: by 2002:a5d:4e0d:0:b0:230:4e21:cb1e with SMTP id p13-20020a5d4e0d000000b002304e21cb1emr32325877wrt.232.1666896891804; Thu, 27 Oct 2022 11:54:51 -0700 (PDT) Received: from zen.linaroharston ([185.81.254.11]) by smtp.gmail.com with ESMTPSA id p6-20020a05600c418600b003c6b874a0dfsm2479446wmh.14.2022.10.27.11.54.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Oct 2022 11:54:51 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 8F4481FFCE; Thu, 27 Oct 2022 19:36:39 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: fam@euphon.net, berrange@redhat.com, f4bug@amsat.org, aurelien@aurel32.net, pbonzini@redhat.com, stefanha@redhat.com, crosa@redhat.com, =?utf-8?q?Alex_Benn=C3=A9e?= , David Hildenbrand , Richard Henderson , Ilya Leoshkevich , Cornelia Huck , Thomas Huth , qemu-s390x@nongnu.org (open list:S390 TCG CPUs) Subject: [PATCH v4 24/30] target/s390x: don't probe next pc for EXecuted insns Date: Thu, 27 Oct 2022 19:36:30 +0100 Message-Id: <20221027183637.2772968-25-alex.bennee@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221027183637.2772968-1-alex.bennee@linaro.org> References: <20221027183637.2772968-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Qemu-devel" Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org We have finished the TB anyway so we can shortcut the other tests by checking dc->ex_value first. Reviewed-by: David Hildenbrand Reviewed-by: Richard Henderson Acked-by: Ilya Leoshkevich Signed-off-by: Alex Bennée --- target/s390x/tcg/translate.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/s390x/tcg/translate.c b/target/s390x/tcg/translate.c index 9df7f9e693..f4122db434 100644 --- a/target/s390x/tcg/translate.c +++ b/target/s390x/tcg/translate.c @@ -6624,9 +6624,9 @@ static void s390x_tr_translate_insn(DisasContextBase *dcbase, CPUState *cs) dc->base.is_jmp = translate_one(env, dc); if (dc->base.is_jmp == DISAS_NEXT) { - if (!is_same_page(dcbase, dc->base.pc_next) || - !is_same_page(dcbase, get_next_pc(env, dc, dc->base.pc_next)) || - dc->ex_value) { + if (dc->ex_value || + !is_same_page(dcbase, dc->base.pc_next) || + !is_same_page(dcbase, get_next_pc(env, dc, dc->base.pc_next))) { dc->base.is_jmp = DISAS_TOO_MANY; } }