From patchwork Sun Oct 30 22:28:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 620042 Delivered-To: patch@linaro.org Received: by 2002:a17:522:c983:b0:460:3032:e3c4 with SMTP id kr3csp2452707pvb; Sun, 30 Oct 2022 15:37:13 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6cWRbr9FBUIvmDS+v5ZJXpFn85EajmG4ovV5DRz4ovZ2rty2yzdLyNg3EkcIIT49RgCiig X-Received: by 2002:a37:c205:0:b0:6fa:18aa:c514 with SMTP id i5-20020a37c205000000b006fa18aac514mr5284084qkm.549.1667169433018; Sun, 30 Oct 2022 15:37:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667169433; cv=none; d=google.com; s=arc-20160816; b=aaRAeTgfO4+x7Veoj5ziC1j8+F2wnyWiKsdsk1FElcnC9q0cjsbXkreWyy8eRNJaX9 GznlB7lSjfDtVLajtCxTg/VHvsSqKC8qydHv96Uia5W4qQxeoSGnsXSWPJJtOzsA0tyW MZqkEmyrA4Z91Kpe8QdJogR9SZTpdf5zP6FMKE+xnxVW8QeotJvqz6e4t2cJv8UlTuM0 lslojjIddjFZns6BH9GbnV0yNBmqkYSL3ZNeDmlB/6/KvpWjjXZHegxYdfb6q/C507V/ IClEvQJOMbAt4uJbbU6RrseJB7WDc0AbBBrxGFFWYmHVq7DOIf3pWhjJvvuzbm2K7+O2 qxxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Iee/Kz8E/qiEV1xSHMcLrZIy2vXY3KpeoSMnpgU+NQE=; b=eCC0BQchH0dyp/L2YjQYmrDvLDJnqbBD16s1g1SAOADIZyx5D/+vNfuHLUK50LboN+ jd85JsG5PD7MvMyYXrs9P6KoTwXuWM3bCZAj5owszyS3oa7ZA8YIx9oi2ytrRllHkRNf gbRwoOdGl7C2pETkmoh9+Se4fPjiBX+f61ch7U8wA0Kk1GHpVz8562S1pjeSTr2i2f+N DQN5XqAVgDmWy1FETufY3ArnPKavV2NcfBgiErt/a6VwZTe6ygs6adFo9aGNPTuj2P61 mSdfeyyNi3yOtFyTNweIzVjhBlqo3hwpQ/ovan5qBjHjPkBWliaa9Uv2X/+/pYvl/+r7 +kUg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=t7xtHtX0; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id u25-20020a05620a121900b006ee95e3196esi2625814qkj.162.2022.10.30.15.37.12 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 30 Oct 2022 15:37:13 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=t7xtHtX0; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1opGtZ-0007gl-G1; Sun, 30 Oct 2022 18:35:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opGrq-0003Gx-3h for qemu-devel@nongnu.org; Sun, 30 Oct 2022 18:33:26 -0400 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1opGro-0000AM-5B for qemu-devel@nongnu.org; Sun, 30 Oct 2022 18:33:21 -0400 Received: by mail-wm1-x333.google.com with SMTP id r186-20020a1c44c3000000b003cf4d389c41so7018147wma.3 for ; Sun, 30 Oct 2022 15:33:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Iee/Kz8E/qiEV1xSHMcLrZIy2vXY3KpeoSMnpgU+NQE=; b=t7xtHtX0U95xUOEuz2ovXEMcpQesGPpPk5TR6YyPUwRHbP/tPbtRV3cRHqsEQMYh1E Q62N2MTb1T0+Crrs2WAUKhKCWikRS7Znvf4NGgLKkXvjH2Aj1Rz2IFyCkYVwLjsnveqh nvz97FpZXNadV0P/oTLl9lC3SHSomUShDlrKtQVMAliRJWLP6Lec1P3L+2NYDtapQZJZ E848TpKHGJARtM222rIm9L96fygVO1izSyTrHqiCRba6AZ87Cgj+pmW+WuJUWSNfPIX3 Z68wAr8Mrj6/J24+rCMNqyOKfIOVQ4keOyd01ZzLnagc3OVaHNtqTVE7FDCNLS3mzoo3 c/5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Iee/Kz8E/qiEV1xSHMcLrZIy2vXY3KpeoSMnpgU+NQE=; b=zllQbWS7pGM5EEmv4Xrh97+JmGE9B1uxyqi5FDQXiunr/jIHDG3hBookZ+J1Vr9StY kBq6yE++GZLIlIjNmx6xnBtskOPJbjc4nCFJIDZmAyG9JBFFtcLr1tXSGqrdwdl+koLb pN9N9Nxd8doLknyEh0FAE8dc3jXvGz4MClZZizvbHUTp65GM3UkAwOcCFJ/5QrbfbB0D g+6ndQ3QTmEZfHPW9itqFiZnGR+8QBGB/rXmFqKlzZo6ySRjOGimXU/bgtdwu0Y0PMGk SuRwU5mCR7OJ78cclOvsWe8KgpOssMlzE1ww9uMlKHxUej5Qbch3nsMoATmsDXKOmcb3 Vlbg== X-Gm-Message-State: ACrzQf0wN99MSUYG5T056rqC4kJUVbmEd6vayFcyIVCdj0gKtWhD97Xp 0oyH2yeaL6IA6/7FLi73Taj2rtxtW5hKIQ== X-Received: by 2002:a05:600c:1c83:b0:3cf:4453:255b with SMTP id k3-20020a05600c1c8300b003cf4453255bmr6106714wms.20.1667169198204; Sun, 30 Oct 2022 15:33:18 -0700 (PDT) Received: from localhost.localdomain ([185.126.107.38]) by smtp.gmail.com with ESMTPSA id ck1-20020a5d5e81000000b002366553eca7sm5331169wrb.83.2022.10.30.15.33.16 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 30 Oct 2022 15:33:17 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Aleksandar Rikalo , Huacai Chen , Stefan Pejic , Jiaxun Yang , Aurelien Jarno , Paul Burton , Bernhard Beschow , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PULL 42/55] hw/isa/piix3: Add size constraints to rcr_ops Date: Sun, 30 Oct 2022 23:28:28 +0100 Message-Id: <20221030222841.42377-43-philmd@linaro.org> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221030222841.42377-1-philmd@linaro.org> References: <20221030222841.42377-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=philmd@linaro.org; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Qemu-devel" Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Bernhard Beschow According to the PIIX3 datasheet, the reset control register is one byte in size. Moreover, PIIX4 has it, so add it to PIIX3 as well. Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20221022150508.26830-5-shentey@gmail.com> Signed-off-by: Philippe Mathieu-Daudé --- hw/isa/piix3.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/isa/piix3.c b/hw/isa/piix3.c index 04895ce2e5..72dbf688d9 100644 --- a/hw/isa/piix3.c +++ b/hw/isa/piix3.c @@ -290,7 +290,11 @@ static uint64_t rcr_read(void *opaque, hwaddr addr, unsigned len) static const MemoryRegionOps rcr_ops = { .read = rcr_read, .write = rcr_write, - .endianness = DEVICE_LITTLE_ENDIAN + .endianness = DEVICE_LITTLE_ENDIAN, + .impl = { + .min_access_size = 1, + .max_access_size = 1, + }, }; static void pci_piix3_realize(PCIDevice *dev, Error **errp)