From patchwork Tue Nov 8 09:23:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 622646 Delivered-To: patch@linaro.org Received: by 2002:a17:522:c983:b0:460:3032:e3c4 with SMTP id kr3csp2807169pvb; Tue, 8 Nov 2022 01:26:43 -0800 (PST) X-Google-Smtp-Source: AMsMyM7Q8FqBbgRRHmro3dZLuVOdhPHTJ/NdD2xyMvFvmklA6J+DmlDDEJr06S5NDJFSBX5c5HO1 X-Received: by 2002:a05:6214:d84:b0:4bb:ae9f:63de with SMTP id e4-20020a0562140d8400b004bbae9f63demr50528519qve.97.1667899603707; Tue, 08 Nov 2022 01:26:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667899603; cv=none; d=google.com; s=arc-20160816; b=YgdenmGUJSDpIPCqtqgHSAwakRk2Bh8HxaVOuL8hTjPy/+u10O6xRmQ+hMqJHnuoC1 0p8egfFusi1DyKOqp74YCnzqEFoPuabpgd4YqlCeqjBJHVyKxKWEVpPtzTQcjh/xVmXc bnDjeA/1UpvbourwCOFm3zdhkidQ2M653u+i0NZvVWwddh2tw1pIUXm/qowLkOcAlcLu hU/3SSeQ2Aq2PSgwUkrG8XaGNkqx14XV+tXyvG9Wkvtc5FDUhvt7skvGQnLJgYr6XblV 35dUnJIwLKcDC/HmmUACz5qqRqrnxMbxYBa3e0DU8JClD1a8UGSofi69lOaK51FFuwVx blpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=yLNK2qdPNMQMvzK3A+Wa0kPh913JqNLXh3QyXKK7U+k=; b=Om/FqCQiYCKk09gExo58Q2AwUYUZ6YV3B37Cdq4aQzYYrUDWPOPxKIJWNnFW6NdrE/ 4LEG0DOdv4MrI2Y9Kk3UlMcORoveKo9A7H/pGor8F1nthddxdwfhay/0wISeFi/TgvI4 JEvIFcnKzDm4HUgsQDAPNvejekzW6OpkUQdX/nqStkzFo//im6jmiD+60kpmVVGVQjJD aODfXc2/vXAjffspq0Xaoi8+g20RTUC6bA9WpjIcJ8Ys5VtcyhPT+E/HDncfpkgUt6p1 2fYOetG+PrxyAocepxwcweF2bwiKkVxxDOTDMhZ1ZC8icpu3M4094gwLVBz02W4NnKNx 0xDw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=u2Z+YKLP; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id ed8-20020ad44ea8000000b004bdf0bb28besi5601576qvb.418.2022.11.08.01.26.43 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 08 Nov 2022 01:26:43 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=u2Z+YKLP; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1osKpM-0007H0-Ql; Tue, 08 Nov 2022 04:23:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osKpE-0007EQ-U1 for qemu-devel@nongnu.org; Tue, 08 Nov 2022 04:23:21 -0500 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1osKpC-0005pq-CD for qemu-devel@nongnu.org; Tue, 08 Nov 2022 04:23:20 -0500 Received: by mail-wr1-x436.google.com with SMTP id a14so19964651wru.5 for ; Tue, 08 Nov 2022 01:23:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yLNK2qdPNMQMvzK3A+Wa0kPh913JqNLXh3QyXKK7U+k=; b=u2Z+YKLP0aPMdHuzajDgrxdi213GM3D/1hKyz/jCvCw/YwUnZcRGbGdCrA/QaxQV/L lCDYOSdZYdgIvQtq5BcwgZ+yzqmTEFC1YHxYGLR1yVNfDi7QdMpWSTAzNG7yH7mo9vBf +2114x2Hm1HY+aXxapYEezSSy3hOUP3fhmTSNPEpuCXlIEBUBvjkC2UMBdOnpMgbbGG2 9C70FXtVJ5ipSUFa3MG2Fk94retDjxzbYGLYXUZc+rXbOZ4CA/rkfQO5emnq7C6ccSQx FhQwHLNfteubtBZ32iwVR2r7UreoQNGClrzNlVMlrGwT/WxWmgYVZIrVEc9pqWXTmUzK yyaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yLNK2qdPNMQMvzK3A+Wa0kPh913JqNLXh3QyXKK7U+k=; b=NOvnYx91TKV6zvHsgiDB7HQufD6Hae+txjtEiY4tiJ5fte9yz8y72Q8OagH1tUMzI+ JQLzsQl0GusE/BLKg673ZKgvaoHYBdYOzi0yKuQ0rR9zSop7lXW9/uo0Ou7CUhFGBVSJ 8Lwg6LW6I0X4AzXqotavkI8yrGLZZRqOGN+Ad85gJKWKxG+VDqCjo1f2H2CVlSwiMn5c i9Zh9jsKtyU0dJPD5+QbtKh91M9J6pSo7ZZkt1PHKJCDRT0h3+/MnZcRU3LxHwiBDppp 0FkQDrMcTA26M8H5ZY+EuYwQqvH7q1qGWwE9hrH4wpTlHMJw6lwM1vHiHKKDJb4x3Kbo V3Cw== X-Gm-Message-State: ACrzQf0RemTPOiSeJiBci3pLyBwA3niN6oiKmEve6tV0t6AxNJbk3rQZ EwoEoV+NY40/SJWbK2NwUJNyqF88xaWclA== X-Received: by 2002:a5d:644b:0:b0:236:862b:9ef1 with SMTP id d11-20020a5d644b000000b00236862b9ef1mr34495500wrw.691.1667899396924; Tue, 08 Nov 2022 01:23:16 -0800 (PST) Received: from zen.linaroharston ([185.81.254.11]) by smtp.gmail.com with ESMTPSA id s7-20020adfeb07000000b0022a3a887ceasm9538905wrn.49.2022.11.08.01.23.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Nov 2022 01:23:13 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 1E7871FFC1; Tue, 8 Nov 2022 09:23:09 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: fam@euphon.net, berrange@redhat.com, f4bug@amsat.org, aurelien@aurel32.net, pbonzini@redhat.com, stefanha@redhat.com, crosa@redhat.com, =?utf-8?q?Alex_Benn=C3=A9e?= , Markus Armbruster Subject: [PATCH v1 9/9] docs/devel: try and improve the language around patch review Date: Tue, 8 Nov 2022 09:23:08 +0000 Message-Id: <20221108092308.1717426-10-alex.bennee@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221108092308.1717426-1-alex.bennee@linaro.org> References: <20221108092308.1717426-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org It is important that contributors take the review process seriously and we collaborate in a respectful way while avoiding personal attacks. Try and make this clear in the language. Signed-off-by: Alex Bennée Reviewed-by: Markus Armbruster Reviewed-by: Stefan Hajnoczi Reviewed-by: Paolo Bonzini Message-Id: <20221012121152.1179051-5-alex.bennee@linaro.org> --- docs/devel/submitting-a-patch.rst | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/docs/devel/submitting-a-patch.rst b/docs/devel/submitting-a-patch.rst index 1f2bde0625..80e8693bb6 100644 --- a/docs/devel/submitting-a-patch.rst +++ b/docs/devel/submitting-a-patch.rst @@ -434,14 +434,20 @@ developers will identify bugs, or suggest a cleaner approach, or even just point out code style issues or commit message typos. You'll need to respond to these, and then send a second version of your patches with the issues fixed. This takes a little time and effort on your part, but -if you don't do it then your changes will never get into QEMU. It's also -just polite -- it is quite disheartening for a developer to spend time -reviewing your code and suggesting improvements, only to find that -you're not going to do anything further and it was all wasted effort. +if you don't do it then your changes will never get into QEMU. + +Remember that a maintainer is under no obligation to take your +patches. If someone has spent the time reviewing your code and +suggesting improvements and you simply re-post without either +addressing the comment directly or providing additional justification +for the change then it becomes wasted effort. You cannot demand others +merge and then fix up your code after the fact. When replying to comments on your patches **reply to all and not just the sender** -- keeping discussion on the mailing list means everybody -can follow it. +can follow it. Remember the spirit of the :ref:`code_of_conduct` and +keep discussions respectful and collaborative and avoid making +personal comments. .. _pay_attention_to_review_comments: