From patchwork Tue Nov 8 09:23:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 622641 Delivered-To: patch@linaro.org Received: by 2002:a17:522:c983:b0:460:3032:e3c4 with SMTP id kr3csp2806041pvb; Tue, 8 Nov 2022 01:24:26 -0800 (PST) X-Google-Smtp-Source: AMsMyM5Jcrkr2/SU2q9Klpk8RZD5RnU6kS5CN8pSpXf/Uplh2lEDu6JKbQsjtFLSia9tVI/d99Ur X-Received: by 2002:a05:6214:2528:b0:4b8:2025:5f6e with SMTP id gg8-20020a056214252800b004b820255f6emr48488045qvb.88.1667899466788; Tue, 08 Nov 2022 01:24:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667899466; cv=none; d=google.com; s=arc-20160816; b=qhCJCtteOYwTwMKYSKQKZCCRyUkR65EgziSVOqA6OSdjjhuTeZxV6OYSKowJR3lb6o pt2AjPjOSwx/JiW25twxiqi1Ly86mCQYY25ufpHpe9MRmzcD7bmuXliHUgI5AbwPnT1N FOc5eM+zzfr+S1IkGJX8l8Q2I929hwhSICBEkRn+BJ/JTTE1fugE3S7OCVdKi6bNQKe+ zAXcml52pgg1E40cNah5JbYEivLcunnHJ+1REMFBiaB0FPvObfNSFjZ/tv765OlUSTY0 Jy4H2M4JIPsyVjpXBgcn4gARYLVoeRcREGW5N5DrIGpBRieGerzZhhv93dFrI1BfCiuw GszQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=XsIUPL4URppAX7w6NGrUdBT/BUmCRhwxzbv6AwfzKCA=; b=0wIb2v6yGgo+zpzKtIeHhJrMwBtCPjsBQd9LlkQmtt5YyOzFDTRARrgjqIMjTAk7ih /5Af85F4CQbYn1l6rUf3vObjl5EfJfopyL6xgYhz93vlrQc1zPEsjgT7FSLLX3w3v7Aj Z1JqHcdUnQwH+zTOVsBCgzTtpLXZaJZWWxJhsNceMyDXabikqdT2PbXJHffYDD4U15Mv Ovkoj95gHVKQmhm2b+4MG6esErEvRHkD2uI1/6OHT16RvZbdOWr5UA8kghJqQ3ezRoPf te8N5n4BeOGn6SBmofXDgyNprlQKcHhnEUjQeIhBRWliOlZUXjD4m4zdkxxzUstPzhHK Jmpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=W5CvJjaZ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id e12-20020a0562140d8c00b004bb812cbf27si6002895qve.64.2022.11.08.01.24.26 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 08 Nov 2022 01:24:26 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=W5CvJjaZ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1osKpC-0007Da-Ar; Tue, 08 Nov 2022 04:23:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osKp7-0007CK-5X for qemu-devel@nongnu.org; Tue, 08 Nov 2022 04:23:13 -0500 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1osKp4-0005mb-VR for qemu-devel@nongnu.org; Tue, 08 Nov 2022 04:23:12 -0500 Received: by mail-wm1-x32f.google.com with SMTP id m7-20020a05600c090700b003cf8a105d9eso8650722wmp.5 for ; Tue, 08 Nov 2022 01:23:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XsIUPL4URppAX7w6NGrUdBT/BUmCRhwxzbv6AwfzKCA=; b=W5CvJjaZeWufGA+5W/omDak7/5f8CoqAIkChf0pWDiIq05dkeNceeKUEtRJCdYB7FN N3pAUJyRsOr3E+dRfcwsxblg9SWi6j7+EWxKUFRnonQ1xOQ0u6Kt7SS0JHvcD1jrxluq n5uTWcaInCx1zopeeqULNVcpOnErP8Ng01922eA+fskQsIZhY7dg20SlYehVMdeE7OVw O3nR7BYItRRgTrwRdwatYXjNYLa1wGfiPAndWHzsfDOy2QnNUECVlxYwpK47Wz1xHgjr i3AtjX6jZ7lIwQb95ms4Zakfy6UcopoItVnjzwXJZrVXWfrtsgOgeN6E1wWdOcOiUJVH Ig9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XsIUPL4URppAX7w6NGrUdBT/BUmCRhwxzbv6AwfzKCA=; b=e/orVsSXxXsquZ2Bg4aJpIm9Zzc4+Hl8z0dIZhPVFTC4RQSb6eDcs8np/Xm6RMq6tl PJadb3kz6bHzW6m65i/vSqljOskOppNEonCTdd/y55KGHivW5plfNyv4VPYOYJszlReb 136+MTKny6fedLhX+zj/VD737/IbxZrNO8JpQ7SSncl06VGWqv8UE/YsXWBWC9s/EPhY zGYz57KbmHAD50OJYZPSGa/aWiUCLqZqmw7Q/FqoO7k3lX9f3e9UVyO6aYYdr6RMbTgc INAS3qB2AISWkKsnG5Za5cBNx6IfXRz8tSHUgcAe+TcRee5gU0MBZ9Da5VSElR/p2WtT R5XQ== X-Gm-Message-State: ACrzQf0Js0EWcFOlv21yaMTiGEwfE9Mt680teRd8GzIkJA1fVu3VEPeD 3o0Dvg5R/8yp/lwv4o6PTgKabQ== X-Received: by 2002:a05:600c:4e45:b0:3cf:3e69:9351 with SMTP id e5-20020a05600c4e4500b003cf3e699351mr47101397wmq.2.1667899389460; Tue, 08 Nov 2022 01:23:09 -0800 (PST) Received: from zen.linaroharston ([185.81.254.11]) by smtp.gmail.com with ESMTPSA id c2-20020a5d4f02000000b002366553eca7sm9519221wru.83.2022.11.08.01.23.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Nov 2022 01:23:08 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 3CE1F1FFB8; Tue, 8 Nov 2022 09:23:08 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: fam@euphon.net, berrange@redhat.com, f4bug@amsat.org, aurelien@aurel32.net, pbonzini@redhat.com, stefanha@redhat.com, crosa@redhat.com, Stefan Weil , =?utf-8?q?Alex_Benn=C3=A9e?= , Thomas Huth Subject: [PATCH v1 1/9] Run docker probe only if docker or podman are available Date: Tue, 8 Nov 2022 09:23:00 +0000 Message-Id: <20221108092308.1717426-2-alex.bennee@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221108092308.1717426-1-alex.bennee@linaro.org> References: <20221108092308.1717426-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::32f; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x32f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Stefan Weil The docker probe uses "sudo -n" which can cause an e-mail with a security warning each time when configure is run. Therefore run docker probe only if either docker or podman are available. That avoids the problematic "sudo -n" on build environments which have neither docker nor podman installed. Fixes: c4575b59155e2e00 ("configure: store container engine in config-host.mak") Signed-off-by: Stefan Weil Message-Id: <20221030083510.310584-1-sw@weilnetz.de> Signed-off-by: Alex Bennée --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 66928692b0..26c7bc5154 100755 --- a/configure +++ b/configure @@ -1780,7 +1780,7 @@ fi # functions to probe cross compilers container="no" -if test $use_containers = "yes"; then +if test $use_containers = "yes" && (has "docker" || has "podman"); then case $($python "$source_path"/tests/docker/docker.py probe) in *docker) container=docker ;; podman) container=podman ;;