From patchwork Wed Nov 30 11:24:35 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 629470 Delivered-To: patch@linaro.org Received: by 2002:a17:522:c983:b0:460:3032:e3c4 with SMTP id kr3csp792765pvb; Wed, 30 Nov 2022 03:25:57 -0800 (PST) X-Google-Smtp-Source: AA0mqf5HYowlzHbnKci9M5hdcc7UzALpxiD9ca9jR+Y3ge2vp+WhgoUvj9WFh30TLE5GmPLNSEXc X-Received: by 2002:a05:620a:1134:b0:6d8:4bda:e9 with SMTP id p20-20020a05620a113400b006d84bda00e9mr54380104qkk.236.1669807556881; Wed, 30 Nov 2022 03:25:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669807556; cv=none; d=google.com; s=arc-20160816; b=vYLEglBFBqE+s6VjFj6mlhMbjRxkZoS3nxmMFcafdODVx809yimI2lqF1aR1dL3pRB XLiFUk+Vujuml7MbNNYlymI20xudA+NKBMpA4T3otNHr/FTT/7B1VSTeFkblTBCl4bbz oNQzQIZ0qE0NyOmAf01lP/EZGkNoKaw6JPryk9ULn4c+01MVTxsqxJarBy4eSYTpHFNI 9QdEmEIgbnGOWC4w5n459rtBTmhYbNC9kybGatDxRM1yPL4XuAg8rU+s+YMuCFSyZ6rP y0WVdVgPlLtswaocu9QSuxEChd62bKvOoYHViNbp3NhrgtWhb0p66AnFJaLPm9K1FTy7 UgCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=iLViAVmTXWmym6+HoOtpECN9I84KF70sSJE6RSB6swQ=; b=OTmlQB+syCGRK742jLbEutc4bfp8FZrrpfW25S+pHfE74kNc+hGumC6VVG/QbaYa0u jH7Dc0/jx4tO1oxe5vzmN87BnjoZgT1OFvjiPJI0U8C97Vusx7UQvYFOCjKryjOx5P+K 20Ep5iAIK8VT+GZiaxrZVqTF8iXHoFyEq5cieOWa8K93qYWtJRn5goQ+9A3tEW8scqTR qtwNsLiwbIfPUvJXUBVaIbGkMmDrVnDLvqmf5tZDWLVdw35KGWeVE9Im5WK2MHZGeuBa jdGaYpcN4XUDHtP4oGVx8Y4wajHP/RTXWiSOJcC7iQpekV59++11/OhgeC2ClwhSw7x9 npLw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=TMssN8SO; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id u28-20020a37ab1c000000b006bb9cfda390si590071qke.31.2022.11.30.03.25.56 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 30 Nov 2022 03:25:56 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=TMssN8SO; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p0LCo-0004KS-2H; Wed, 30 Nov 2022 06:24:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0LCm-0004K3-AQ for qemu-devel@nongnu.org; Wed, 30 Nov 2022 06:24:44 -0500 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p0LCj-0004ec-UC for qemu-devel@nongnu.org; Wed, 30 Nov 2022 06:24:44 -0500 Received: by mail-wr1-x42e.google.com with SMTP id w15so13375019wrl.9 for ; Wed, 30 Nov 2022 03:24:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iLViAVmTXWmym6+HoOtpECN9I84KF70sSJE6RSB6swQ=; b=TMssN8SOZZbbPyCWKTbTjINvOms8RBYIV1DULI2ALB/bF/HK8t112Xwwa0SIVwgqvW NdCO+buymEhNIg11pDoqKwj2F8bFKAPxwaUTLB/dYQv+avWLmGjMeKp3kIIYRPlkgTbu oE4jEzkL6VlMaErhwfqrKSitwsmAgNKzVQlkQwjSFd8IbFhRPNClGcPipNVDx7Pw5bhs BLA8un72GZaeewmzZvih6lh5USLs1rYFcEJf2ri6gepbSUWWEtUNhDmLDdeJGg2zAlQY fsfkfWC/zTf31ASkL9ij90Zkpo8FbAX4bOCojylInu88mQYjo21rLZaSVTcRBAhjKf6l Yu+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iLViAVmTXWmym6+HoOtpECN9I84KF70sSJE6RSB6swQ=; b=LgFdFE7SfMwmxtdj6fURDN2biV8O0od+BN5ariUpbPPCDeODnc+8JKMA7+y7xsMgEn ZHlyfYG1Wm7xFrX3zVl/Ubz6sPlaIA/rS4K/7wc+ymRHfOH4sgt/i7DcW7HWlQ02vGJR tBz1ApYAJrr4FzmjyDf2KwRAkzQSDozib3x1kl6G4JGG7u0qHomYKerZDGdzid4A+lpL CEiHgRC+CCdf6r805oQ3qN0ku4ITl9Se3WRFbrHWM5G4mTfXszdx0wjwCNybfSdLZ2s+ WdFKuhQzicHvyJJuOP45qpGmqHbPqF6l1lJydn0I/tG4rH31suTp658GXd2IYE+FiQ4E NY1w== X-Gm-Message-State: ANoB5pkpSIUpb0Du/yiL0pMA3rXTwv+BuLtO+5+rk+Z8lrQpdM3VqjVw HElDon6wLNY+B/zhTwnA8OnOjg== X-Received: by 2002:adf:ecc6:0:b0:236:791e:cedb with SMTP id s6-20020adfecc6000000b00236791ecedbmr37162591wro.64.1669807480490; Wed, 30 Nov 2022 03:24:40 -0800 (PST) Received: from zen.linaroharston ([185.81.254.11]) by smtp.gmail.com with ESMTPSA id t1-20020a5d49c1000000b00241e4bff85asm1198989wrs.100.2022.11.30.03.24.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Nov 2022 03:24:40 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 6DB681FFB8; Wed, 30 Nov 2022 11:24:39 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: slp@redhat.com, mst@redhat.com, marcandre.lureau@redhat.com, stefanha@redhat.com, mathieu.poirier@linaro.org, viresh.kumar@linaro.org, sgarzare@redhat.com, =?utf-8?q?Alex_Benn=C3=A9e?= , Thomas Huth , Laurent Vivier , Paolo Bonzini Subject: [PATCH v4 1/5] tests/qtests: override "force-legacy" for gpio virtio-mmio tests Date: Wed, 30 Nov 2022 11:24:35 +0000 Message-Id: <20221130112439.2527228-2-alex.bennee@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221130112439.2527228-1-alex.bennee@linaro.org> References: <20221130112439.2527228-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42e; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org The GPIO device is a VIRTIO_F_VERSION_1 devices but running with a legacy MMIO interface we miss out that feature bit causing confusion. For the GPIO test force the mmio bus to support non-legacy so we can properly test it. Signed-off-by: Alex Bennée Reviewed-by: Michael S. Tsirkin Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1333 Acked-by: Thomas Huth --- tests/qtest/libqos/virtio-gpio.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/qtest/libqos/virtio-gpio.c b/tests/qtest/libqos/virtio-gpio.c index 762aa6695b..f22d7b5eb5 100644 --- a/tests/qtest/libqos/virtio-gpio.c +++ b/tests/qtest/libqos/virtio-gpio.c @@ -154,7 +154,8 @@ static void virtio_gpio_register_nodes(void) QOSGraphEdgeOptions edge_opts = { }; /* vhost-user-gpio-device */ - edge_opts.extra_device_opts = "id=gpio0,chardev=chr-vhost-user-test"; + edge_opts.extra_device_opts = "id=gpio0,chardev=chr-vhost-user-test " + "-global virtio-mmio.force-legacy=false"; qos_node_create_driver("vhost-user-gpio-device", virtio_gpio_device_create); qos_node_consumes("vhost-user-gpio-device", "virtio-bus", &edge_opts);