diff mbox series

[PATCH-for-8.0,1/5] cpu: Remove capstone meson dependency

Message ID 20221130135241.85060-2-philmd@linaro.org
State Superseded
Headers show
Series cpu: Move target-independent code to common code | expand

Commit Message

Philippe Mathieu-Daudé Nov. 30, 2022, 1:52 p.m. UTC 
Only disas.c requires capstone CFLAGS, not cpu.c.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 meson.build | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Marc-André Lureau Feb. 27, 2023, 10:54 a.m. UTC | #1 
On Wed, Nov 30, 2022 at 5:55 PM Philippe Mathieu-Daudé
<philmd@linaro.org> wrote:
>
> Only disas.c requires capstone CFLAGS, not cpu.c.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>


> ---
>  meson.build | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meson.build b/meson.build
> index 5c6b5a1c75..92d449f854 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -3097,11 +3097,12 @@ if have_block
>  endif
>
>  common_ss.add(files('cpus-common.c'))
> +specific_ss.add(files('cpu.c'))
>
>  subdir('softmmu')
>
>  common_ss.add(capstone)
> -specific_ss.add(files('cpu.c', 'disas.c'), capstone)
> +specific_ss.add(files('disas.c'), capstone)
>
>  # Work around a gcc bug/misfeature wherein constant propagation looks
>  # through an alias:
> --
> 2.38.1
>
>
diff mbox series

Patch

diff --git a/meson.build b/meson.build
index 5c6b5a1c75..92d449f854 100644
--- a/meson.build
+++ b/meson.build
@@ -3097,11 +3097,12 @@  if have_block
 endif
 
 common_ss.add(files('cpus-common.c'))
+specific_ss.add(files('cpu.c'))
 
 subdir('softmmu')
 
 common_ss.add(capstone)
-specific_ss.add(files('cpu.c', 'disas.c'), capstone)
+specific_ss.add(files('disas.c'), capstone)
 
 # Work around a gcc bug/misfeature wherein constant propagation looks
 # through an alias: