From patchwork Fri Dec 2 05:39:27 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 630208 Delivered-To: patch@linaro.org Received: by 2002:a17:522:c983:b0:460:3032:e3c4 with SMTP id kr3csp716381pvb; Thu, 1 Dec 2022 21:44:18 -0800 (PST) X-Google-Smtp-Source: AA0mqf6cWnHz3ZBE4GUKw4LWi4o4d3xVWJBkxjuDXZ/yddI74l3dXaUT5i4YXrvZJQb1rqSInlRt X-Received: by 2002:ac8:7312:0:b0:3a5:3628:4304 with SMTP id x18-20020ac87312000000b003a536284304mr50340670qto.517.1669959857855; Thu, 01 Dec 2022 21:44:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669959857; cv=none; d=google.com; s=arc-20160816; b=rxp/UJ8DSiwHuR8Mwunuv1utTq92HRSDfxRoEJIqWlbauKimUlNtggvTYf8vt9qdGG kUdTlOWn61lpC6sOS09uE8gn5gC8u5At+2RFsf3FSu2fjWbej3/XEK6qGYOAVeJpM3aT wvst8/iw8ejTGwRG/uK4M/CQphpC+2jQDr2p8egGk2SYm3eTLJQSEPADjBHQzrngwrLo Z7EOc0pL/Q8YjrFNw6e+cB/AS0poZjdSXTt398VpE6e9LDElTzm4tXR+ctEtGhFYudv1 J/dKJlvEVp+dSfZLteCxMQRcJCb+C+yQxJ0Aigp79SZ1PKypSKIZ/q24+kLubPn/uj41 oQfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=l2AYVfOigGNcWueyGcFEAyNre3J/WgPqkB4M4xEOEGc=; b=dQf2T7S2DcZuw/CyUznhA9RxNSZ8CzLeFXji02fwXiEfAtK0eH3+jMU9VM+ma7eTUj /x/Uqse6JPoAnlcOMbzcyRbtqULmxkn4JdcA7iDf7t3AAl0Y1hOTUlQugaNu14Ph9IVD UV7uRbErV0DBxRHGdiWOAvx0gh8XK6FbTLEztWuETCbHp/Ujaka+n4IujL9tY++hz2gD t32ZfT7xz2cUSUYJy9OeC/PUcMxlFXLykrzLRPo9YMz1wrNCdyFico/gMLgfvcuVOuf6 S0//O92PMCZBqJ1Yds4rQ+j7OucnCp8KqsAzsVjDbE6A+0peTal+vRXHcZNTvGjCDQeY 0psw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=bZtQRadi; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id ga23-20020a05622a591700b003a623a4afd9si3766652qtb.677.2022.12.01.21.44.17 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 01 Dec 2022 21:44:17 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=bZtQRadi; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p0ymN-0002W4-Cj; Fri, 02 Dec 2022 00:40:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0ymM-0002Vj-EJ for qemu-devel@nongnu.org; Fri, 02 Dec 2022 00:40:06 -0500 Received: from mail-pf1-x42e.google.com ([2607:f8b0:4864:20::42e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p0ymK-0003Bu-In for qemu-devel@nongnu.org; Fri, 02 Dec 2022 00:40:06 -0500 Received: by mail-pf1-x42e.google.com with SMTP id 21so3964460pfw.4 for ; Thu, 01 Dec 2022 21:40:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=l2AYVfOigGNcWueyGcFEAyNre3J/WgPqkB4M4xEOEGc=; b=bZtQRadi8r12yA7REVcLobpqUjKAVi+r48VSR/QMv/GDxXb/GOIaLeB9jHhovRQiYE GJh3bOW62+37pyzZZVqYFcWDtlkFm4qmPr/Oun3FWRtElCyC3Df/+AIE7hhxggP+1HqV QyNlowzu0oQYMoJUPflm23LSKtv9ml0F4ijqEXs9qFZbK2BamfcFiepsiWiOx6moB2Kw 6dfsKZgfbpfGwbM7uAdpNkXYwU9X1HeQQlkahfREPepg8T6vkAZz9IvbQ7Jv2oBs+mZz LjcA7RXSwKtYe/HRyduI4LyEL0YNJ34LXlUgFBC4cA1rdlMUCl5z3zarEOiyNbTIWJLP bqnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=l2AYVfOigGNcWueyGcFEAyNre3J/WgPqkB4M4xEOEGc=; b=aYLjUQsCmGtjLFTtstIfQfrPQtt2YR7zF/bCSEiZiKP4YPBYFBav7g+PCxdjq40W7U F9lWefl5jD/YjYdKWKmeziAIWtZSxNUbA6az+M1x57nm2NqZuC9OFmdzXSETW2naH5g/ HQG2YzswxvTzavzxbE6I1YmcF/OJtXr4xBRPnTxZZ+GsB9/wMBon6FpfoBQOSIVKJpJs +wjY89XiglXpEewqPBSQaTeuY2QQxYqF6KYIvhAbqU/k4pSWo7cfiFTnH4Zt/LfmgUVO pTMQXOc4JlznEw15bZSoOthvy3yHzG2wdqeQb+YAP9b9y6kwgVm/lt2WTGaq2xQQBaCB fLRA== X-Gm-Message-State: ANoB5pkHnOs+aFJSPdTU210dQtyXxAA+tH3Mq6y0UKgU5fISSIilXTSV JBDk2vaYbd2kvQodYwAyf+H7F54RomTbhg9N X-Received: by 2002:a63:dd43:0:b0:45c:5a74:9a92 with SMTP id g3-20020a63dd43000000b0045c5a749a92mr44635679pgj.473.1669959603052; Thu, 01 Dec 2022 21:40:03 -0800 (PST) Received: from stoup.. ([2602:47:d48a:1201:e3cc:2e37:17d4:f1d5]) by smtp.gmail.com with ESMTPSA id d12-20020a170903230c00b00186f0f59c85sm4637075plh.235.2022.12.01.21.40.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Dec 2022 21:40:02 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Wilfred Mallawa Subject: [PATCH v3 03/34] tcg/s390x: Fix coding style Date: Thu, 1 Dec 2022 21:39:27 -0800 Message-Id: <20221202053958.223890-4-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221202053958.223890-1-richard.henderson@linaro.org> References: <20221202053958.223890-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::42e; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Philippe Mathieu-Daudé We are going to modify this code, so fix its style first to avoid: ERROR: spaces required around that '*' (ctx:VxV) #281: FILE: tcg/s390x/tcg-target.c.inc:1224: + uintptr_t mask = ~(0xffffull << i*16); ^ Reviewed-by: Wilfred Mallawa Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20221130132654.76369-2-philmd@linaro.org> Signed-off-by: Richard Henderson --- tcg/s390x/tcg-target.c.inc | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/tcg/s390x/tcg-target.c.inc b/tcg/s390x/tcg-target.c.inc index 33becd7694..f1d3907cd8 100644 --- a/tcg/s390x/tcg-target.c.inc +++ b/tcg/s390x/tcg-target.c.inc @@ -802,9 +802,9 @@ static bool maybe_out_small_movi(TCGContext *s, TCGType type, } for (i = 0; i < 4; i++) { - tcg_target_long mask = 0xffffull << i*16; + tcg_target_long mask = 0xffffull << i * 16; if ((uval & mask) == uval) { - tcg_out_insn_RI(s, lli_insns[i], ret, uval >> i*16); + tcg_out_insn_RI(s, lli_insns[i], ret, uval >> i * 16); return true; } } @@ -1221,9 +1221,9 @@ static void tgen_andi(TCGContext *s, TCGType type, TCGReg dest, uint64_t val) /* Try all 32-bit insns that can perform it in one go. */ for (i = 0; i < 4; i++) { - tcg_target_ulong mask = ~(0xffffull << i*16); + tcg_target_ulong mask = ~(0xffffull << i * 16); if (((val | ~valid) & mask) == mask) { - tcg_out_insn_RI(s, ni_insns[i], dest, val >> i*16); + tcg_out_insn_RI(s, ni_insns[i], dest, val >> i * 16); return; } } @@ -1231,9 +1231,9 @@ static void tgen_andi(TCGContext *s, TCGType type, TCGReg dest, uint64_t val) /* Try all 48-bit insns that can perform it in one go. */ if (HAVE_FACILITY(EXT_IMM)) { for (i = 0; i < 2; i++) { - tcg_target_ulong mask = ~(0xffffffffull << i*32); + tcg_target_ulong mask = ~(0xffffffffull << i * 32); if (((val | ~valid) & mask) == mask) { - tcg_out_insn_RIL(s, nif_insns[i], dest, val >> i*32); + tcg_out_insn_RIL(s, nif_insns[i], dest, val >> i * 32); return; } } @@ -1279,9 +1279,9 @@ static void tgen_ori(TCGContext *s, TCGType type, TCGReg dest, uint64_t val) /* Try all 32-bit insns that can perform it in one go. */ for (i = 0; i < 4; i++) { - tcg_target_ulong mask = (0xffffull << i*16); + tcg_target_ulong mask = (0xffffull << i * 16); if ((val & mask) != 0 && (val & ~mask) == 0) { - tcg_out_insn_RI(s, oi_insns[i], dest, val >> i*16); + tcg_out_insn_RI(s, oi_insns[i], dest, val >> i * 16); return; } } @@ -1289,9 +1289,9 @@ static void tgen_ori(TCGContext *s, TCGType type, TCGReg dest, uint64_t val) /* Try all 48-bit insns that can perform it in one go. */ if (HAVE_FACILITY(EXT_IMM)) { for (i = 0; i < 2; i++) { - tcg_target_ulong mask = (0xffffffffull << i*32); + tcg_target_ulong mask = (0xffffffffull << i * 32); if ((val & mask) != 0 && (val & ~mask) == 0) { - tcg_out_insn_RIL(s, oif_insns[i], dest, val >> i*32); + tcg_out_insn_RIL(s, oif_insns[i], dest, val >> i * 32); return; } }