From patchwork Mon Dec 12 20:49:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 633238 Delivered-To: patch@linaro.org Received: by 2002:a17:522:c983:b0:460:3032:e3c4 with SMTP id kr3csp2706804pvb; Mon, 12 Dec 2022 12:50:35 -0800 (PST) X-Google-Smtp-Source: AA0mqf5p6wJFrinatMSJLyFh6nP3FqKbIMm11dbT74F86Es71s6/KCKUPrqr4atQJQwNcKCHHUys X-Received: by 2002:ad4:4f41:0:b0:4e0:cdc2:3bd8 with SMTP id eu1-20020ad44f41000000b004e0cdc23bd8mr6240256qvb.11.1670878235033; Mon, 12 Dec 2022 12:50:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670878235; cv=none; d=google.com; s=arc-20160816; b=xeAF9LROZB0p/g1Huta4927dYHLLmqL3l5kh06mtMUCVTunoZhH23t/mMYpsAb48ha XONGUj/A+qzX6gXvpuRkpEL9az0FsPPDjTFiQKOyium9qra/ak8vJ41oPnGYto/DYH2j 2l1wVvmOhTm1IzHkXWegZT+pSoeoTATYsbVifFVwm+ZzGgddcVll5unaNrJpzivPHaNa Kiz2l2tEiQfRprzaJDIRiq0E3jd4jhD+HkZG5F/H16bjEw/0QBmG1//P4mpAmhfQoHbY C/d4RaqdZSv6w2dLaqSRBiysX6MssRM/Ka0tcIe0BLLIUz1COuWj79v+q3IZgTTyNvik t2Cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:to:from:dkim-signature; bh=FSAtrngnhPgw/ml/GiwFJEvLw8DF1Hz9wANEfzrgNlI=; b=vwXpk1CVUa75bW+Yd8sBgz9SwI2WkijVYca1mKzALVTivEU1rX1nQVfWP1/P7Gs1J1 1nSR0PQgDQuBbzKV2Ok8TvWOXhHenxH4jqDJNCO0jRfFZSLC17+D/P+EI4tCd8P3z00U HIaz7Hf1uq+vHbykiI853SmrEuq/IaNq1rdbLWA3A+IQe2KF2gk4ceSa/5sfanJlndqf dHlfO4c3GjCKqRSvHIo3AaSyf/+PO0r+9umGZvyOXm/qk+Xm5yHFNZZ4MLXtdd+QDBih wdchim608/u4CZQVpjJHNeH392b30sqoYaafzgxHV7Xva9mcopGeoWgvjfGuzhiQyUac cPMw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=x2ognOj3; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d10-20020a05621421ca00b004caaa358043si6453930qvh.1.2022.12.12.12.50.34 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 12 Dec 2022 12:50:35 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=x2ognOj3; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4pkV-00019y-IN; Mon, 12 Dec 2022 15:50:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4pkU-00019a-33 for qemu-devel@nongnu.org; Mon, 12 Dec 2022 15:50:06 -0500 Received: from mail-ot1-x333.google.com ([2607:f8b0:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p4pkS-0008Um-Az for qemu-devel@nongnu.org; Mon, 12 Dec 2022 15:50:05 -0500 Received: by mail-ot1-x333.google.com with SMTP id x25-20020a056830115900b00670932eff32so2670885otq.3 for ; Mon, 12 Dec 2022 12:50:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=FSAtrngnhPgw/ml/GiwFJEvLw8DF1Hz9wANEfzrgNlI=; b=x2ognOj3pWZYLnJBhdhrugwYR/xIeIPSQxtjgswbwq847QSYRnavoW0voOkQz7FPcS nB1fw96zFz7B7zJ1ypDxxNk5ClSkULckEwDchPqpQBMsCBgEiLCQKV32/GZWYLTVqyhH gU3m0MdFWBfW3kXXPiQkjN92bas3ChnuhmFm8totzqI982g36aNWBXvjW68jndBDZFzX 863keKrQL3v3P3L4ImzSLR2iS3bfDwHHLCNvyMv50jfTI/c6LuILztcQkEIPc+5EoiIH rBW7r6lf+d5IkG0VgrQnoXVQjzHoBy7KMeT9JJV3iXoVJliHmarp4+CAxmxhjwFvxdrf 5zzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FSAtrngnhPgw/ml/GiwFJEvLw8DF1Hz9wANEfzrgNlI=; b=Is/HnYliWQBqNUudWTop6HFkPxsR31n1tWHRBGepZrxeQdrsslIAs0ipc3btxJ8jyi EtIzfSK0AMUvpb73S129oQiQrktUFJdSlejlh1gcBhagoZIUBGLEMToU358sQapb/46N eyE3dfOTzc+VesPpzWfXFR+/BjDlpgyMSjqkSJl5PKmR0eJhHKuooBRcIJTB8K641HLe +KJmsvWP8B4JDODv3XlL5Dwp3UtCUmzQrFce6CqLrQCbK/YswEfvhJbt5vV2hUgf8gms N/+F6jDcwyWVL2XOqQvYI32q6J7b2ezL6FnKwg1Z134v7NCs6WgIxJxZ1YJ2dVYcVkxy X8Vw== X-Gm-Message-State: ANoB5pnAoCvR1CLe8ExbQxbH7KOjsVLoWQ+s0e5vYX07ksNbnRnnRpJM BKHFLdyR9VhRI8Y1Zj6eSk8bFYINV6528PTe5R8= X-Received: by 2002:a05:6830:6113:b0:661:dfeb:a95f with SMTP id ca19-20020a056830611300b00661dfeba95fmr12595312otb.10.1670878202631; Mon, 12 Dec 2022 12:50:02 -0800 (PST) Received: from stoup.. ([2806:102e:18:2efc:20f0:1d0e:8e1f:fff0]) by smtp.gmail.com with ESMTPSA id v3-20020a0568301bc300b006705e35c4e2sm381816ota.35.2022.12.12.12.50.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Dec 2022 12:50:02 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH] target/tricore: Fix gdbstub write to address registers Date: Mon, 12 Dec 2022 14:49:59 -0600 Message-Id: <20221212204959.1353838-1-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::333; envelope-from=richard.henderson@linaro.org; helo=mail-ot1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Typo had double-writes to data registers. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1363 Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- target/tricore/gdbstub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/tricore/gdbstub.c b/target/tricore/gdbstub.c index ebf32defde..3a27a7e65d 100644 --- a/target/tricore/gdbstub.c +++ b/target/tricore/gdbstub.c @@ -130,7 +130,7 @@ int tricore_cpu_gdb_write_register(CPUState *cs, uint8_t *mem_buf, int n) if (n < 16) { /* data registers */ env->gpr_d[n] = tmp; } else if (n < 32) { /* address registers */ - env->gpr_d[n - 16] = tmp; + env->gpr_a[n - 16] = tmp; } else { tricore_cpu_gdb_write_csfr(env, n, tmp); }