From patchwork Wed Dec 21 07:42:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 635604 Delivered-To: patch@linaro.org Received: by 2002:a17:522:c983:b0:460:3032:e3c4 with SMTP id kr3csp3369718pvb; Tue, 20 Dec 2022 23:43:39 -0800 (PST) X-Google-Smtp-Source: AMrXdXuXWePg9OvEYRIfRK8cr8w9jS515ay0+KBSTnsgaLcaJlf8hQVTY+9wmxZ8T/Ak8OyscLtn X-Received: by 2002:a05:6214:2c20:b0:51f:6fd9:e5a with SMTP id lc32-20020a0562142c2000b0051f6fd90e5amr1314938qvb.39.1671608619271; Tue, 20 Dec 2022 23:43:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671608619; cv=none; d=google.com; s=arc-20160816; b=N+/BSqutAKO43y72yfPEBVxWBL5IiMwzDTp55NvBbU5qXBQn+g+MEj44DUcjkLeUfH 0l2xdHnpkjD/GVeNuPP4ISvW2/l7ZhdQwMpek5kHeFxvP0tUVfDRxCT4CyovdHI18sn+ 1PIKUvea8RH9sfFPzQLDvkHhn22iG1FMBJ2QW12Ma9IndD/C1+efyzZ/3DBvcb7G5vh7 TnhxF+8jCU1Xep0r36b+I1BzAFNJO0CB4orx+iZvBh7OI02ZUuIzMZ6jOpwoPXE+J607 fo5inMljB03ltefaD5namD4jM8f+4oOiJebvTRqA7uoa98jKbsHJuFWwhVOPo+JuDuJK Po0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=etP2h5UOgxyD1g2PWXehDiF8c3xFUHhjjtIkvhRulcs=; b=0yrLM+ReXYGRLUjZUYSimNp4KAtQ0g8FIFbGQgAh4SWVTdpGSXcfp/brJJZtvv5yPL jYynwu9hfxX1wg5frKkeHjbZnEzr8Bg8sFNQ7gN4BYkE+0KYgnq6KEbqiKP5ZHPfE78h yoba5XFev5kG4rQdvj/VU7mfPX/pSRHHwxdLeSX89l8UkKXkI+gx0tfwQlpGg1Pqgem2 +Lk2WWcKLaH4coL4lS5tS26NCyrNxn6niPyWZSC6H/fhrX96aoH8vPynnWqEK4Ok0TD5 tQJZRAjK9ZqDUZRlrWjV15y1pfls7q8OeAmy7u72OGlRU72L1bBF4ymjEnukZhgkM1ff 8aeQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=w7g8dth1; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id x10-20020a05620a448a00b006e366c7db36si6468778qkp.427.2022.12.20.23.43.39 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 20 Dec 2022 23:43:39 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=w7g8dth1; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p7tkk-00070P-Bx; Wed, 21 Dec 2022 02:43:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7tke-0006zY-RI for qemu-devel@nongnu.org; Wed, 21 Dec 2022 02:42:56 -0500 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p7tkc-00048a-W4 for qemu-devel@nongnu.org; Wed, 21 Dec 2022 02:42:56 -0500 Received: by mail-wm1-x336.google.com with SMTP id p13-20020a05600c468d00b003cf8859ed1bso813118wmo.1 for ; Tue, 20 Dec 2022 23:42:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=etP2h5UOgxyD1g2PWXehDiF8c3xFUHhjjtIkvhRulcs=; b=w7g8dth1VdNOaNVZ81OAEx5TTDwd0vTJ56EDWi7ti11z4vMfKEKSLqFpgsbKWRcMnN 2HOJoYCgosjpUWKL2Aunmjb350J65aNIjMgHn+M3jXnsnVeHCAiL1AOuzmf3Hdd95UO0 +W3E5Drvxld3NNN27eecuzqb4J1zF0jkTYI0pBDQlmo4SFUs8smPg0XYMbn+0QZKIY69 vv4Epq3bo8hvCEN/faBr0vSsnbQWtFlYQ0rXYf++YurXa8XPghakP8J08KdxglbtXyc1 9ND2CQ8uD6Y41PGBz/yAwIG84fwjQJGBq8HJG31/omL8JCz6zwLO/58miMu+XdVnysOI KM/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=etP2h5UOgxyD1g2PWXehDiF8c3xFUHhjjtIkvhRulcs=; b=AKD2l2yi/Hqr29q6m08PpJwyPPagMVJOJo+f2yTNqOkrt82Dyb7rJO8ypQ8GHzJYa0 eI+AnsqXuusjqeVhBK3n30YrxNbK00NnCCa+N/FhRWcAh2LIp8IPW25odLgi61ZNLIYs sVKLqCpnrtHH+hDmz4jplRmGSKgH/ai5Qq4tnve5iUMeaAgxr3nkJTpT2vvdvQtDHwfo J1HxCoNQeFqjiiYAJJz3k7kW9nkGPZh8mdzfEY0Uj6criW849ihZegnSqZtrRRmCFCPb jP7TNuY0m4p1aEJPpBgQxEfatdzD6DvwX7grO3ljamaYSJAc6iMs2eWI3k2VThN8nTRf Ev6w== X-Gm-Message-State: AFqh2krtJex69M9QM2rs/remfySEzcx7gSoc1TFsgVHmg8rL5PpHtorp YDB7yjL+07QkV1i9t3Q/cyLpFQ== X-Received: by 2002:a05:600c:4fc6:b0:3d3:4a47:52e9 with SMTP id o6-20020a05600c4fc600b003d34a4752e9mr881916wmq.15.1671608573524; Tue, 20 Dec 2022 23:42:53 -0800 (PST) Received: from zen.linaroharston ([185.81.254.11]) by smtp.gmail.com with ESMTPSA id r13-20020a05600c458d00b003d34f170487sm1744649wmo.0.2022.12.20.23.42.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Dec 2022 23:42:53 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 7620B1FFB8; Wed, 21 Dec 2022 07:42:52 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Beraldo Leal , Paolo Bonzini , fam@euphon.net, berrange@redhat.com, f4bug@amsat.org, stefanha@redhat.com, crosa@redhat.com, =?utf-8?q?Alex_Benn=C3=A9e?= , Thomas Huth , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Wainer dos Santos Moschetta , Mukilan Thiyagarajan , Richard Henderson Subject: [[PATCH]--edit 1/6] configure: Fix check-tcg not executing any tests Date: Wed, 21 Dec 2022 07:42:47 +0000 Message-Id: <20221221074252.1962896-2-alex.bennee@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221221074252.1962896-1-alex.bennee@linaro.org> References: <20221221074252.1962896-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Mukilan Thiyagarajan After configuring with --target-list=hexagon-linux-user running `make check-tcg` just prints the following: ``` make: Nothing to be done for 'check-tcg' ``` In the probe_target_compiler function, the 'break' command is used incorrectly. There are no lexically enclosing loops associated with that break command which is an unspecfied behaviour in the POSIX standard. The dash shell implementation aborts the currently executing loop, in this case, causing the rest of the logic for the loop in line 2490 to be skipped, which means no Makefiles are generated for the tcg target tests. Fixes: c3b570b5a9a24d25 (configure: don't enable cross compilers unless in target_list) Signed-off-by: Mukilan Thiyagarajan Reviewed-by: Richard Henderson Link: https://patchew.org/QEMU/20221207082309.9966-1-quic._5Fmthiyaga@quicinc.com/ Message-Id: <20221207082309.9966-1-quic_mthiyaga@quicinc.com> Signed-off-by: Alex Bennée --- configure | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/configure b/configure index 26c7bc5154..7a804fb657 100755 --- a/configure +++ b/configure @@ -1881,9 +1881,7 @@ probe_target_compiler() { # We shall skip configuring the target compiler if the user didn't # bother enabling an appropriate guest. This avoids building # extraneous firmware images and tests. - if test "${target_list#*$1}" != "$1"; then - break; - else + if test "${target_list#*$1}" = "$1"; then return 1 fi