From patchwork Wed Dec 21 09:04:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 635613 Delivered-To: patch@linaro.org Received: by 2002:a17:522:c983:b0:460:3032:e3c4 with SMTP id kr3csp3399712pvb; Wed, 21 Dec 2022 01:05:31 -0800 (PST) X-Google-Smtp-Source: AMrXdXvCHGMDmEWhp5m6s7d51PHV3dW9eIUyIRxQbvNQehAdGKmDgqR9sKjkaqfwbR+2UlEMfMpq X-Received: by 2002:ac8:5f0f:0:b0:3a6:2170:b089 with SMTP id x15-20020ac85f0f000000b003a62170b089mr1080491qta.12.1671613530843; Wed, 21 Dec 2022 01:05:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671613530; cv=none; d=google.com; s=arc-20160816; b=Bgw+1FPlsO1jqkESIfhGyetPF0vDblyCxKxz0CkkXmoIw2ll8FSSz2ibjzJOYpiWQx biatgNbMX61JRCnCoxtJzaCCOsyDzxKdx1ZZp2T1Nx617bWG7IssdlByJ/dg5zv4kzNE BtLC5FTJk0nYHqorP1u077W3EOGWfwY/aVYwpWcVqLgKx9e2Lc4wQRDllX+VM0ZxgPXZ QUACfxvrs+Isw4fes1B0hqW7d9h4RFL/T2068WAKxM9vE+4YHvJLsH8Xqdf6mjXd6j7v bGYQbuZSPLGqTcThJ5BK4nLyTXSZdSJcstWHYTICeKEitOiqB3BLk+DtqZbRGMcp7whP 5NZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=etP2h5UOgxyD1g2PWXehDiF8c3xFUHhjjtIkvhRulcs=; b=oWkPo0f6M85CyablEef9plqTa4fbb3w2rgIs4EuSB/8E8U7ZP0Tx01U5E89u+L5YPN lOVp+kks4fOr48xOQkYu0mGmVjbSJ24RZzFa4gJ06kVGVTZA8berWqCKE1B7d9XnanEN MlDqmemc5rlhHr3eIrU4NB69WjMSDetP7HkRz+PrDADY9WJTejkeCR7cabYsK8m6Dvtw fgsykcXioxn/A7VcE7A9YM2ji54o8ENF/mBk3yvdtfS0h27rqT9FJbh0HpAfkS4khsPW SkrKj7eJOWtilap+6h1BDiG/d/6IFpmJYAAsM90l+cplxhA9SVnrypDaTSJnwV8Atx0k CWlg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hXHgtb5e; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id h6-20020a05620a400600b006fee65927d2si1581550qko.214.2022.12.21.01.05.30 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 21 Dec 2022 01:05:30 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hXHgtb5e; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p7v1S-00006t-TI; Wed, 21 Dec 2022 04:04:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7v1M-00006Q-D5 for qemu-devel@nongnu.org; Wed, 21 Dec 2022 04:04:16 -0500 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p7v1K-0000Dt-Ff for qemu-devel@nongnu.org; Wed, 21 Dec 2022 04:04:16 -0500 Received: by mail-wm1-x32b.google.com with SMTP id ja17so10664800wmb.3 for ; Wed, 21 Dec 2022 01:04:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=etP2h5UOgxyD1g2PWXehDiF8c3xFUHhjjtIkvhRulcs=; b=hXHgtb5ez0wRnqQiZ9aT4kJ594Uncy8L7tV2J/pkDVcwSgh6mPXsfyhzY2jufoCeuf OY4rNGhkW9r/two6Zi9C1a4fq7gS83xPC0NMhu0YYQM52SodSMSOczMAFMuxrHkGG+g1 svoZtB6VPTNGEMrRmxn0SqJHLTfvH72his8CNsEz6fJAtck+OwXuir+GsH/Qf83Nak5P UT5bIksNM+hFRLRscsJ4kNppdJDJaUZPPMGDSj1p+L75PJWFLzqcaqLZpXgcaztQ9+QE 5YCi2NY5rsfI6qzxA/DFtpyDfeSh+PGIjfO0ilZS7W8ICW+DNe1YzS9nYbizQ3LGTgkX Qdhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=etP2h5UOgxyD1g2PWXehDiF8c3xFUHhjjtIkvhRulcs=; b=Ncc8FtDEmtczkF7LBJ4ccl/SfsthJCnS0cP6kwzc+FLWaZzxdNJEa6uqJjfHJphjKz TwEPwNFiKzHO5nMtqgxuGfJLwOoAPJNs5AVvMJSoZgCml9f2F027OntMtt7wUEBsMsx8 hX8O9vduxNnXJwoigDngYK7cXBTfNyKqTmuzHxkpnzYHc1VxS1W71S43+axqA40gEFWM 5/pmP/kXFGNogFlCE070/hI1UeHAHSVc9sm01XKWq5+8SB0pP+aVGBInyzbwH0e9F+Un 4tFJymofDwo/e4scF++O4cyj8lizNzL0ipYVRr9+8VgW6r9gfLmFWtzJcr7G0IRL9z19 Obow== X-Gm-Message-State: AFqh2kpaQwXSc/wd8FqfeWTqy6jx63WlZOvwphABBQJbV0ElXu5rK6yF H3J1yDzofKXA4z91xq2YPbcEcw== X-Received: by 2002:a05:600c:4f48:b0:3d6:8570:1239 with SMTP id m8-20020a05600c4f4800b003d685701239mr1284152wmq.16.1671613452872; Wed, 21 Dec 2022 01:04:12 -0800 (PST) Received: from zen.linaroharston ([185.81.254.11]) by smtp.gmail.com with ESMTPSA id c4-20020a05600c0a4400b003cf75213bb9sm1714567wmq.8.2022.12.21.01.04.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Dec 2022 01:04:12 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id EF3DA1FFB8; Wed, 21 Dec 2022 09:04:11 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , =?utf-8?q?A?= =?utf-8?q?lex_Benn=C3=A9e?= , Thomas Huth , Wainer dos Santos Moschetta , fam@euphon.net, berrange@redhat.com, f4bug@amsat.org, pbonzini@redhat.com, stefanha@redhat.com, crosa@redhat.com, Beraldo Leal , Mukilan Thiyagarajan , Richard Henderson Subject: [PATCH v2 1/6] configure: Fix check-tcg not executing any tests Date: Wed, 21 Dec 2022 09:04:06 +0000 Message-Id: <20221221090411.1995037-2-alex.bennee@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221221090411.1995037-1-alex.bennee@linaro.org> References: <20221221090411.1995037-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Mukilan Thiyagarajan After configuring with --target-list=hexagon-linux-user running `make check-tcg` just prints the following: ``` make: Nothing to be done for 'check-tcg' ``` In the probe_target_compiler function, the 'break' command is used incorrectly. There are no lexically enclosing loops associated with that break command which is an unspecfied behaviour in the POSIX standard. The dash shell implementation aborts the currently executing loop, in this case, causing the rest of the logic for the loop in line 2490 to be skipped, which means no Makefiles are generated for the tcg target tests. Fixes: c3b570b5a9a24d25 (configure: don't enable cross compilers unless in target_list) Signed-off-by: Mukilan Thiyagarajan Reviewed-by: Richard Henderson Link: https://patchew.org/QEMU/20221207082309.9966-1-quic._5Fmthiyaga@quicinc.com/ Message-Id: <20221207082309.9966-1-quic_mthiyaga@quicinc.com> Signed-off-by: Alex Bennée --- configure | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/configure b/configure index 26c7bc5154..7a804fb657 100755 --- a/configure +++ b/configure @@ -1881,9 +1881,7 @@ probe_target_compiler() { # We shall skip configuring the target compiler if the user didn't # bother enabling an appropriate guest. This avoids building # extraneous firmware images and tests. - if test "${target_list#*$1}" != "$1"; then - break; - else + if test "${target_list#*$1}" = "$1"; then return 1 fi