From patchwork Thu Jan 5 16:43:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 639272 Delivered-To: patch@linaro.org Received: by 2002:a17:522:f3c4:b0:4b4:3859:abed with SMTP id in4csp321317pvb; Thu, 5 Jan 2023 08:45:55 -0800 (PST) X-Google-Smtp-Source: AMrXdXsrFYfwHptG9Ehbxhsb8BvK2SFQHlz24eELTIV9GuKQ897MlmdGL1CSgXXvRRRZX5sfS/ZS X-Received: by 2002:ac8:5451:0:b0:3a8:171d:2414 with SMTP id d17-20020ac85451000000b003a8171d2414mr73091464qtq.15.1672937154985; Thu, 05 Jan 2023 08:45:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672937154; cv=none; d=google.com; s=arc-20160816; b=fOY3dyRNP4ceip4ksi4sSUaE0+Kfz6pJDjDeEG3YyzhFjyOcZ97WBe3XImi5YdtBZa 9O95RwuEvcuqEqvUVg6l1wIIYhar0gIVCK8ay/KD2Hmwzon3P/7Cv8P9HZwweyPozAGr giXgAX9F8D/qZx2UasaIa3GRzXewY7i3ok9+zmwmBvoq9G9Pn5eDgg4j6K2JzE9RkTFJ 99kXCVDd4gl0euJVF4E5Mp5pnj1NcupwnAqtD5PuotQfgUXccEz17M3wNX7e/5sfwy8v nVC+WHlGXluyoAwLP4QveunXiQN/blqDNbD3IDxvAlobWVzP/yMVS6wjMUbRhBjfnBJN NRyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=8lMJgjm1DvK1wLgcUqU/S1XJA9L6jfYX3fmzxSNKcYA=; b=E7xXy28+UsgCTpQrRbMlRiw4435URelonpHXx52wNhZ6VjyBURlxSZodTA5QHOPhco /aBBuVF8jygfZPDxnrrXU9pKKReVa5ChDZcbLycdN4ErYAYFNLhNFmcYwAYmLuoT6MDc 6g4KwXd8N/AVK3VmgAtVx3XKkJ7m1MocHakvaD9pzfnIe25AtyftJxjo0iVZwJz97U2/ FF82qBSVFQVQQw2PHP/O/rgFmPQBI3i47vP7+o1Zxds5DI6IB4pbyAmtLpirzTW8jo9p 1sIOWKe4Q+R9dSaL9T2gtFBpe+hrDQMpsVAsRAhIWymxaexjcSkcSEBLWKi6YhcRuDIQ +r9g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=K9aYT+Ec; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id w37-20020a05622a192500b003a97e3eadfdsi20464729qtc.200.2023.01.05.08.45.54 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 05 Jan 2023 08:45:54 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=K9aYT+Ec; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pDTLR-0007Tl-TX; Thu, 05 Jan 2023 11:43:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pDTLO-0007Kq-OB for qemu-devel@nongnu.org; Thu, 05 Jan 2023 11:43:55 -0500 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pDTL0-00072b-8r for qemu-devel@nongnu.org; Thu, 05 Jan 2023 11:43:54 -0500 Received: by mail-wr1-x429.google.com with SMTP id co23so36730234wrb.4 for ; Thu, 05 Jan 2023 08:43:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8lMJgjm1DvK1wLgcUqU/S1XJA9L6jfYX3fmzxSNKcYA=; b=K9aYT+Ech1VA7Vzll9S5stHUFVnUBqi2CxjynyXAMpotngTRqLGLRBm+/BcaqOXz+d lGjihXtYfLk1uYVy6PymNIQ6yW3puCRhvjNI0xuIaH+xrDRG91haacTImhLwnlLc470T SqdSQPRtj+hDsA2H3d3iSJ/odVGf6wE25vJslv4qta9zV4OMP7LFaey6JtdGBfJX+ty/ 2Z/aeoXSog5TeTWPUANCAifaPNCD9IrStFGcbd4dR0efRKJLTdnLZZrHjRtZxSwaUFdJ klG144UdA8P0UFX5p6vB/juBM+A6Jb+dcxH3PI2ouimoZ9/ANupnePX8VbEkFb747sgo DdRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8lMJgjm1DvK1wLgcUqU/S1XJA9L6jfYX3fmzxSNKcYA=; b=7skLcenDTbU8aQMeC/QvULm7V9CrZ5ghI1r7cgjYXy1y9Y/NoyTxa5rSiZ/KVqHJlX 2YSiPutJdhkZK3g8IpRWKljOlhZg7nylyXYATM9+LDUWc4CxAb+seEKvgS3vpoIK1Tba n6XZGuk4OpsnPUvTTXKMF5Ul2c7RZJ0NOyO8FtM4matgz7ehhaCnFyQmq6M3tz+mh0Nv OHoVweELRHEUI7QQBivt+Qn9T7/bsFc1p7SQHO/vmqaut7Be8j1HC5CGC+JnGekZSVBi SdfJbQUK2Hjgy3Sz7GW4RaXqCQGwWbE4QafVYq1Bufg6wkE7epUTXf1C667W1Iu1oWu0 3teg== X-Gm-Message-State: AFqh2kobP68dVdEo8WafcCJyshAYod10OTS7NNqpA5kqfF1Km5EpcfCE DHuSFTHtWh8cv94lc/SMSaQAKQ== X-Received: by 2002:adf:e5c7:0:b0:270:de92:7962 with SMTP id a7-20020adfe5c7000000b00270de927962mr31319470wrn.60.1672937008513; Thu, 05 Jan 2023 08:43:28 -0800 (PST) Received: from zen.linaroharston ([185.81.254.11]) by smtp.gmail.com with ESMTPSA id h10-20020a5d4fca000000b00281eab50380sm31319287wrw.117.2023.01.05.08.43.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Jan 2023 08:43:27 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 7D4F01FFC8; Thu, 5 Jan 2023 16:43:21 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org, alex.bennee@gmail.com Cc: David Hildenbrand , Sunil Muthuswamy , Aurelien Jarno , Michael Rolnik , Aleksandar Rikalo , Greg Kurz , Ilya Leoshkevich , Thomas Huth , qemu-ppc@nongnu.org, Laurent Vivier , Max Filippov , Yanan Wang , Marek Vasut , Stafford Horne , Peter Maydell , Daniel Henrique Barboza , Palmer Dabbelt , =?utf-8?q?Alex_Benn=C3=A9e?= , Taylor Simpson , Marcel Apfelbaum , Alexandre Iooss , Chris Wulff , Richard Henderson , Eduardo Habkost , Song Gao , Mark Cave-Ayland , =?utf-8?q?C=C3=A9dric_Le_?= =?utf-8?q?Goater?= , Artyom Tarasenko , Paolo Bonzini , qemu-riscv@nongnu.org, qemu-s390x@nongnu.org, Alistair Francis , "Edgar E. Iglesias" , Bastian Koppelmann , Jiaxun Yang , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?q?=C3=A9?= , Bin Meng , Mahmoud Mandour , David Gibson , Yoshinori Sato , Xiaojuan Yang , qemu-arm@nongnu.org Subject: [PATCH v2 17/21] gdbstub: fix address type of gdb_set_cpu_pc Date: Thu, 5 Jan 2023 16:43:16 +0000 Message-Id: <20230105164320.2164095-18-alex.bennee@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230105164320.2164095-1-alex.bennee@linaro.org> References: <20230105164320.2164095-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x429.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org The underlying call uses vaddr and the comms API uses unsigned long long which will always fit. We don't need to deal in target_ulong here. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- gdbstub/gdbstub.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index c293b8e43c..4547ca3367 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -535,7 +535,7 @@ static void gdb_process_breakpoint_remove_all(GDBProcess *p) } -static void gdb_set_cpu_pc(target_ulong pc) +static void gdb_set_cpu_pc(vaddr pc) { CPUState *cpu = gdbserver_state.c_cpu; @@ -1289,7 +1289,7 @@ static void handle_file_io(GArray *params, void *user_ctx) static void handle_step(GArray *params, void *user_ctx) { if (params->len) { - gdb_set_cpu_pc((target_ulong)get_param(params, 0)->val_ull); + gdb_set_cpu_pc(get_param(params, 0)->val_ull); } cpu_single_step(gdbserver_state.c_cpu, gdbserver_state.sstep_flags);