From patchwork Mon Jan 30 21:48:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 648623 Delivered-To: patch@linaro.org Received: by 2002:a17:522:d8c:b0:4be:c3dc:14d8 with SMTP id d12csp1395633pva; Mon, 30 Jan 2023 13:52:10 -0800 (PST) X-Google-Smtp-Source: AK7set9Cfh5bvsiUvZizwsWBvWgvn3bY14Zs4Yhgb3HTl+oR7y1ZFijXlHXHV/mzmbce3yQ5BwwI X-Received: by 2002:a05:622a:15d4:b0:3a5:c851:29ff with SMTP id d20-20020a05622a15d400b003a5c85129ffmr18134208qty.23.1675115529903; Mon, 30 Jan 2023 13:52:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675115529; cv=none; d=google.com; s=arc-20160816; b=axLTm1SWp0TD19iaVDVXB38lglFrBC0fH5vGcuRKHKORnjGZ3Tfniyn6I9m1cGW9D8 AYC97yDdphGqOPUXtj1TNIzbjIalSFOTDARwsB5T5Jrsc50guqGjj+AuOhuhPn7fwYl3 WDF/QzBo3LKiG/wKA9L7xs2bFCGul9uTKJZfEJ+B3wRPIe5ozb4HZMmg5/lsNLCSt5Pr X3OqLluAV4KQijvAckk3mqB5AqKQnqGsAefyJJYh84bRCj5KEG1oBsJgK5THLgzLxJJZ eixO1BSVy2VpuvGLN6qAcZifajvz3X8qKZux8yg2zb/N+CEyaIkcASM299IZryMCRUr7 FXcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=CJH1k0t5A6W0zvw0UVl/f2Kw3cu3hBI6bpM0JqIs/cA=; b=PkX/+u1qZZ9s6HUcVwMlYNucdKcmAToUZqMFtxS0iISnTsNtVFklHPsC41M9jf9y0+ v4n3v4KFzdt+MtM7SOF/KEEuV4J3ioo7FcvoR8DMqIgWPRx6hEKtHiWHVmy+LQ8uvTta zmYj9W2ILUHJ5AQUOzDFYLGu23y6K/j2MaHuF3iTqCUcKsc6Tk4CBKPNT6XAHt22v020 hM+taNMVTLCHZdSojvVQxUfZhoH9g3VHE31tNjtbWKIEXlLNv6mvuMooBj5IiKTITw2U KXS+OC1JsyheBBpolEG8SGjwX4fxTQiY15oPXrjbEoIU1FoT4NS8JC1Trcm+ER5Yotsj ixeA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=dQlgfuPx; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id u65-20020a376044000000b006ea237e4418si7539461qkb.182.2023.01.30.13.52.09 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Jan 2023 13:52:09 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=dQlgfuPx; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pMc1a-0001xf-Jt; Mon, 30 Jan 2023 16:49:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMc1Y-0001xF-Rm for qemu-devel@nongnu.org; Mon, 30 Jan 2023 16:49:12 -0500 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pMc1X-0005dH-6D for qemu-devel@nongnu.org; Mon, 30 Jan 2023 16:49:12 -0500 Received: by mail-pl1-x62e.google.com with SMTP id k13so13158152plg.0 for ; Mon, 30 Jan 2023 13:49:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CJH1k0t5A6W0zvw0UVl/f2Kw3cu3hBI6bpM0JqIs/cA=; b=dQlgfuPxHJo0Vz0jZwmpyXTN+I0LjNLda+hdl4zNwIkj4YdEMTjy01QOGt5MqrryC9 s67tZOeijGeCRm94R75TwoPCXGG7phj2GbYNOtMWuAs4+3/aA+2nb6IWacbVlJVo4nyo 2QM5+/6thoEvyo1eyswwtSvSjnACuQJCjWrk5+ba/z7ewNyE+oXpuy+1L5X818QuPred aofDtFEubs49jr251Zjwe18HR3JHUAjlah/ogoKafmYKRSTtpAmwBoAHMV9WqegouYTF NJpLBZT+oUedV/uJla3zd7CKaj3YvBKFS6WItSqhb1SC9stdZQt2pldWeRUMiViT8fAJ vybw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CJH1k0t5A6W0zvw0UVl/f2Kw3cu3hBI6bpM0JqIs/cA=; b=uELo6hk/I7DmTVrR8+n8uJ0Xqoe55MR1nqQ8Tf3VVM52q4k3HhiB7vhl/mcqgX+aa8 teTY8A8tHd6Vi+NG9KwFZYL8fTktRZyEShKx79kjGntyGSGHh2+8so518c+/op6x4suH tdz/KIW44bhOW6L8T9ncGZKc2fVvOGIYu31x0r/ECFU/iuvMKOOas1At4gvtFD4hPDOl GPwA/+sMEzndsZAtfVywZpJkdk4HTDQq9Zt+KvoiCdaVoaDI/4osfHu5sKBDy2OSYxMv SXT+99pX5xO78o5Oi7bRVictq9DpFUESPfAQCjUsnN63Puq1ZhkfEKIvJwAYY4zzPZEt GCrA== X-Gm-Message-State: AO0yUKUbIpU0A590xxvEZH5tuYlhOZzshigzZTwR0puq1whRD6A5cpb7 5kcIP/mfHy5T97DUMGtAPkz0856vbk7OWHjQ X-Received: by 2002:a17:90a:19c8:b0:228:a39c:8d11 with SMTP id 8-20020a17090a19c800b00228a39c8d11mr11944527pjj.1.1675115349838; Mon, 30 Jan 2023 13:49:09 -0800 (PST) Received: from stoup.. (rrcs-173-197-98-118.west.biz.rr.com. [173.197.98.118]) by smtp.gmail.com with ESMTPSA id t4-20020a17090ad14400b00219220edf0dsm7451215pjw.48.2023.01.30.13.49.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jan 2023 13:49:09 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: alex.bennee@linaro.org, philmd@linaro.org Subject: [PATCH v6 13/36] tcg: Add temp allocation for TCGv_i128 Date: Mon, 30 Jan 2023 11:48:21 -1000 Message-Id: <20230130214844.1158612-14-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230130214844.1158612-1-richard.henderson@linaro.org> References: <20230130214844.1158612-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::62e; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org This enables allocation of i128. The type is not yet usable, as we have not yet added data movement ops. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée --- include/tcg/tcg.h | 32 +++++++++++++++++++++++++ tcg/tcg.c | 60 +++++++++++++++++++++++++++++++++-------------- 2 files changed, 74 insertions(+), 18 deletions(-) diff --git a/include/tcg/tcg.h b/include/tcg/tcg.h index 8b7e61e7a5..7a8e4bbdd7 100644 --- a/include/tcg/tcg.h +++ b/include/tcg/tcg.h @@ -685,6 +685,11 @@ static inline TCGTemp *tcgv_i64_temp(TCGv_i64 v) return tcgv_i32_temp((TCGv_i32)v); } +static inline TCGTemp *tcgv_i128_temp(TCGv_i128 v) +{ + return tcgv_i32_temp((TCGv_i32)v); +} + static inline TCGTemp *tcgv_ptr_temp(TCGv_ptr v) { return tcgv_i32_temp((TCGv_i32)v); @@ -705,6 +710,11 @@ static inline TCGArg tcgv_i64_arg(TCGv_i64 v) return temp_arg(tcgv_i64_temp(v)); } +static inline TCGArg tcgv_i128_arg(TCGv_i128 v) +{ + return temp_arg(tcgv_i128_temp(v)); +} + static inline TCGArg tcgv_ptr_arg(TCGv_ptr v) { return temp_arg(tcgv_ptr_temp(v)); @@ -726,6 +736,11 @@ static inline TCGv_i64 temp_tcgv_i64(TCGTemp *t) return (TCGv_i64)temp_tcgv_i32(t); } +static inline TCGv_i128 temp_tcgv_i128(TCGTemp *t) +{ + return (TCGv_i128)temp_tcgv_i32(t); +} + static inline TCGv_ptr temp_tcgv_ptr(TCGTemp *t) { return (TCGv_ptr)temp_tcgv_i32(t); @@ -851,6 +866,11 @@ static inline void tcg_temp_free_i64(TCGv_i64 arg) tcg_temp_free_internal(tcgv_i64_temp(arg)); } +static inline void tcg_temp_free_i128(TCGv_i128 arg) +{ + tcg_temp_free_internal(tcgv_i128_temp(arg)); +} + static inline void tcg_temp_free_ptr(TCGv_ptr arg) { tcg_temp_free_internal(tcgv_ptr_temp(arg)); @@ -899,6 +919,18 @@ static inline TCGv_i64 tcg_temp_local_new_i64(void) return temp_tcgv_i64(t); } +static inline TCGv_i128 tcg_temp_new_i128(void) +{ + TCGTemp *t = tcg_temp_new_internal(TCG_TYPE_I128, false); + return temp_tcgv_i128(t); +} + +static inline TCGv_i128 tcg_temp_local_new_i128(void) +{ + TCGTemp *t = tcg_temp_new_internal(TCG_TYPE_I128, true); + return temp_tcgv_i128(t); +} + static inline TCGv_ptr tcg_global_mem_new_ptr(TCGv_ptr reg, intptr_t offset, const char *name) { diff --git a/tcg/tcg.c b/tcg/tcg.c index 0a4ad99a12..fee96b3d9c 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -1273,26 +1273,45 @@ TCGTemp *tcg_temp_new_internal(TCGType type, bool temp_local) tcg_debug_assert(ts->base_type == type); tcg_debug_assert(ts->kind == kind); } else { + int i, n; + + switch (type) { + case TCG_TYPE_I32: + case TCG_TYPE_V64: + case TCG_TYPE_V128: + case TCG_TYPE_V256: + n = 1; + break; + case TCG_TYPE_I64: + n = 64 / TCG_TARGET_REG_BITS; + break; + case TCG_TYPE_I128: + n = 128 / TCG_TARGET_REG_BITS; + break; + default: + g_assert_not_reached(); + } + ts = tcg_temp_alloc(s); - if (TCG_TARGET_REG_BITS == 32 && type == TCG_TYPE_I64) { - TCGTemp *ts2 = tcg_temp_alloc(s); + ts->base_type = type; + ts->temp_allocated = 1; + ts->kind = kind; - ts->base_type = type; - ts->type = TCG_TYPE_I32; - ts->temp_allocated = 1; - ts->kind = kind; - - tcg_debug_assert(ts2 == ts + 1); - ts2->base_type = TCG_TYPE_I64; - ts2->type = TCG_TYPE_I32; - ts2->temp_allocated = 1; - ts2->temp_subindex = 1; - ts2->kind = kind; - } else { - ts->base_type = type; + if (n == 1) { ts->type = type; - ts->temp_allocated = 1; - ts->kind = kind; + } else { + ts->type = TCG_TYPE_REG; + + for (i = 1; i < n; ++i) { + TCGTemp *ts2 = tcg_temp_alloc(s); + + tcg_debug_assert(ts2 == ts + i); + ts2->base_type = type; + ts2->type = TCG_TYPE_REG; + ts2->temp_allocated = 1; + ts2->temp_subindex = i; + ts2->kind = kind; + } } } @@ -3381,9 +3400,14 @@ static void temp_allocate_frame(TCGContext *s, TCGTemp *ts) case TCG_TYPE_V64: align = 8; break; + case TCG_TYPE_I128: case TCG_TYPE_V128: case TCG_TYPE_V256: - /* Note that we do not require aligned storage for V256. */ + /* + * Note that we do not require aligned storage for V256, + * and that we provide alignment for I128 to match V128, + * even if that's above what the host ABI requires. + */ align = 16; break; default: