From patchwork Mon Jan 30 21:48:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 648610 Delivered-To: patch@linaro.org Received: by 2002:a17:522:d8c:b0:4be:c3dc:14d8 with SMTP id d12csp1394864pva; Mon, 30 Jan 2023 13:49:56 -0800 (PST) X-Google-Smtp-Source: AMrXdXsbN/b0oA/8SV9ADQ+OVg180PgfTL1VlyaA7K4GN4PwbUrj3tzU9Lj+PUZK4nAmOMj3UQF5 X-Received: by 2002:ad4:4983:0:b0:534:9c81:2c15 with SMTP id u3-20020ad44983000000b005349c812c15mr69752348qvx.3.1675115396065; Mon, 30 Jan 2023 13:49:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675115396; cv=none; d=google.com; s=arc-20160816; b=qNAKHY105VEZtoxhyZ/UDa6GOzQrn329LysL+LjZHtyKsVmREuDs5jB8j5Hcp5lPst 6mYpsTfiVRPT/AujICNvLMGhYGrP+eIaoccpaUm5DhV//JGPSHoljMUIwA3V+yStpT7J hBbDM5I99yNTrtgD0DxuzaTQJAE3uZNAwikCTf6Z8Zh0gGqc5Ff8TmNaQGc+QDy+MgSE iIgBRO8VXrmNAzNfnzPZiGT2zkgaITyrOYklgL++QxTV+q+QlXbOhgabreFoJGog8a/j Waeo42jKy/wQ8oEyl5Li6MgMNKcco8Ash3/Uc5ZmJwYIc2hPEP2KYQqOpXOHDhfD+Asd ZNvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=+sAayCS/0n8o12l1+Nu9dY41aCtQpJmApolHzbMbLL8=; b=S0ceErkZIKi09UGJs6sDxZr2W4MGpSf3OZwiEwcBsjUw+XihxFbU+SQJJ9SaJnpWaI qfb70lWrbd6OpnnpKVBPlWG5EW09+g1DpHdRgLocoXJKo9qzUTZFtMgr8y6ShfXJhTW/ azLJvtJ8fT72TAzy0ehq6CkvjUSzDVIK8j1CX6X4wPFAtMAkJvl1YKBJiGs83Q/zqCgL L1SzMmchczgO1lUrR8IA8V0LjJgNEaCG95pAT8qBfXhzzOGt7zJl3S/CN3L1i8MoOkG6 HDZhAjUOfmLjMHOWY5SlgbanprbzK4HGWw4H13aDl6gjaEuvQ4Pgh6elPdsMmGyXynEo aAZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=tUh80N8u; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id dr17-20020a05621408f100b0053432250abesi6490102qvb.210.2023.01.30.13.49.55 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Jan 2023 13:49:56 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=tUh80N8u; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pMc1K-0001sD-Jo; Mon, 30 Jan 2023 16:48:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMc1I-0001rQ-0z for qemu-devel@nongnu.org; Mon, 30 Jan 2023 16:48:56 -0500 Received: from mail-pj1-x1035.google.com ([2607:f8b0:4864:20::1035]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pMc1G-0005a1-85 for qemu-devel@nongnu.org; Mon, 30 Jan 2023 16:48:55 -0500 Received: by mail-pj1-x1035.google.com with SMTP id e10-20020a17090a630a00b0022bedd66e6dso16975198pjj.1 for ; Mon, 30 Jan 2023 13:48:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+sAayCS/0n8o12l1+Nu9dY41aCtQpJmApolHzbMbLL8=; b=tUh80N8uFJZClUMRZfqZukluYyq8gN4eLL3YXKy0ksYbFzfXSSN6JNsVEZvmOdMMCV cQpN83guKaTLOJuY1kK0iRrCkwSYXo4xI4mUUsFVl98jo3owyGyGaMrxXKpWJlvIRyEu Cw61FN/+vEWaskhsF6BgeBDUmAFbF7Gha9E+abXamKVM9P8eh1eN0mRXTCv553/P9vB5 rg12Z075FGkG4RBwzT46CoFGP86C22Ih205cC1Tp29P6xLuY3wSPDzVWKHvnWemwFnGQ lkpTNHT4OD2t246oODPkwhpOcGEfGe9QueavKWJGedZiRZYKVITPivuli7T7J6YYdWet bqxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+sAayCS/0n8o12l1+Nu9dY41aCtQpJmApolHzbMbLL8=; b=BDQp6bld6vMazqotZYKyeaFNPu8FpQKkoMoCZg0fzxuEc2oS1AKKoF5IPJKZciNOY9 wip/Pt/5I0viU/xnWdUta5Kk8NSevrC5EaIsNrJQ9fxa4x22fuF8ILklvzqDkWqnCpc+ MRMbvwbe668RTGCUOGc9dnr38Tq8Hqa5c0cDrgHU1tqKgGOMosOUpdCwbAv85p7PV3PQ FTyBzx5mSyXt9LhRZfVt3bakUJbpF+Pb/iCkGz7NmU59pHAD4+DGUbJCfF7x2AIXair9 cJBP/8VCcWFe6GDDhsQIYb+TqF4gkG4ZHlPsYZPQqWgZmfcLVUwNNgsQ3G8xglwq9y5n 0QKA== X-Gm-Message-State: AO0yUKVKMK9tTvR0T8ocZ/1fB0KsNp2+9f0nxtPEbShRF7mRl7/ZhkzE HvotiyOrc9pQauAs7oWB6BsNIw6ief/vYnZH X-Received: by 2002:a17:90b:33ce:b0:22b:ec81:c36c with SMTP id lk14-20020a17090b33ce00b0022bec81c36cmr26846711pjb.45.1675115332671; Mon, 30 Jan 2023 13:48:52 -0800 (PST) Received: from stoup.. (rrcs-173-197-98-118.west.biz.rr.com. [173.197.98.118]) by smtp.gmail.com with ESMTPSA id t4-20020a17090ad14400b00219220edf0dsm7451215pjw.48.2023.01.30.13.48.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jan 2023 13:48:52 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: alex.bennee@linaro.org, philmd@linaro.org Subject: [PATCH v6 02/36] tcg: Handle dh_typecode_i128 with TCG_CALL_{RET, ARG}_NORMAL Date: Mon, 30 Jan 2023 11:48:10 -1000 Message-Id: <20230130214844.1158612-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230130214844.1158612-1-richard.henderson@linaro.org> References: <20230130214844.1158612-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::1035; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1035.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Many hosts pass and return 128-bit quantities like sequential 64-bit quantities. Treat this just like we currently break down 64-bit quantities for a 32-bit host. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- tcg/tcg.c | 37 +++++++++++++++++++++++++++++++++---- 1 file changed, 33 insertions(+), 4 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index d502327be2..ffddda96ed 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -707,11 +707,22 @@ static void init_call_layout(TCGHelperInfo *info) case dh_typecode_s64: info->nr_out = 64 / TCG_TARGET_REG_BITS; info->out_kind = TCG_CALL_RET_NORMAL; + assert(info->nr_out <= ARRAY_SIZE(tcg_target_call_oarg_regs)); + break; + case dh_typecode_i128: + info->nr_out = 128 / TCG_TARGET_REG_BITS; + info->out_kind = TCG_CALL_RET_NORMAL; /* TODO */ + switch (/* TODO */ TCG_CALL_RET_NORMAL) { + case TCG_CALL_RET_NORMAL: + assert(info->nr_out <= ARRAY_SIZE(tcg_target_call_oarg_regs)); + break; + default: + qemu_build_not_reached(); + } break; default: g_assert_not_reached(); } - assert(info->nr_out <= ARRAY_SIZE(tcg_target_call_oarg_regs)); /* * Parse and place function arguments. @@ -733,6 +744,9 @@ static void init_call_layout(TCGHelperInfo *info) case dh_typecode_ptr: type = TCG_TYPE_PTR; break; + case dh_typecode_i128: + type = TCG_TYPE_I128; + break; default: g_assert_not_reached(); } @@ -772,6 +786,19 @@ static void init_call_layout(TCGHelperInfo *info) } break; + case TCG_TYPE_I128: + switch (/* TODO */ TCG_CALL_ARG_NORMAL) { + case TCG_CALL_ARG_EVEN: + layout_arg_even(&cum); + /* fall through */ + case TCG_CALL_ARG_NORMAL: + layout_arg_normal_n(&cum, info, 128 / TCG_TARGET_REG_BITS); + break; + default: + qemu_build_not_reached(); + } + break; + default: g_assert_not_reached(); } @@ -1690,11 +1717,13 @@ void tcg_gen_callN(void *func, TCGTemp *ret, int nargs, TCGTemp **args) op->args[pi++] = temp_arg(ret); break; case 2: + case 4: tcg_debug_assert(ret != NULL); - tcg_debug_assert(ret->base_type == ret->type + 1); + tcg_debug_assert(ret->base_type == ret->type + ctz32(n)); tcg_debug_assert(ret->temp_subindex == 0); - op->args[pi++] = temp_arg(ret); - op->args[pi++] = temp_arg(ret + 1); + for (i = 0; i < n; ++i) { + op->args[pi++] = temp_arg(ret + i); + } break; default: g_assert_not_reached();