From patchwork Fri Feb 3 14:55:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 650080 Delivered-To: patch@linaro.org Received: by 2002:a17:522:d8c:b0:4be:c3dc:14d8 with SMTP id d12csp863821pva; Fri, 3 Feb 2023 06:58:47 -0800 (PST) X-Google-Smtp-Source: AK7set/fmrxhqAhwAk7IW16onTP+ZVECQuCLVD9Qfhk+kYExibUGAKnX9Cc0Rsshr+KylH4ehC4/ X-Received: by 2002:a0c:a918:0:b0:53b:8b22:6e77 with SMTP id y24-20020a0ca918000000b0053b8b226e77mr15315773qva.51.1675436327559; Fri, 03 Feb 2023 06:58:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675436327; cv=none; d=google.com; s=arc-20160816; b=QNl+oCXOYV0JGC8io0WwXE1EBu6K2omKx1rAoor9JoWbtqCJt3xB2V7iG3284Iw3G/ deWdbc5eH0IJi7z0oUEEf7rRiff+cyr+3bGjMeI4lHx1OQrG9kUtoqlqWsztDdnWiMUg h9wz22llUcBQBcflxGgVyu4UV7IfmUPeJ2L0TDqTrLqOsbSpHFQxuAqkQ8YvsVYiCYUu 8PeIsEeAK77bIgezo4lxXdOFwNY4H2lXJ6p6iEg71baSaRjsno4CVBnjn4xj79Ffzfvj XkQYhqokPuKUsLmTNcvJ7Gxm2gEjdfnN52rAQuBMx4LBylRyjugxaonyV0CB3oMqhxfr 19hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=B9zIETZDw8AzAYdvOUdcE4GWKCA1zFcGWd3/PyGieuU=; b=dT6jhxGKs6C4B40QPanawkZdDa38cJaME/spd9tZksGoVqFbShF7UTw6V9X0+CTzCo RXEwYY9l58pqW8pdwVDB+KbzIgpcVQLJ8XpY7q78Uw75v4lGbvoF3rEOTyqXzH9HIfJa om2vJHcY+Si3iqVOvulL6DepNXgeOWJ5jGniUYBwAINUqaWjsRPKMv63qZyQTeKIR6jo Foytt3HLcSVgPyIQv/MbSyY0wjsXNClwBepFH4wYMDy6q9x6qpVUQbwoRajvFqrVdFKF 8491SJVsg5mrqOHZX1IKmnISaTKyuypNsWTZMtqc1xqk2oX79rx0Tj1ZPUvrVPMv4z1O QACQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=pTmP2R7B; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d2-20020a0ce702000000b004c791803422si1785270qvn.5.2023.02.03.06.58.47 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 03 Feb 2023 06:58:47 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=pTmP2R7B; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pNxU6-0002Ik-E3; Fri, 03 Feb 2023 09:56:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNxU4-0002Dc-IH for qemu-devel@nongnu.org; Fri, 03 Feb 2023 09:56:12 -0500 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pNxU2-0005wG-Ld for qemu-devel@nongnu.org; Fri, 03 Feb 2023 09:56:12 -0500 Received: by mail-wm1-x334.google.com with SMTP id k16so4070687wms.2 for ; Fri, 03 Feb 2023 06:56:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=B9zIETZDw8AzAYdvOUdcE4GWKCA1zFcGWd3/PyGieuU=; b=pTmP2R7B+z3eAJyd3o7EP53hEHnMbEhT84NZtKZwHlAz9ttqI/z/DmEyUTgurqhh2V zGBMtS0GEt0auuCAQL0m8tP0Lp4Qk8+4vJzHmNwWSWWpdYqXXHZkGmXZlDvvewCzyujF DWUHfZ0w7ZprzF7Ux9bA9IvTR4RgYvKCl/gtJWQauqPb1d9pyWMXUIrCTOWzl4lL41RY wUHyyXN8DnHGFHUFOdqBEGGS3h3lbridfsAwaG3NaHzxfH0UxoagYe0o1SWznXFo2cni D0XXC6sSNc+zQetYEMVAFet7mzYDeJvDLt6VEH3ml3zhfvW/dFslzqE3ODRAiprAVa8k 1XJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=B9zIETZDw8AzAYdvOUdcE4GWKCA1zFcGWd3/PyGieuU=; b=Ufd3oTOVEuwYEB+oV9e/L1AiV2WXPko6chMu4fdxalgfDKMPWWmHkaDXxYaShLwZAc eMgCuRCp0PpCzNNPgykFvmHcI4mK2JzHUGCNlPIHEZcZFM6wpeCtbQRdXpj+wcfqr8VI 9CcJdK+rszUc9iyXmJT93PkiL1nq87F2jec5UBXp0GLA+Nc2Sw+eIjlsyLlpjng+XA+1 srgdRxdaxEMwI/vc8jqJjOvWGZbYGBiYaIyiJ7PdmgNItaoQN9uJvx794zi8YpqD826Q sS94KSD4SHXSHTksFtgkabIQWjCB7MwTRnbGrBWOLemGCq+CSqrnlMmPIUv26LhdRfLb kykA== X-Gm-Message-State: AO0yUKVJ57sXemrf5PkMrXwnQwx8pIXLJGBNMgf8bju5etit3ZWDbkKD SqcXdWeaQWGyrvzouz/7a3fpydBRwdlXPjQ0 X-Received: by 2002:a05:600c:46ce:b0:3df:e1d1:e14c with SMTP id q14-20020a05600c46ce00b003dfe1d1e14cmr6897203wmo.20.1675436169010; Fri, 03 Feb 2023 06:56:09 -0800 (PST) Received: from localhost.localdomain ([81.0.6.76]) by smtp.gmail.com with ESMTPSA id t6-20020a05600c450600b003dc433bb5e1sm3251692wmo.9.2023.02.03.06.56.08 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 03 Feb 2023 06:56:08 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Markus Armbruster , qemu-arm@nongnu.org, qemu-ppc@nongnu.org, Eduardo Habkost , =?utf-8?q?Phili?= =?utf-8?q?ppe_Mathieu-Daud=C3=A9?= , BALATON Zoltan Subject: [PATCH v2 06/15] hw/ppc/sam460ex: Correctly set MAL properties Date: Fri, 3 Feb 2023 15:55:27 +0100 Message-Id: <20230203145536.17585-7-philmd@linaro.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230203145536.17585-1-philmd@linaro.org> References: <20230203145536.17585-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=philmd@linaro.org; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org MAL properties are declared as uint8_t: static Property ppc4xx_mal_properties[] = { DEFINE_PROP_UINT8("txc-num", Ppc4xxMalState, txcnum, 0), DEFINE_PROP_UINT8("rxc-num", Ppc4xxMalState, rxcnum, 0), DEFINE_PROP_END_OF_LIST(), }; Correct the API use by setting the property using qdev_prop_set_uint8(). No behavioral change. Fixes: da116a8aab ("ppc/ppc405: QOM'ify MAL") Reviewed-by: BALATON Zoltan Signed-off-by: Philippe Mathieu-Daudé --- hw/ppc/sam460ex.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ppc/sam460ex.c b/hw/ppc/sam460ex.c index 4a22ce3761..cf065aae0e 100644 --- a/hw/ppc/sam460ex.c +++ b/hw/ppc/sam460ex.c @@ -389,8 +389,8 @@ static void sam460ex_init(MachineState *machine) /* MAL */ dev = qdev_new(TYPE_PPC4xx_MAL); - qdev_prop_set_uint32(dev, "txc-num", 4); - qdev_prop_set_uint32(dev, "rxc-num", 16); + qdev_prop_set_uint8(dev, "txc-num", 4); + qdev_prop_set_uint8(dev, "rxc-num", 16); ppc4xx_dcr_realize(PPC4xx_DCR_DEVICE(dev), cpu, &error_fatal); object_unref(OBJECT(dev)); sbdev = SYS_BUS_DEVICE(dev);