From patchwork Mon Feb 13 17:01:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 653204 Delivered-To: patch@linaro.org Received: by 2002:adf:f90f:0:0:0:0:0 with SMTP id b15csp2527293wrr; Mon, 13 Feb 2023 09:04:45 -0800 (PST) X-Google-Smtp-Source: AK7set/lCNCqVAItNPYmdK6fvUXSpuQgZ9rf1k+458/vbfgUboBrKjnNocYp6BspMyoz8wFDGzzt X-Received: by 2002:a05:651c:103a:b0:293:4ffa:a697 with SMTP id w26-20020a05651c103a00b002934ffaa697mr794153ljm.16.1676307885123; Mon, 13 Feb 2023 09:04:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676307885; cv=none; d=google.com; s=arc-20160816; b=TyehRiTiXDnspm9wn7V9cqUl1hlYUXcsE21NJbkUCLq664rxUOSrWlNcOb8Dpxo0jY xzC4NpzZEHCU5/pOR1IWj8rG6AqQig15/uZ9xAZfLKJ37Oi52zX4kujVkPwFMC4B98+6 VQ0Q4pOvrCD5WXVQYgLgUYYramNIjewtRp8j+sc1LfsDI6iivnOUoNum3z9KEJpbaMwi Y1Om9zV1h6MnFBOWiEBGeatkO28qygR4WvjgjdZ2fFKs8bpBxqxDUNrbVNM+iifP73x9 OQzz4wDoNmHJTVgus9RKGXKiPExXIPnQqLz6NIMtB/t5mY2YY0jnewNPhxDk5j42u3Tg Ts+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=mhQReXuPG7LsDYOszlFQ0XTN6zBYBgflQ/Ni/g9nugY=; b=MbkUuPknW+5PpGgDy2qfa4bjdPyYG6J3bkA+IYohQTd87AhgZJNxR+SYcVeMUoqUdb crWvBv9nHehNbNWKWg+U0WZnk4iZLUNUwb1H2ejoD1ytql9QJE1OZx13deU5z1yLzI+T ByHpSNFBn/Tc8x065DNt5vLn7FvRBhkWva/3oSzXH1HqAT6Js1ODY3Qy4RhgKyIhw5UV 3I+j1kgsGQbbModW0xhUUK6tD1GCBdVQtWQra6UmcwnMRLEdtOfB/9hccw71EslfpY2x Uv/kgvuJ3yfUhBycfy+tEguaD9dP/Js/ModNhFUAaXsZu7hZtEOVOg75yOtdNvhQctlD StXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PVQlHk5C; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id v18-20020a2e7a12000000b0028fd04829fdsi5182327ljc.372.2023.02.13.09.04.45 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 13 Feb 2023 09:04:45 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PVQlHk5C; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pRcEB-00041F-P2; Mon, 13 Feb 2023 12:02:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRcDc-0002t2-17 for qemu-devel@nongnu.org; Mon, 13 Feb 2023 12:02:24 -0500 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pRcDa-0007aQ-Dg for qemu-devel@nongnu.org; Mon, 13 Feb 2023 12:02:19 -0500 Received: by mail-wm1-x32b.google.com with SMTP id n13so9159020wmr.4 for ; Mon, 13 Feb 2023 09:02:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mhQReXuPG7LsDYOszlFQ0XTN6zBYBgflQ/Ni/g9nugY=; b=PVQlHk5CCxg2psY8mGo33PLjxMr9uLpq8lymGXIvXO+1rZSGRJ3/fTpYOaiakX7jMW ppVxBYvyyTKJ8DaVmvWJyHCacuVL6ga5cmAdZsU66J7F47pLxUsVyDWAE6pCM+JvGD9v vvevjqzAtD0Rv7jaGWmUYSpbJcXvgAqXzvmvy78SRItij0fjHZv969KefXDCVbWyHqY8 BvAI8kGEpxHrOhB6d2g6Q9C6jmmY+eAWBPwmHB7z2Mle/9HwWTaDIHNPWFq56T/5Rg5C mjYxhF0lEscgTNgw3ZVIuEq1gqdkTDFNLdklrLEZAY71OXmv1ijCKU5l1mhrRWbmmm4r 4TxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mhQReXuPG7LsDYOszlFQ0XTN6zBYBgflQ/Ni/g9nugY=; b=hvvrioMV5/EeuxMET1LRsU6uPzrY103G17xPnHcuuh7Ot1wxT8TqQ92TLuZiVdjnwg AhJ6NZR+ndFxIXTBgS+d0omQxA0tjCFIePKZgKWSoj+YnBgRv+6vrM7sSePT1s+NPrEw XJFkpXTeoqgPNxPbztyX+jOMEsNuExCKtINQXp9vzJGhWLoKalyA+Zlw5M1ajvcQnwgD oKuLGm3W+ipVNejrOpgiwpjinFVYxrmMRfuwHe/TJfs8YRNYLKd/t4CK+9SSCkIyEUaO SbqOzmVA72+3OytA7+XTxKPbFHgBF25NuASMMr4o1qDtTDuL4njIsEr2cicW7NvKN254 a6fA== X-Gm-Message-State: AO0yUKXpGJ/wJ4qQQOUOVTNm5H9O2LDo7gkSF+4ew+JHLcvMR/sFOQJy wPCVcvNrpsizwF+ywqyyjl4AWQ== X-Received: by 2002:a05:600c:755:b0:3dc:443e:4212 with SMTP id j21-20020a05600c075500b003dc443e4212mr19463252wmn.1.1676307737699; Mon, 13 Feb 2023 09:02:17 -0800 (PST) Received: from localhost.localdomain ([81.0.6.76]) by smtp.gmail.com with ESMTPSA id f24-20020a05600c491800b003dc0cb5e3f1sm13592881wmp.46.2023.02.13.09.02.16 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 13 Feb 2023 09:02:17 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: Eduardo Habkost , Eric Farman , qemu-devel@nongnu.org Cc: Richard Henderson , qemu-s390x@nongnu.org, Alex Williamson , David Hildenbrand , Thomas Huth , Matthew Rosato , Christian Borntraeger , Halil Pasic , Ilya Leoshkevich , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH v3 5/6] hw/vfio/ccw: Remove pointless S390CCWDevice variable Date: Mon, 13 Feb 2023 18:01:44 +0100 Message-Id: <20230213170145.45666-6-philmd@linaro.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230213170145.45666-1-philmd@linaro.org> References: <20230213170145.45666-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=philmd@linaro.org; helo=mail-wm1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org QOM parenthood relationship is: VFIOCCWDevice -> S390CCWDevice -> CcwDevice -> DeviceState No need to double-cast, call CCW_DEVICE() on VFIOCCWDevice. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Eric Farman --- hw/vfio/ccw.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/vfio/ccw.c b/hw/vfio/ccw.c index 2ea7b4a63c..cd66b66742 100644 --- a/hw/vfio/ccw.c +++ b/hw/vfio/ccw.c @@ -314,8 +314,7 @@ static void vfio_ccw_io_notifier_handler(void *opaque) { VFIOCCWDevice *vcdev = opaque; struct ccw_io_region *region = vcdev->io_region; - S390CCWDevice *cdev = S390_CCW_DEVICE(vcdev); - CcwDevice *ccw_dev = CCW_DEVICE(cdev); + CcwDevice *ccw_dev = CCW_DEVICE(vcdev); SubchDev *sch = ccw_dev->sch; SCHIB *schib = &sch->curr_status; SCSW s;