From patchwork Mon Feb 20 11:51:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 655076 Delivered-To: patch@linaro.org Received: by 2002:adf:9bcd:0:0:0:0:0 with SMTP id e13csp1349021wrc; Mon, 20 Feb 2023 03:52:01 -0800 (PST) X-Google-Smtp-Source: AK7set85DWa37/MtaNXwP8yVuSHjEQhzH3QEH7nppubaEkoeYlrgaQaHE/zmQJYYGiDOMXyG7cjx X-Received: by 2002:a05:6214:1941:b0:56e:b16d:ec93 with SMTP id q1-20020a056214194100b0056eb16dec93mr402810qvk.4.1676893920963; Mon, 20 Feb 2023 03:52:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676893920; cv=none; d=google.com; s=arc-20160816; b=J5+I/QopNb/qO1MjgnamBGAIgkxwiD5zzQnFnVnQ83CwWlnUi2WyrYgyZmonLonqPt Cc/YML7PjOe2vQQWLfuwx1T5rF1ICv+F1wYJAjf2kGHxopvV2F8YhE1Yt1UFQi40qNvQ mlIVpc4EupsdkfFENUeN7Q/cZBn9qeUpxSvNOcYIQPj595pTxJJvY7uFocdVGeWCTk7F 450kp+FJhTYHWOB6FXRWUzbLPQHXN+2ABY2WDBnWgRnYSD0MQ2bX+oK/MBEoG6m9ZaC9 VC107/OwJ1eNRrJAbZwtkYr1NQJO4d6JNV+lnRECbSL83hWg+obsLhWWW1Q60Rak3ppu rZDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=t8xMWpWXatWsCS1MK+NnKnpC4b3JmUSx4NHWxDCryRg=; b=KxCl2oycgVoSmLUJED2A4iQDpKvqHCTETma3BG6miu+TCdyD1f+7EvSI9NNb8COpic VrUmlykq/JU8C0vfhCm7LhTL86MzveYwCoRSUS2WMLNynG6YSc05QPm+GIqhCE/vP/sV FXkdwWo6nynFbgcAFTnAiAWjFr9v0Tu7s/y/VHCFp/P4RbqT0+EaOomLbHWbXmGb0h/l xEpPr0+BS3ZdGdZKowgckeI+rZB45q+/DCiOkbSrhufb99kDIE9CUg81jTrmLJzQsBlr AmRCUlSSmHWk7cg3AIduJ4bwRjuB4f1bQwz7cfnD0HMcm/BIVgVcsZXHgc8LZTJNyAn7 7+ng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=br9d2h2t; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id q30-20020a05620a025e00b0073bcf9a8a0esi6012799qkn.715.2023.02.20.03.52.00 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 20 Feb 2023 03:52:00 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=br9d2h2t; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pU4hb-0001dq-VX; Mon, 20 Feb 2023 06:51:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pU4hZ-0001cA-Nw for qemu-devel@nongnu.org; Mon, 20 Feb 2023 06:51:25 -0500 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pU4hX-00055X-Im for qemu-devel@nongnu.org; Mon, 20 Feb 2023 06:51:25 -0500 Received: by mail-wr1-x42e.google.com with SMTP id c12so866639wrw.1 for ; Mon, 20 Feb 2023 03:51:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=t8xMWpWXatWsCS1MK+NnKnpC4b3JmUSx4NHWxDCryRg=; b=br9d2h2t5NT/HK2RCMGPGHRjVsTeYZsNSP5DvLhVmnAiRQnxCcx3YMlYjfi8obyMLL MUR5yPYHp1Elgn77COhdHaN6/M0gHxIlOV85PDNAgb6vpqT5FA70XDKY860RUQPwYIG6 F5nq4/tX/twEAF4afZUkO1MW4yMe4oyXF6CAL7fqCweD1vpwlHC3X41FOpX6lI0qklPr u+0AorwaZjDRFlJ3n/U85ifZEzh8HEmrMG3Hx1uoQK6VumbfDw0A6tYF3f0BzcXYEpZJ REblfhG40Pna0GW7CzZbD7VQTTo3n8gW4rk2xaWBDwnTnLvpjGjWWUKtcs5Or16ECzm8 EG0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=t8xMWpWXatWsCS1MK+NnKnpC4b3JmUSx4NHWxDCryRg=; b=WuFaMibZ+usV+ks5lyrWoVN6K4nnwTwNuIHcd2O+Nc2fcZIvCskooAQimEcVSw6NXu gRv3XUDMogIGupCogGbQndg+SXzjv2gQ7is3pU8mRMZqnuE0uNz7tASFLIuZkkMHixZ4 5iqaSMvpPivHHJhtGZ03nnHYIFFrRmW7J3VNTx+UxD3//z3XdzuXkiqLdqHKBeWU/73y XEVDlGPFDWRFeXmEqPnJMa9nXvsqubnkW+P3hMiTlI51IOSU8b0IepWphzRxzHebJM13 GQ0KK6scWpNM5Y1zb110G5NEdTTHmsqVdhroZF6ovgH18sKliDchaFFgPr6UqI1W3CKJ Ru6Q== X-Gm-Message-State: AO0yUKUG2mx61lWPgW1cnd1Err0lMEdbERNb/4p/ysE8soQpa73rwYgt gF2PXDR9QAVBws5Slo9cEgy+/Rt1+57W6hN2 X-Received: by 2002:a5d:4dcd:0:b0:2c3:e868:cf54 with SMTP id f13-20020a5d4dcd000000b002c3e868cf54mr745448wru.13.1676893881800; Mon, 20 Feb 2023 03:51:21 -0800 (PST) Received: from localhost.localdomain ([81.0.6.76]) by smtp.gmail.com with ESMTPSA id w2-20020a5d6802000000b002c55efa9cbesm1550419wru.39.2023.02.20.03.51.20 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 20 Feb 2023 03:51:21 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, Peter Maydell , Markus Armbruster , Paolo Bonzini , Alistair Francis , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , "Edgar E. Iglesias" , =?utf-8?q?Philippe_Mathieu-?= =?utf-8?q?Daud=C3=A9?= Subject: [PATCH 1/8] hw/gpio/max7310: Simplify max7310_realize() Date: Mon, 20 Feb 2023 12:51:07 +0100 Message-Id: <20230220115114.25237-2-philmd@linaro.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230220115114.25237-1-philmd@linaro.org> References: <20230220115114.25237-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42e; envelope-from=philmd@linaro.org; helo=mail-wr1-x42e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Since &I2C_SLAVE(dev)->qdev == dev, no need to go back and forth with QOM type casting. Directly use 'dev'. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- hw/gpio/max7310.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/gpio/max7310.c b/hw/gpio/max7310.c index db6b5e3d76..031482d939 100644 --- a/hw/gpio/max7310.c +++ b/hw/gpio/max7310.c @@ -183,11 +183,10 @@ static void max7310_gpio_set(void *opaque, int line, int level) * but also accepts sequences that are not SMBus so return an I2C device. */ static void max7310_realize(DeviceState *dev, Error **errp) { - I2CSlave *i2c = I2C_SLAVE(dev); MAX7310State *s = MAX7310(dev); - qdev_init_gpio_in(&i2c->qdev, max7310_gpio_set, 8); - qdev_init_gpio_out(&i2c->qdev, s->handler, 8); + qdev_init_gpio_in(dev, max7310_gpio_set, ARRAY_SIZE(s->handler)); + qdev_init_gpio_out(dev, s->handler, ARRAY_SIZE(s->handler)); } static void max7310_class_init(ObjectClass *klass, void *data)