From patchwork Mon Feb 20 13:18:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 655086 Delivered-To: patch@linaro.org Received: by 2002:adf:9bcd:0:0:0:0:0 with SMTP id e13csp1390584wrc; Mon, 20 Feb 2023 05:20:01 -0800 (PST) X-Google-Smtp-Source: AK7set8velENmRyS+gE/okQT5aiEAn/pL8OxFdQAHlyEMQ7oPqb2Y6ZUbBGJl02aUt7qo/YE7m4W X-Received: by 2002:ad4:5d65:0:b0:537:4b09:670f with SMTP id fn5-20020ad45d65000000b005374b09670fmr3589179qvb.25.1676899201652; Mon, 20 Feb 2023 05:20:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676899201; cv=none; d=google.com; s=arc-20160816; b=cBQD3H6P6RrspXKFLkISqJ99ecufXbcAT15+ZOYrEXGPLpP53VFBaHICVUbNVW3NVb 34VEkvL7kbeHPax5QAZ8ItyhGaSPP55hkQlFbjj8JC7AhUrvq+++YYXqdGlPHOUhjs6I HO6GCuy0PmR/8P+UQ0hfLmcB4/xg21OsI+1GU/mvPX9QZsA8dpvJdBILqCwSvxHGKeOu YS+TKtGCbO6kVGdkPpS6bzpl0wOznq/kJSMCSzhGkKCkNPZb+UcUtHggeyAmmZz7iqrc FQmprZevChGSyugUDwWlEb5YDx9IrOD+6ciHdOSKuZF6h5JtzHiRnJFQOd2oScHJtLUg CuEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=21ktG0r6ccIgO6rViL7/7XzafhkLlNAgvQ5PiKs4PAs=; b=OYRmfR/zp52syP2AqfvIam1YQWOADA/YSzsRKX+R48G23xhnfEUeBzznhXD4ODGvSy xM3nLLLPv/37NosSWkL4r3GtdgbVUhnEKPl38u6o9detwcH1/5DwBZhk9JnYiGTFEwkS 2Pt12WMj6QH8+ZoO3YB2pOWQ+QeXSE1uJMM+C7vRcOmL1jopasoALuMKh/S0PcL5zw/q wVhue/NM4xqSl1aJK5TU8k/qCL3t+9CbUwlPlplu6zBGchBpUrmbr0sUn4r1lhtG2Pnd BwPYeqoTnDOFmt+TWlIUJVsblgRHuqeH6ZB11M3jYc6k/KD7hEw6vijh8hl1GpmVsDqd R/uQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=w9iha3w2; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id c17-20020a0ce151000000b0056eb7b22128si9836079qvl.288.2023.02.20.05.20.01 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 20 Feb 2023 05:20:01 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=w9iha3w2; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pU64C-0002AH-3v; Mon, 20 Feb 2023 08:18:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pU64B-0002A3-CW for qemu-devel@nongnu.org; Mon, 20 Feb 2023 08:18:51 -0500 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pU649-000721-P3 for qemu-devel@nongnu.org; Mon, 20 Feb 2023 08:18:51 -0500 Received: by mail-wr1-x42d.google.com with SMTP id o4so1182809wrs.4 for ; Mon, 20 Feb 2023 05:18:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=21ktG0r6ccIgO6rViL7/7XzafhkLlNAgvQ5PiKs4PAs=; b=w9iha3w2Mw3E1cCUYu3HPBZP+zQQvqUtY5mJKNz/gHDXRaUfXDWkADWiiJsWRfFitT 9eGJhi2RJVoLlEUw1MTo7HiZPqx76SoiVA26v/BpXB0hLN8SgvUIXFcfMONgDMWeatB4 sig8XvDbzhAgyQJXeZ3yupBx4Kyk2jRTyzH/iTZZxaX+WKg/AuZXeMS84CIGFDARtJ5L ABVHezRjyIConMSyVjLWbm2wIsxlZiQy93uFjEW3NSifa8jZJQhvtedspKnWKy+dhTcl /gOi2RbjydGBvJ+uYys9Gs2TjOtHL4gC6KGYabdxJFkcr929cvZjPSS3lgj0PHKLxb9Q RsEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=21ktG0r6ccIgO6rViL7/7XzafhkLlNAgvQ5PiKs4PAs=; b=Rwi2oaPeraYyi5G8EOBj8W4pmF+E8JJnnpgQVdaKQR8+SzFARo19IUDdfudJgoPjUy d7ynOoD1aGCok8nXC619v/PvAKYQeMOcHVA/4HRM7C18HweldzAgJ5fPhGb0RiEhwpiW 0IXrX3kwNpqMVUherJEwxruwrN0qV6qZ52PPnt3ho/zjZubHOL8gzBQF5+7NMGFw8i/0 H4YG/P3HfBu6yIbpMStvVV1kI6A/U6y1AUI2kKPu3VTHh7Boq8kGp+u7EurvI5nSyTRp THwlvsuvv/I5yq6l5vR/bOu4a5HHR1AVA1ffHILGIL36/dztO+qM2HE6gvswM8sRZu0W kkSA== X-Gm-Message-State: AO0yUKXTfYjWkF+lDDhGNNdZcVj80J4kFpw4Ybq+UPJXTTsfbbVSPFvf XnzgO8Y6CIMq5b+g+5qf0yjiLaaURPu9x4Q5 X-Received: by 2002:adf:d086:0:b0:2c5:7c7a:78fb with SMTP id y6-20020adfd086000000b002c57c7a78fbmr498650wrh.40.1676899128235; Mon, 20 Feb 2023 05:18:48 -0800 (PST) Received: from localhost.localdomain ([81.0.6.76]) by smtp.gmail.com with ESMTPSA id i10-20020a1c3b0a000000b003e21f01c426sm329546wma.9.2023.02.20.05.18.47 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 20 Feb 2023 05:18:47 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Eduardo Habkost , qemu-ppc@nongnu.org, Paolo Bonzini , "Michael S. Tsirkin" , =?utf-8?q?Herv=C3=A9_Poussineau?= , Richard Henderson , Markus Armbruster , Gerd Hoffmann , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH 1/5] hw/audio/hda-codec: Avoid forward-declaring HDAAudioState Date: Mon, 20 Feb 2023 14:18:33 +0100 Message-Id: <20230220131837.26292-2-philmd@linaro.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230220131837.26292-1-philmd@linaro.org> References: <20230220131837.26292-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=philmd@linaro.org; helo=mail-wr1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org To avoid forward-declaring HDAAudioState, declare HDA_AUDIO QOM definitions before its use in the HDAAudioStream structure. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- hw/audio/hda-codec.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/hw/audio/hda-codec.c b/hw/audio/hda-codec.c index feb8f9e2bb..c51d8ba617 100644 --- a/hw/audio/hda-codec.c +++ b/hw/audio/hda-codec.c @@ -145,7 +145,9 @@ static const char *fmt2name[] = { [ AUDIO_FORMAT_S32 ] = "PCM-S32", }; -typedef struct HDAAudioState HDAAudioState; +#define TYPE_HDA_AUDIO "hda-audio" +OBJECT_DECLARE_SIMPLE_TYPE(HDAAudioState, HDA_AUDIO) + typedef struct HDAAudioStream HDAAudioStream; struct HDAAudioStream { @@ -171,9 +173,6 @@ struct HDAAudioStream { int64_t buft_start; }; -#define TYPE_HDA_AUDIO "hda-audio" -OBJECT_DECLARE_SIMPLE_TYPE(HDAAudioState, HDA_AUDIO) - struct HDAAudioState { HDACodecDevice hda; const char *name;