From patchwork Tue Feb 21 09:45:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 655363 Delivered-To: patch@linaro.org Received: by 2002:adf:9bcd:0:0:0:0:0 with SMTP id e13csp1869048wrc; Tue, 21 Feb 2023 01:47:49 -0800 (PST) X-Google-Smtp-Source: AK7set+Zg9HfSvUPTurriz74QkRofWM8057jXIW2peiI6Be/ldJpouO6KjzU191H8/AxGKmepkls X-Received: by 2002:ac8:5a04:0:b0:3b8:41d2:1b43 with SMTP id n4-20020ac85a04000000b003b841d21b43mr21901968qta.61.1676972869200; Tue, 21 Feb 2023 01:47:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676972869; cv=none; d=google.com; s=arc-20160816; b=NhbWBxxw8X06b1y8xdBBB0XLuHi5ENZIht0meS2KSF2lkhnHYvNFAwpuuEAIG7YeEf czh+XRbbyOc7IVrqmoeVY7Hx6JKkQsd0ZI94qrlVhRJTRyn5lpOGzTyYpHwTWGMB37Gm XBVwNcN60G1zDvUUlDjxbkzdmPU7Xx5oieZNQxbZWhj3sNZf3FxvA6ipuh/7Iq2UtdL3 K1DrkK0AUYjMdoE2GOYgiAGxSDhawTfHFrWEooXyJPw02Rcz3iBZYtRvW928sgnSBMzP sUoBrT6eW3Kxf+Wp3hmNMqoH+2LOfkXTBqSd3DQwTv9B4I7G6f64raCzMVA30UzSUZj3 RiPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=LcOwnhjPM/EC4s3jbpDRMp18o1Os+GkHpURgW/62Uzs=; b=lTbzzwqgRQagxLrNc61wtx8n3ov7Sx6VOBwBkUHSv15NabFOjOkzfXUflCotWk6SqT sy4xjzMXDHtPtjNAaBm37Nz9gkqvlfr9snI2FNnp33VfDw72IwNzhLK+MiqqfusCITph FbPKtdZ+yvwXU7twq8++zw/CmoHVJFTHq7rFjYGwkfUwW69sE2JL0PE9nrMS0Td2/Acm QrFB/a6Sr2f5wyL864GRrQ7EJET5wJOcekB01+IrzjlYoN+8JkW2t5voU40gmLliH2NV FCl8Hjsn/IRk5JAXmTDPNGhc72YYO0DqVRJqH804oirKcT8ksZqjT/31W/OeSMJYObFI 78hA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=SJFSicb0; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id i9-20020a05620a248900b0073b841840c8si3380434qkn.202.2023.02.21.01.47.49 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 21 Feb 2023 01:47:49 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=SJFSicb0; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pUPE7-0006j3-47; Tue, 21 Feb 2023 04:46:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUPDq-0006Y5-T7 for qemu-devel@nongnu.org; Tue, 21 Feb 2023 04:46:08 -0500 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pUPDn-0005iB-9i for qemu-devel@nongnu.org; Tue, 21 Feb 2023 04:46:06 -0500 Received: by mail-wr1-x431.google.com with SMTP id p8so3840492wrt.12 for ; Tue, 21 Feb 2023 01:46:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LcOwnhjPM/EC4s3jbpDRMp18o1Os+GkHpURgW/62Uzs=; b=SJFSicb0MiVzHj16vOGIWvxAJzrBrq2vvAAahfYlFMeY9M1Ok5zh4Ls6B24ELfQ9Zk NT4rOzpYKpJbrqGPznnhogusAUj99Q5VAgC9oCSVuwpck7/Otsla0IyLhSZJ5eAZUICz XJ9OUtQr/iaSiK0lBkbZXwCFXNFzqKBe6Zu1cWMex5ZdLDwB/+rOrvU77mSRqq3+zBW3 NyMo7Ok4RfSOoKoPevppSFbzyZ6EEo0LTdPyRoiOLOIcOAWNuSLpMxI36OKafxAu6ysL fdbrgFTrnk8U6wSDGckEUZXDsTn04VhbzprpptW+PnMBRIAVzQ2s4vMvhrKJKBJ3RZoR FPuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LcOwnhjPM/EC4s3jbpDRMp18o1Os+GkHpURgW/62Uzs=; b=KvC4wcSFPzJiHYdicXYJkC9ZfKhcSvjZ0X1kkiaXQVPuruNSJs9/27Nz5JwjlJeS4C Ow6wiN4OsIJT4aIMXgMrRSbUD1+SE0P5YmjhMTMDvRTOgA8giFkYTdDWOh7LrOXDdb6I YETDvcLAgeZaFJL1v81SHwT/oYTPUzAGKMVvAtrkPHcFbF+qG6d+aQ3sKD+hd3k2iXla veyaAKHu6K2y/OvGhKiBT1ISRahb0PRQpC+g7KeWoE1XR+3Ts3SkZx+STPacLfnrbyZT EUDLsxvzVuec19OCQ3vWqFU/2exnHldLsSexs5p38TCJyCct+qEUaOIhap3ayK5rOUph JW+A== X-Gm-Message-State: AO0yUKUXTZHTiLMzaHQIbQTbfYqUN0lzC4KD4ju/2n6EllhNqolXHHea chypwM54tW/GZyvyHimgv7bEJg== X-Received: by 2002:a05:6000:552:b0:2c3:dd60:d749 with SMTP id b18-20020a056000055200b002c3dd60d749mr1997220wrf.47.1676972761918; Tue, 21 Feb 2023 01:46:01 -0800 (PST) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id q2-20020adff502000000b002c573a6216fsm2427049wro.37.2023.02.21.01.45.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Feb 2023 01:46:00 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 98CEE1FFBD; Tue, 21 Feb 2023 09:45:59 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Markus Armbruster , Peter Maydell , Yonggang Luo , Li-Wen Hsu , Paolo Bonzini , Thomas Huth , Ed Maste , Bandan Das , Cleber Rosa , Qiuhao Li , qemu-block@nongnu.org, Beraldo Leal , Hanna Reitz , qemu-arm@nongnu.org, Michael Roth , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Pavel Dovgalyuk , Alexander Bulekov , Darren Kenny , Aurelien Jarno , Bastian Koppelmann , Wainer dos Santos Moschetta , Stefan Hajnoczi , Kevin Wolf , John Snow , =?utf-8?q?Alex_Benn=C3=A9e?= , =?utf-8?q?Daniel_P?= =?utf-8?q?=2E_Berrang=C3=A9?= Subject: [PATCH v2 05/14] tests: make fp-test less chatty when running from test suite Date: Tue, 21 Feb 2023 09:45:49 +0000 Message-Id: <20230221094558.2864616-6-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230221094558.2864616-1-alex.bennee@linaro.org> References: <20230221094558.2864616-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::431; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x431.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org As we like to run tests under CI with V=1 flags the softfloat tests can add up to a fair amount of extra log lines. With an update to the testfloat library we can now call fp-test with the -q flag and reduce the output to a terse one line per function tested. make check-softfloat V=1 | wc -l 759 Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth --- tests/fp/fp-test.c | 19 ++++++++++++++----- tests/fp/berkeley-testfloat-3 | 2 +- tests/fp/meson.build | 2 +- 3 files changed, 16 insertions(+), 7 deletions(-) diff --git a/tests/fp/fp-test.c b/tests/fp/fp-test.c index 35829ad5f7..36b5712cda 100644 --- a/tests/fp/fp-test.c +++ b/tests/fp/fp-test.c @@ -106,7 +106,8 @@ static const char commands_string[] = " -l = thoroughness level (1 (default), 2)\n" " -r = rounding mode (even (default), zero, down, up, tieaway, odd)\n" " Set to 'all' to test all rounding modes, if applicable\n" - " -s = stop when a test fails"; + " -s = stop when a test fails\n" + " -q = minimise noise when testing, just show each function being tested"; static void usage_complete(int argc, char *argv[]) { @@ -190,9 +191,11 @@ static void do_testfloat(int op, int rmode, bool exact) ab_f128M_z_bool true_ab_f128M_z_bool; ab_f128M_z_bool subj_ab_f128M_z_bool; - fputs(">> Testing ", stderr); - verCases_writeFunctionName(stderr); - fputs("\n", stderr); + if (verCases_verbosity) { + fputs(">> Testing ", stderr); + verCases_writeFunctionName(stderr); + fputs("\n", stderr); + } if (!is_allowed(op, rmode)) { not_implemented(); @@ -837,7 +840,7 @@ static void parse_args(int argc, char *argv[]) int c; for (;;) { - c = getopt(argc, argv, "he:f:l:r:s"); + c = getopt(argc, argv, "he:f:l:r:sq"); if (c < 0) { break; } @@ -874,9 +877,15 @@ static void parse_args(int argc, char *argv[]) } } break; + /* + * The following flags are declared in testfloat/source/verCases_common.c + */ case 's': verCases_errorStop = true; break; + case 'q': + verCases_verbosity = 0; + break; case '?': /* invalid option or missing argument; getopt prints error info */ exit(EXIT_FAILURE); diff --git a/tests/fp/berkeley-testfloat-3 b/tests/fp/berkeley-testfloat-3 index 5a59dcec19..40619cbb3b 160000 --- a/tests/fp/berkeley-testfloat-3 +++ b/tests/fp/berkeley-testfloat-3 @@ -1 +1 @@ -Subproject commit 5a59dcec19327396a011a17fd924aed4fec416b3 +Subproject commit 40619cbb3bf32872df8c53cc457039229428a263 diff --git a/tests/fp/meson.build b/tests/fp/meson.build index 312a4d301f..f9ca6a93b4 100644 --- a/tests/fp/meson.build +++ b/tests/fp/meson.build @@ -609,7 +609,7 @@ softfloat_tests = { # The full test suite can take a bit of time, default to a quick run # "-l 2 -r all" can take more than a day for some operations and is best # run manually -fptest_args = ['-s', '-l', '1'] +fptest_args = ['-q', '-s', '-l', '1'] fptest_rounding_args = ['-r', 'all'] # Conversion Routines: