From patchwork Tue Feb 21 22:52:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 655401 Delivered-To: patch@linaro.org Received: by 2002:adf:a3c6:0:0:0:0:0 with SMTP id m6csp375114wrb; Tue, 21 Feb 2023 15:05:09 -0800 (PST) X-Google-Smtp-Source: AK7set+dkiIZypnzdfK5CJusg/5uTh5Cezvk+HzpGDDZpvGSn0IGpJG68y2lLGpI2GZjqABbOg/d X-Received: by 2002:ad4:596b:0:b0:56f:37a:455e with SMTP id eq11-20020ad4596b000000b0056f037a455emr14732655qvb.11.1677020708927; Tue, 21 Feb 2023 15:05:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677020708; cv=none; d=google.com; s=arc-20160816; b=r3jWYsWbc31cF56Nw7/Bm6sT3ACYpmwDpHaR+vtfqrS07BiuxEhBUmWOOkII38Bm1i nrCeDuE2Bgqa2FejLP9h/ogZJwcas7R9Vmh04orJdBIfDFQwT7HAhk9ddVbmd2QOakYj xrqixVoMdVtnl67fmry9gxgkXU3lAbeUEgyCqwiPjXYN3EVBkm2kXZkbmksuLAJKbA9y h7WnoDxsl7fGwAxdidFotGdHXh2+vHyQhCLz/OVeYyHEpv+w2WtFRwsz9LOapyp+0674 1Ez5q0zjUwfYxmOxvNe6BwkwUoyCxKsSO/dxIqsj0WW8jGjKvKodIMvZaEuNMkyCiO5c UeMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=iMicf5MbOGOq7OlwruPZHVb+Ki+l+2GcwACskyg7sb0=; b=MrcQIyaNdgNjP3LB9AiUqquUgjcS9dXb2LecHzZwRogCMoKTa7sFIvNucPQ2+pRdYg ymlxW1qTAL+p+SldfvHKusm+U0kl3NZCWwsoLpRpp1GNHDwVVX/5hJYH49pPq9EBE+Bc BlY9Vu6zIfDt9tajUD6dNrY5RuBS2nJTuw0ivQw5Yk1J0tlfVUkiIjFFK/p/f1aU354d sIMF4QFleAsvvXOpUgWq8ZSONAf95pkDFYTWrxKma06g92FNrIpZaEYIynTKgp4RJ3wI x1QturrBt3Rxxp3QHNveGFYUV7qakXBZBeZGL9NQx995fQ3+OSKE8r/O2GERkhioW7tz 6Owg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Se6r6nan; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id m19-20020a0cf193000000b0053226b8f7ffsi13212902qvl.83.2023.02.21.15.05.08 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 21 Feb 2023 15:05:08 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Se6r6nan; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pUbeW-0006gW-5X; Tue, 21 Feb 2023 18:02:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUbeD-0006Q2-Fi for qemu-devel@nongnu.org; Tue, 21 Feb 2023 18:02:10 -0500 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pUbe3-0006ER-Th for qemu-devel@nongnu.org; Tue, 21 Feb 2023 18:02:07 -0500 Received: by mail-wm1-x333.google.com with SMTP id l6so4356569wms.3 for ; Tue, 21 Feb 2023 15:01:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iMicf5MbOGOq7OlwruPZHVb+Ki+l+2GcwACskyg7sb0=; b=Se6r6nanSNv3SGL2ZPDLYua+qn0ydW5lxXxfvjQb4eodVOf//zwxbZsxd5B54DqJwt 81akZNOncSUgJgVWkfFCqjjVcF4f3t+7JHYIQnYIIVDg6KJkL9rql1nML8wfC7p+Sbl1 jxTAdkhgfGuHdbgWW78kZgQT2GOf5Js3QZoYRQJzsioFanXCOgRn1Fog1GZ1U2aoxWse 5D6FLJT2RhHM4IOg5DbHWHi5PwXUdaY9tmcgePe94fAhqkkjqiI6tjKN7u6/ugTTMJz0 gjn7I4lVJPqvVCdSft5T9N5AMEhmtOXpbHDe6iwGPSzCVf6XIT6qs9Xp/312NNtRcG6+ emJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iMicf5MbOGOq7OlwruPZHVb+Ki+l+2GcwACskyg7sb0=; b=HC4M0qEyyugd91o4MwyDjwQiNWAj/bQ4sOfrrMJyHuLUGNOofNg3pAA8faX6dZ9sRl IfccQ4pyyOQjuGopysdGB5nmWDAG8lKqhFVKHmKz9jxfMoRRqOG1g5sq+UaTw+P7JHEN CwSiGoYlYrq45ZNsD+Cz5NXOZ1Ptxhe+16sv1vTRkgn9Tx1RLK1jL8iRSWOoBI7u4vVc ytzjbCLuoFakZkgUeDbGErkMR6omxrRWvna1jbmz2VkVyuO7JRhn+RsdOlbTxVFvWltq pR1LMjSObqLJAmuuwfz21jH+G+X0yPAC/kTyW0ephqBCEIp2UvOhHOCEcifc1RDfCAFx f5xg== X-Gm-Message-State: AO0yUKXcr7pf30PmXwM42qZtrRyo9FO4wS6ubWs50PhDxWNWFVONQsO1 w11csQpf5S//SLQieaDxSthZAw== X-Received: by 2002:a05:600c:5121:b0:3dd:1bd3:4f6d with SMTP id o33-20020a05600c512100b003dd1bd34f6dmr4294092wms.32.1677020518044; Tue, 21 Feb 2023 15:01:58 -0800 (PST) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id x8-20020a1c7c08000000b003dc4480df80sm4966219wmc.34.2023.02.21.15.01.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Feb 2023 15:01:56 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id A4A3C1FFBB; Tue, 21 Feb 2023 22:52:29 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Thomas Huth , qemu-arm@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org, Yoshinori Sato , nicolas.eder@lauterbach.com, Stafford Horne , Daniel Henrique Barboza , Mahmoud Mandour , Taylor Simpson , mads@ynddal.dk, Marek Vasut , Artyom Tarasenko , Alistair Francis , qemu-ppc@nongnu.org, Yanan Wang , Sunil Muthuswamy , =?utf-8?q?C=C3=A9dric_Le_Goater?= , Eduardo Habkost , Bin Meng , Bastian Koppelmann , Palmer Dabbelt , Marcel Apfelbaum , Laurent Vivier , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Michael Rolnik , Aleksandar Rikalo , Paolo Bonzini , =?utf-8?q?Alex_Benn=C3=A9e?= , Aurelien Jarno , Xiaojuan Yang , Richard Henderson , Peter Maydell , Alexandre Iooss , Chris Wulff , Jiaxun Yang , David Gibson , "Edgar E. Iglesias" , Greg Kurz , David Hildenbrand , Song Gao , Ilya Leoshkevich , Max Filippov , Mark Cave-Ayland Subject: [PATCH v3 17/24] gdbstub: fix address type of gdb_set_cpu_pc Date: Tue, 21 Feb 2023 22:52:20 +0000 Message-Id: <20230221225227.3735319-18-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230221225227.3735319-1-alex.bennee@linaro.org> References: <20230221225227.3735319-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org The underlying call uses vaddr and the comms API uses unsigned long long which will always fit. We don't need to deal in target_ulong here. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée --- gdbstub/gdbstub.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index e107aa065c..4814e8fbf3 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -535,7 +535,7 @@ static void gdb_process_breakpoint_remove_all(GDBProcess *p) } -static void gdb_set_cpu_pc(target_ulong pc) +static void gdb_set_cpu_pc(vaddr pc) { CPUState *cpu = gdbserver_state.c_cpu; @@ -1289,7 +1289,7 @@ static void handle_file_io(GArray *params, void *user_ctx) static void handle_step(GArray *params, void *user_ctx) { if (params->len) { - gdb_set_cpu_pc((target_ulong)get_param(params, 0)->val_ull); + gdb_set_cpu_pc(get_param(params, 0)->val_ull); } cpu_single_step(gdbserver_state.c_cpu, gdbserver_state.sstep_flags);