From patchwork Tue Feb 21 22:52:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 655389 Delivered-To: patch@linaro.org Received: by 2002:adf:a3c6:0:0:0:0:0 with SMTP id m6csp370988wrb; Tue, 21 Feb 2023 14:55:59 -0800 (PST) X-Google-Smtp-Source: AK7set8YN/Bg58wh99JozjstOj9NEuFEgHC8VyxVIf9TyslZ0sm44qrBJgwzZypMhyHcyQvSBK18 X-Received: by 2002:ad4:5bae:0:b0:56e:a2cb:5732 with SMTP id 14-20020ad45bae000000b0056ea2cb5732mr9250492qvq.9.1677020159816; Tue, 21 Feb 2023 14:55:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677020159; cv=none; d=google.com; s=arc-20160816; b=wEDVJ16cJp09A9LY4CBAAuFC5M77L/W/bHQZa5oCZJuVw8cK3vGDicKmaCj6zL0LNp tiApG3a8wfEVQYCfUQsfNhrXNieT+xF3bcytt1u7JUlVkpjcSf+2FWFUxcj/Gabb/sXu UMms0nyMPbhlP/PwRRJQBnDQUeh3b70a3+zkFB7iIbQaQXbGzN6zrEiVpgjUOFxfcC8L e1ORZsVz6kLfjXzoPaOsvadamAPLAfF8Gat9rQoxMsLYdbuFO3/UVC01HEoA0zQYBHUI n9YmK3JuR53McZ/vqjyS8DNS8qvrxK8qAYaXY2aARQqdSns3dWyNzj9Tk0kdaFNl6voR pSYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=RtWA42U2CW9MkCZPpjCduULXRT6epTC7Pw4Xhbyp8Mg=; b=o00m/dB03uHfvwbA4KejniFnexgzvQGxFyT3Lqd+yqGoV3NjnGamrZUeylOW/L++oQ WMk8SxrxYLyBIuDCnZw4aJNgR9TNE34anzZVU8IvaugeeMmHIWqA6pi31USp38HkldOn DZUQVjqHNxQPFWBTAxSbnOyBkd9Rag2Zabur6keKlxyFi9qFM/ep03Ne0Rhnp0G5QXCG qL0m6jFpwzbrisuxqfXzP9+x/Q9D5E4A6EMNfytd02ChDuGSPGkcH2fPqFH4LAEquJGm TawJm02fVJ1aHZXrm1Nj00wKUU4rguw51ci3QyPw3yokxRJ3xhm151lWDxKl3FIZQv0f z6OA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=mAgjocz+; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id f63-20020a37d242000000b0073b714fc4acsi12403821qkj.713.2023.02.21.14.55.59 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 21 Feb 2023 14:55:59 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=mAgjocz+; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pUbV4-0007LO-BB; Tue, 21 Feb 2023 17:52:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUbV0-0007HN-Gl for qemu-devel@nongnu.org; Tue, 21 Feb 2023 17:52:38 -0500 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pUbUt-000445-8v for qemu-devel@nongnu.org; Tue, 21 Feb 2023 17:52:37 -0500 Received: by mail-wm1-x329.google.com with SMTP id p16so2170979wmq.5 for ; Tue, 21 Feb 2023 14:52:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RtWA42U2CW9MkCZPpjCduULXRT6epTC7Pw4Xhbyp8Mg=; b=mAgjocz+7UapUfQDQq2QJraqMURPi3rbmoDyZc7bl9DsA16mydZfEqbhEq94o3x8F1 WJ8Yw2c6dMfRf0Moyj5scq+T2IJVk+qkBvXLEUFauXWH9MYF/iOxJejXRpV4k2KTRDVL A+3ti5u5htw8o4E+FUg/t2tPurQIBEVfVk3Ko0uvNv0NrOQk2IIrvTJx6lzmRXfqgnRJ wdTVXDgE/bVGWANSeP0HEoUNkjIAQDtc2zGhIJoYEJ7set0UiXJjxCybkKYLdi0PMCVH q6ixSlefdhXnbwXXdllDSB6kn43M9OQwwLZCgGwWbPddSaMrSmrSgM04tlu2bKCJieNZ S1lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RtWA42U2CW9MkCZPpjCduULXRT6epTC7Pw4Xhbyp8Mg=; b=O4ogjO1IP9BTfUCgxrCcZ1ByumDMLZR+4Kl6G0s2G/IA+J8CbkYmM3Y4hV5BE9zu+1 7H3YoGlcANvJXq6qohQTY6UUuXyBtqp6T7N7dB28c8tKbxVE2lV+g1JoRhUGJO2gtuUk Pz+3SksEYYohVC/zFzNCd6lx61cd9PXF3E1thnrj3pY7LiG+6CBGZ7f7zVrwKw+we37O xtl9x9h/Hhfzi2g4n2MJprO/EXAGJx3fz+dY1r6PZLoslNdIawxsD9FpUzT/WcHnhIQR H/f8+LuU5E8+3dq4Ai/XBUFsmlv+zACKSKs02582vGTgk2kcezFfPy4SWs49vW52vr2y 3Asw== X-Gm-Message-State: AO0yUKXK83U3lyYGZMKzEH8XBn0JdJNkInQB0MmjMEJ8Mq4AehVeVXL6 IYxOre8yIWUFowKczGdpC05KLg== X-Received: by 2002:a05:600c:4a90:b0:3e2:66b:e90e with SMTP id b16-20020a05600c4a9000b003e2066be90emr10554222wmp.10.1677019949542; Tue, 21 Feb 2023 14:52:29 -0800 (PST) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id c22-20020a7bc856000000b003e01493b136sm5841907wml.43.2023.02.21.14.52.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Feb 2023 14:52:28 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 95AE81FFBB; Tue, 21 Feb 2023 22:52:27 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Thomas Huth , qemu-arm@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org, Yoshinori Sato , nicolas.eder@lauterbach.com, Stafford Horne , Daniel Henrique Barboza , Mahmoud Mandour , Taylor Simpson , mads@ynddal.dk, Marek Vasut , Artyom Tarasenko , Alistair Francis , qemu-ppc@nongnu.org, Yanan Wang , Sunil Muthuswamy , =?utf-8?q?C=C3=A9dric_Le_Goater?= , Eduardo Habkost , Bin Meng , Bastian Koppelmann , Palmer Dabbelt , Marcel Apfelbaum , Laurent Vivier , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Michael Rolnik , Aleksandar Rikalo , Paolo Bonzini , =?utf-8?q?Alex_Benn=C3=A9e?= , Aurelien Jarno , Xiaojuan Yang , Richard Henderson , Peter Maydell , Alexandre Iooss , Chris Wulff , Jiaxun Yang , David Gibson , "Edgar E. Iglesias" , Greg Kurz , David Hildenbrand , Song Gao , Ilya Leoshkevich , Max Filippov , Mark Cave-Ayland Subject: [PATCH v3 03/24] gdbstub: Make syscall_complete/[gs]et_reg target-agnostic typedefs Date: Tue, 21 Feb 2023 22:52:06 +0000 Message-Id: <20230221225227.3735319-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230221225227.3735319-1-alex.bennee@linaro.org> References: <20230221225227.3735319-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x329.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Philippe Mathieu-Daudé Prototypes using gdb_syscall_complete_cb() or gdb_?et_reg_cb() don't depend on "cpu.h", thus are not target-specific. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20221214143659.62133-1-philmd@linaro.org> Signed-off-by: Alex Bennée --- include/exec/gdbstub.h | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/include/exec/gdbstub.h b/include/exec/gdbstub.h index f667014888..1636fb3841 100644 --- a/include/exec/gdbstub.h +++ b/include/exec/gdbstub.h @@ -71,9 +71,6 @@ struct gdb_timeval { uint64_t tv_usec; /* microsecond */ } QEMU_PACKED; -#ifdef NEED_CPU_H -#include "cpu.h" - typedef void (*gdb_syscall_complete_cb)(CPUState *cpu, uint64_t ret, int err); /** @@ -126,6 +123,7 @@ int gdb_handlesig(CPUState *, int); void gdb_signalled(CPUArchState *, int); void gdbserver_fork(CPUState *); #endif + /* Get or set a register. Returns the size of the register. */ typedef int (*gdb_get_reg_cb)(CPUArchState *env, GByteArray *buf, int reg); typedef int (*gdb_set_reg_cb)(CPUArchState *env, uint8_t *buf, int reg); @@ -133,6 +131,9 @@ void gdb_register_coprocessor(CPUState *cpu, gdb_get_reg_cb get_reg, gdb_set_reg_cb set_reg, int num_regs, const char *xml, int g_pos); +#ifdef NEED_CPU_H +#include "cpu.h" + /* * The GDB remote protocol transfers values in target byte order. As * the gdbstub may be batching up several register values we always