From patchwork Wed Feb 22 23:27:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 655721 Delivered-To: patch@linaro.org Received: by 2002:adf:a3c6:0:0:0:0:0 with SMTP id m6csp37260wrb; Wed, 22 Feb 2023 15:31:27 -0800 (PST) X-Google-Smtp-Source: AK7set8fC8/diFhZPcDhgJmmBKCTiDYYJhnmAVk0f9nruwlS/kvMJMKG0yC5yHyRFvgDpancn7We X-Received: by 2002:ac8:5c4f:0:b0:3bd:1a4f:96d1 with SMTP id j15-20020ac85c4f000000b003bd1a4f96d1mr19537920qtj.7.1677108687018; Wed, 22 Feb 2023 15:31:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677108687; cv=none; d=google.com; s=arc-20160816; b=AXd2Py9JkgDMdndPTobnfs31eapIAeUcAQhE8HCXDSCv8RnGF8S0qR10yZvqey4llj v3IeB3852cFmHxneuQSa+D+xFAg54X3W6E1NG8zhZMWYH7VgmLldpj2Y+kHYaanWbeok W3fERMgjynPsMzYwUNVZ3lE203aqdwcd3iymtG5rfI/XPMDy+tSv9cODxGrpGcfGBBTd tSb3uesp99a4jauZ2/W4LrVkYHjZG07pNzvvYAGVxgdKteGoodSzUZ2dvCUUt3yhnVti fClgv9HCkXpJXXDczHBQ8OWVBDk/M03BoEFKeeehwRNTkpFudUIicN/7MR3rd554rE2j gzJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=xoCNCTfOA+IAeo+WWbY5Cg+uzKY+6Jpeq9pYOaVqoU4=; b=JaVaL+6K+Zs/EGgUKIsFlTOxDQcZu59oy1mJv3hGliWddcAKE92CYpus32obeYrmhm 7qihV4hnPzcs15Xol5/cbgqRRoUjiJKpbvH9UN+KbyL3n8z52OVYnwm4G86IYW0RlqQI XK8oYXtmL/MekbQ5HFJMaC23B4ZxuKV7og0/haKtIzMR+vIdCEzaI5QKr3DFdWyAdavG xkx+K04ua6CaUIflXHR3cyUWq6P13NGAaAy+H1fh4TBQ3QdIOkfbdRBp7HqgYHC5OgV3 p+P7cfBAZCqhmd9NVyRuO0xGNS25wDQGYjV6a5E3bmF1C17FcrgGoOLQ2bLPc1Drx6HY 6TAQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=SImEUIUG; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id ay12-20020a05620a178c00b00738d7b43a9csi15652744qkb.401.2023.02.22.15.31.26 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 22 Feb 2023 15:31:27 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=SImEUIUG; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pUyWj-0000Wj-Kq; Wed, 22 Feb 2023 18:27:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUyWc-0000Vm-SE for qemu-devel@nongnu.org; Wed, 22 Feb 2023 18:27:51 -0500 Received: from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pUyWb-0005NL-8Q for qemu-devel@nongnu.org; Wed, 22 Feb 2023 18:27:50 -0500 Received: by mail-pl1-x630.google.com with SMTP id u14so6868956ple.7 for ; Wed, 22 Feb 2023 15:27:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xoCNCTfOA+IAeo+WWbY5Cg+uzKY+6Jpeq9pYOaVqoU4=; b=SImEUIUGqM80mXzrutAbLKt7zrIj4E4XW+DOwQL6inL3pPkHt0kuW9DcrmRrVj3v4v hykpmTVx8EZpBwSwUtcMe4dPWkNAJf47UtdJuNnjN7SN3zcaJWm/SBEZco1hbx1AErPA LB09bI8TM51e+659zNze70ZAoDSA7nynwQ8+yLsDriLcKxvjRz3AyYWgTzeaRwzR0gWu d/zINyx0/QwV53bASkunNsxjumJP5d1m0DB8ohTFSux8uVsOaIPa6WiZpEuUWRX1Xf5P 9/oaBCYXQf/VKuo0NxO1U6hdnIkEzKAVUBprlczBHxA1aYzp9dy/q60hEYe+Yg7W+joA HxxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xoCNCTfOA+IAeo+WWbY5Cg+uzKY+6Jpeq9pYOaVqoU4=; b=mPR/6V/ISA7ZW7TRysL/9VlSmWBSvmfSD98mWrWhDGeTqubu4KLDvKVibXulRXnBtp zjC5mouL+Bmhc0HX0mVqClkYbwGXggCdFsYjPmbxxG5OC4m0Lw3RVBomlZBlGoFlGW58 EeWkYzaSyS9bTQQSAzGMcrb197KDqORumZmWT4jcv9nwgQPmTaAj8f5dVmWX/97+/e8B GzioPYTkPVZZ/jsPuar693OmdkIwidgMSlG1ySGuXp8+kAxqyyIDrsyYuySdfUg9yOej anM2wGNCLbJSUVpVpTAQ/MJOCkTRE4Bj0Y2JYl7d90B2HKIX6oKLV1tCzIqlM0L3V6SI zjoA== X-Gm-Message-State: AO0yUKV1kuyAzrsuhpm8/g0zUvQ7M0hRT4adyNQ+rlmd7jV5K1HlJ2R5 Rfx7MyTlk8nAaQ8V28yUWwlbQz4QFQiKnxtWgW8= X-Received: by 2002:a17:90b:4d12:b0:231:1df1:7aea with SMTP id mw18-20020a17090b4d1200b002311df17aeamr12193558pjb.22.1677108467699; Wed, 22 Feb 2023 15:27:47 -0800 (PST) Received: from stoup.. (rrcs-173-198-77-218.west.biz.rr.com. [173.198.77.218]) by smtp.gmail.com with ESMTPSA id s16-20020a17090ad49000b00234e6d2de3dsm5008918pju.11.2023.02.22.15.27.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 15:27:47 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH v2 21/28] target/i386: Don't use tcg_temp_local_new Date: Wed, 22 Feb 2023 13:27:08 -1000 Message-Id: <20230222232715.15034-22-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230222232715.15034-1-richard.henderson@linaro.org> References: <20230222232715.15034-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::630; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x630.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Since tcg_temp_new is now identical, use that. In some cases we can avoid a copy from A0 or T0. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/i386/tcg/translate.c | 27 +++++++++------------------ 1 file changed, 9 insertions(+), 18 deletions(-) diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c index a47d60f057..baf1cfc2bc 100644 --- a/target/i386/tcg/translate.c +++ b/target/i386/tcg/translate.c @@ -3426,13 +3426,10 @@ static bool disas_insn(DisasContext *s, CPUState *cpu) if (mod == 3) { goto illegal_op; } - a0 = tcg_temp_local_new(); - t0 = tcg_temp_local_new(); + a0 = s->A0; + t0 = s->T0; label1 = gen_new_label(); - tcg_gen_mov_tl(a0, s->A0); - tcg_gen_mov_tl(t0, s->T0); - gen_set_label(label1); t1 = tcg_temp_new(); t2 = tcg_temp_new(); @@ -3444,9 +3441,7 @@ static bool disas_insn(DisasContext *s, CPUState *cpu) tcg_gen_brcond_tl(TCG_COND_NE, t0, t2, label1); tcg_temp_free(t2); - tcg_temp_free(a0); tcg_gen_neg_tl(s->T0, t0); - tcg_temp_free(t0); } else { tcg_gen_neg_tl(s->T0, s->T0); if (mod != 3) { @@ -6248,13 +6243,13 @@ static bool disas_insn(DisasContext *s, CPUState *cpu) #endif { TCGLabel *label1; - TCGv t0, t1, t2, a0; + TCGv t0, t1, t2; if (!PE(s) || VM86(s)) goto illegal_op; - t0 = tcg_temp_local_new(); - t1 = tcg_temp_local_new(); - t2 = tcg_temp_local_new(); + t0 = tcg_temp_new(); + t1 = tcg_temp_new(); + t2 = tcg_temp_new(); ot = MO_16; modrm = x86_ldub_code(env, s); reg = (modrm >> 3) & 7; @@ -6263,11 +6258,8 @@ static bool disas_insn(DisasContext *s, CPUState *cpu) if (mod != 3) { gen_lea_modrm(env, s, modrm); gen_op_ld_v(s, ot, t0, s->A0); - a0 = tcg_temp_local_new(); - tcg_gen_mov_tl(a0, s->A0); } else { gen_op_mov_v_reg(s, ot, t0, rm); - a0 = NULL; } gen_op_mov_v_reg(s, ot, t1, reg); tcg_gen_andi_tl(s->tmp0, t0, 3); @@ -6280,8 +6272,7 @@ static bool disas_insn(DisasContext *s, CPUState *cpu) tcg_gen_movi_tl(t2, CC_Z); gen_set_label(label1); if (mod != 3) { - gen_op_st_v(s, ot, t0, a0); - tcg_temp_free(a0); + gen_op_st_v(s, ot, t0, s->A0); } else { gen_op_mov_reg_v(s, ot, rm, t0); } @@ -6304,7 +6295,7 @@ static bool disas_insn(DisasContext *s, CPUState *cpu) modrm = x86_ldub_code(env, s); reg = ((modrm >> 3) & 7) | REX_R(s); gen_ldst_modrm(env, s, modrm, MO_16, OR_TMP0, 0); - t0 = tcg_temp_local_new(); + t0 = tcg_temp_new(); gen_update_cc_op(s); if (b == 0x102) { gen_helper_lar(t0, cpu_env, s->T0); @@ -7052,7 +7043,7 @@ static void i386_tr_init_disas_context(DisasContextBase *dcbase, CPUState *cpu) dc->tmp2_i32 = tcg_temp_new_i32(); dc->tmp3_i32 = tcg_temp_new_i32(); dc->tmp4 = tcg_temp_new(); - dc->cc_srcT = tcg_temp_local_new(); + dc->cc_srcT = tcg_temp_new(); } static void i386_tr_tb_start(DisasContextBase *db, CPUState *cpu)