From patchwork Wed Feb 22 23:27:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 655728 Delivered-To: patch@linaro.org Received: by 2002:adf:a3c6:0:0:0:0:0 with SMTP id m6csp38351wrb; Wed, 22 Feb 2023 15:33:40 -0800 (PST) X-Google-Smtp-Source: AK7set/kvgFlvhaBajFN4c9zjthDwK9xGXEeZOyXDqyivvY9wXhw1gH04SDGO0OnHW264fYsugL1 X-Received: by 2002:a05:622a:d1:b0:3bd:89d:224d with SMTP id p17-20020a05622a00d100b003bd089d224dmr17612266qtw.3.1677108820280; Wed, 22 Feb 2023 15:33:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677108820; cv=none; d=google.com; s=arc-20160816; b=K8ZDtMAaC4KzvYR+IpFnRSfkBpatg4WX0MRRFbF4SjY3eEXSycibJzuuX7sBL2pzMl YUsHSZOYUO26Ot2A6ppdMyHBtFICINAtukKODPS1Cu5xKoaVFlw07hCUvgK66Zj2Hgsz A5hsUVpSDK/2bo1zTZegHphjVY/0nAT9/TwrDfREeL0lztYvCaGA663KuyW+aDcP+SqX BO7dRd85ecW+3vWA84UWkMaCCLlmUsPCILAPeaUf0XvBT0UaVvSYIQuz5ZCnCy4zoJiu +bhJiAMFLQI5HXmX/q9vzPGK9Lq1mSXdRvrIDZK/3oNxYE2Vx1rGFKkyQxkz9dnglwhd YcSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=6rAVEKvH88i+QH8CXFUlPcaghYPMd95m3CUWWiU3uQ0=; b=rI66+brhA2OFX7u8DqM0grlezF456bx08MEfRvmsRFqmd5jWzHa+yqF6zIJbjS9rXB GlHegvVFR7aijzSNWIXi17DujGkbgJjEnNe4Ef9B6SMvcMIZz0HD3eANlDRSTJLK0tVs ev/IDvWKt5AlSgrV34YYTEFkCDI38z5T+4pl+XLz2hFca5+nn1WazvNPgmj3mzxzJdjS ji+5J6p25Ojk8qwfGw22H0q61R2vIMLG5xdwBPO/sMSSOSh+DHoyzv8wXhjWO416FsHe jGz547Hoe4ESqK0X/IDZPOYH/ejuW12MtsjpDaR52mCks8Vb3oQaOBW6cDDxIdA+OQ3o G7jA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="W/W61AyJ"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 18-20020ac85912000000b003ba3c95d80dsi5525991qty.318.2023.02.22.15.33.40 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 22 Feb 2023 15:33:40 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="W/W61AyJ"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pUyWy-0001Cc-1Q; Wed, 22 Feb 2023 18:28:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUyWm-0000pF-Ci for qemu-devel@nongnu.org; Wed, 22 Feb 2023 18:28:00 -0500 Received: from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pUyWk-0005QO-R6 for qemu-devel@nongnu.org; Wed, 22 Feb 2023 18:28:00 -0500 Received: by mail-pj1-x102d.google.com with SMTP id d1-20020a17090a3b0100b00229ca6a4636so10903296pjc.0 for ; Wed, 22 Feb 2023 15:27:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=6rAVEKvH88i+QH8CXFUlPcaghYPMd95m3CUWWiU3uQ0=; b=W/W61AyJ+mx9ByzY0qo+9wesH9QFCG+3Yjmqh30ZWAzvdA5oOlYAP5GifXMxf3d0XD Slatgo2o3StSb9TfUDnecVBBsFx602DlEIqQSagWEHzzbzg+TBAWkKXEANuot9fkiuI2 fCGz8biqK2Kl47pzCbauFdHEX5m8hGe3AVhoWDBrT5CRLtGnM5E1dqQSGSWqevXjGSF5 AUMd9ceKqGHS1Qes+eXA2twICquXQwMqBK8OG7btuTteA1margkS5rvNUrRCw2BcpoTU +8lKlNV7PMwX8Jz5pG3AyLRid8RSbJ51RuBlsDvmwyTOpHYV7gbsU4JWuAnITes5gd1K ZYBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6rAVEKvH88i+QH8CXFUlPcaghYPMd95m3CUWWiU3uQ0=; b=dfwAs4sxpXI37xWYbFKtNcfc05KHoLygRtlDZ6BVPNa0Cy0peakpMlIgg9R9zHScUw ZyKpnmvNEzes7FR+MRA0Q8hOSlF9AxepqZGFCZ1nm0sNt6BADC9BS/rFJ/+zRqtaKNQT 7Upqw7QrGlMJRItK5fW7hVnilaKXzf9UEc/KzmDbCTHjCmcl+q65JeUqPZaMUeNPGkhY D/i2tsuaWvm5WX8XIOI2NphDRTO4Ybt8a03UwNgMSnG4y9HeasVE6PE9LN/gK1Tpp8Gr zr0XleQpdnABfYC91b5RB77QVzEFIr3TKao5Vyot0iworUrIHgMMYPVL72LNeNIzuvJ8 pBZQ== X-Gm-Message-State: AO0yUKVl+DfvEeueoM13lm8fmyI88yCS/DBH7GtadZeQob6KryGwv9Lp 9qwNVImqn4S91Dl1FsiEi1IJq6XLdWeMdS2hjDs= X-Received: by 2002:a17:90b:4c0c:b0:233:feb4:895f with SMTP id na12-20020a17090b4c0c00b00233feb4895fmr10098398pjb.44.1677108477615; Wed, 22 Feb 2023 15:27:57 -0800 (PST) Received: from stoup.. (rrcs-173-198-77-218.west.biz.rr.com. [173.198.77.218]) by smtp.gmail.com with ESMTPSA id s16-20020a17090ad49000b00234e6d2de3dsm5008918pju.11.2023.02.22.15.27.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 15:27:57 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v2 28/28] tcg: Use noinline for major tcg_gen_code_subroutines Date: Wed, 22 Feb 2023 13:27:15 -1000 Message-Id: <20230222232715.15034-29-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230222232715.15034-1-richard.henderson@linaro.org> References: <20230222232715.15034-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::102d; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org This makes it easier to assign blame with perf. Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé --- tcg/tcg.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index 4b244eebc2..b65f2ffdbe 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -2619,7 +2619,8 @@ TCGOp *tcg_op_insert_after(TCGContext *s, TCGOp *old_op, } /* Reachable analysis : remove unreachable code. */ -static void reachable_code_pass(TCGContext *s) +static void __attribute__((noinline)) +reachable_code_pass(TCGContext *s) { TCGOp *op, *op_next, *op_prev; bool dead = false; @@ -2840,7 +2841,8 @@ static void la_cross_call(TCGContext *s, int nt) * Liveness analysis: Verify the lifetime of TEMP_TB, and reduce * to TEMP_EBB, if possible. */ -static void liveness_pass_0(TCGContext *s) +static void __attribute__((noinline)) +liveness_pass_0(TCGContext *s) { void * const multiple_ebb = (void *)(uintptr_t)-1; int nb_temps = s->nb_temps; @@ -2907,7 +2909,8 @@ static void liveness_pass_0(TCGContext *s) /* Liveness analysis : update the opc_arg_life array to tell if a given input arguments is dead. Instructions updating dead temporaries are removed. */ -static void liveness_pass_1(TCGContext *s) +static void __attribute__((noinline)) +liveness_pass_1(TCGContext *s) { int nb_globals = s->nb_globals; int nb_temps = s->nb_temps; @@ -3247,7 +3250,8 @@ static void liveness_pass_1(TCGContext *s) } /* Liveness analysis: Convert indirect regs to direct temporaries. */ -static bool liveness_pass_2(TCGContext *s) +static bool __attribute__((noinline)) +liveness_pass_2(TCGContext *s) { int nb_globals = s->nb_globals; int nb_temps, i;