From patchwork Thu Mar 2 19:08:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 658141 Delivered-To: patch@linaro.org Received: by 2002:adf:a3c6:0:0:0:0:0 with SMTP id m6csp67115wrb; Thu, 2 Mar 2023 11:15:33 -0800 (PST) X-Google-Smtp-Source: AK7set8Fnwi0StpohHuBpjngXFxpzPDTYzpvclmBneIsd/hgJ4iwRdIlnWuTPwET3MHxgeUb7Fvh X-Received: by 2002:a05:6214:27cf:b0:570:bf43:48c with SMTP id ge15-20020a05621427cf00b00570bf43048cmr17471720qvb.17.1677784533064; Thu, 02 Mar 2023 11:15:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677784533; cv=none; d=google.com; s=arc-20160816; b=0xpIbzQYbMd+SFEHS9+MTDHinspsKvNHQ+1ZDUWNPszwiH58nqWAc8GN1Hgo1Pawmn pLCiAVGK6zNsQsXkL+PzjvkgqttiKqN03TOGEIwyensyArnda/AE8IWoSap8fQOEAOG7 ulzkJAXTFd5A8ggRJxoV/q/glfFhItWRupRbYCs4hyvnH2NWqhavGgYhZ6kzO7CQ0Gys zKzjk/bjho0Xpwbsf2ft0N1v7Waqf/PMXAL0rdqOiH1uAJrzlc4u5OZkX60gUx1WmeCQ ixBOSgnPLXASJezKt/irEKaWpZ0vd4JNzFyqN/uhVOin68z0npSy9m8KmRfqIylrQ8+M 0xpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=2mDcBmWouGnqGshBynFnpTf0FCw+Ej8aBvk380H3UuI=; b=mvkL1IuUs3J0c/G5QTv5XJi/8mfRTeyEaiLuIF9Z9IV6JKc2SoiF4ITBe8vdloPHFX /3Yw30G8AKGM3fzv/zmJ9a5Kzli7MWJdKkecMTAlCLESLjPN4uyyXLIgM/h5ot6ZYHv+ 4jMex63op9A2pkDNyEQRIvWKompY6xXYAFt1vdWMXZwUKVptI1ojD2cU2O09b2DXCkYv 9DYrklOUtsMiG0FQkAEnvk8q2UIkHkaK2PaucdqulPSbqEfXX3K8/MnbYdtiDFYqJlvu Pc+JcVr+GeSvd35l3oCmZfYh7b1khDyAUPs0iUiD9LlNtjesR+JfDz/ZJUiNjDj0Ayus tbRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BXhYzlIz; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id c1-20020a0cf2c1000000b0056eb019cf89si13656814qvm.471.2023.03.02.11.15.32 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 Mar 2023 11:15:33 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BXhYzlIz; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pXoNu-0006jP-5Z; Thu, 02 Mar 2023 14:14:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXoNq-0006aV-LS for qemu-devel@nongnu.org; Thu, 02 Mar 2023 14:14:30 -0500 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pXoNj-0000kS-Ak for qemu-devel@nongnu.org; Thu, 02 Mar 2023 14:14:30 -0500 Received: by mail-wm1-x329.google.com with SMTP id j19-20020a05600c191300b003eb3e1eb0caso2535617wmq.1 for ; Thu, 02 Mar 2023 11:14:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2mDcBmWouGnqGshBynFnpTf0FCw+Ej8aBvk380H3UuI=; b=BXhYzlIz4j2CWr7staJK2ZrwQKbpSJoV8+CqliJorOBQviI6qlvhy8hs/bRlc8iHzK 2d8waRQy+vebFK4XDNLRiTHY+tdbnJ0FfASQMOZ+rjY+pRu+vEGgpgdlfuMb6DjhEMgS FK/nNatkJbpwbdhWrWI9tnYRH/dysVdyKNVqA8dGn+DwgFSM096dN388OZGadt3S6ruA WhRe13FdZYLXrr/2thq3+du5LceKbDMJH+6IhHD+TADiQE96sHjcfg68vOyYSVhD4z0s xxOEaxrH9bCsCQb3ZwQrPf01mEXK5fll2XGLUysUcP+9SuD6i8rvmaCgJ0SDXqX5IQ4J mCUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2mDcBmWouGnqGshBynFnpTf0FCw+Ej8aBvk380H3UuI=; b=53mMR7XGT0Ao5E+GDLyDaAbdkyff7hcNkHvVzDddctPt4KFV+9zb598A3RMC7s9oes 0FAimMgvYiy9YuJ7OS0Hw3wadz/EUuAJdXP67kf6hB5hqE+d2lkPlwx7PvJ3xDY+nu9k ZZFR1npOm3+sCbVu948yG1if7dAwSVWbfNDQq5lK5GMxB9p0Oiy8v8ZwZMZ/Hhd/G6u6 9JRICuBkdTUABl59Wac+uNfTs7DJfopBOs5dczwu/5NWSllXBYwHFS/2aY+x+5zU5uhh a6tPr8xbGVCamj5X2WbrtCM/sHply5yrztDlvKQK1vzvoUcp+KNi9240IduOLGTo028b L3MQ== X-Gm-Message-State: AO0yUKWWkE+U4WSGtAwnRCpvhsd2C6DTm98OZiyirsAT8naN4I1EbORt n6d3PaqKi9M6vOkkQ/QbigtQSg== X-Received: by 2002:a05:600c:198e:b0:3eb:6878:5523 with SMTP id t14-20020a05600c198e00b003eb68785523mr250882wmq.12.1677784461721; Thu, 02 Mar 2023 11:14:21 -0800 (PST) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id k5-20020adfe8c5000000b002c56179d39esm162354wrn.44.2023.03.02.11.14.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Mar 2023 11:14:20 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 0A81B1FFBB; Thu, 2 Mar 2023 19:08:49 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Weiwei Li , =?utf-8?q?C=C3=A9dric_Le_Goater?= , Palmer Dabbelt , Laurent Vivier , nicolas.eder@lauterbach.com, Ilya Leoshkevich , kvm@vger.kernel.org, "Edgar E. Iglesias" , David Gibson , Max Filippov , Sunil Muthuswamy , qemu-s390x@nongnu.org, Stafford Horne , Bin Meng , Marek Vasut , Greg Kurz , Song Gao , Aleksandar Rikalo , Liu Zhiwei , Alistair Francis , Chris Wulff , qemu-riscv@nongnu.org, Michael Rolnik , qemu-arm@nongnu.org, Cleber Rosa , Artyom Tarasenko , Marcel Apfelbaum , Eduardo Habkost , Yoshinori Sato , Alexandre Iooss , Daniel Henrique Barboza , Jiaxun Yang , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?q?=C3=A9?= , mads@ynddal.dk, Mark Cave-Ayland , qemu-ppc@nongnu.org, Richard Henderson , John Snow , Xiaojuan Yang , Thomas Huth , Paolo Bonzini , Mahmoud Mandour , Aurelien Jarno , Bastian Koppelmann , Yanan Wang , David Hildenbrand , Taylor Simpson , Peter Maydell , =?utf-8?q?Alex_Benn=C3=A9e?= Subject: [PATCH v4 18/26] gdbstub: fix address type of gdb_set_cpu_pc Date: Thu, 2 Mar 2023 19:08:38 +0000 Message-Id: <20230302190846.2593720-19-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230302190846.2593720-1-alex.bennee@linaro.org> References: <20230302190846.2593720-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x329.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org The underlying call uses vaddr and the comms API uses unsigned long long which will always fit. We don't need to deal in target_ulong here. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée --- gdbstub/gdbstub.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index 7301466ff5..b8aead03bd 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -535,7 +535,7 @@ static void gdb_process_breakpoint_remove_all(GDBProcess *p) } -static void gdb_set_cpu_pc(target_ulong pc) +static void gdb_set_cpu_pc(vaddr pc) { CPUState *cpu = gdbserver_state.c_cpu; @@ -1290,7 +1290,7 @@ static void handle_file_io(GArray *params, void *user_ctx) static void handle_step(GArray *params, void *user_ctx) { if (params->len) { - gdb_set_cpu_pc((target_ulong)get_param(params, 0)->val_ull); + gdb_set_cpu_pc(get_param(params, 0)->val_ull); } cpu_single_step(gdbserver_state.c_cpu, gdbserver_state.sstep_flags);