From patchwork Fri Mar 3 02:57:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 658459 Delivered-To: patch@linaro.org Received: by 2002:adf:a3c6:0:0:0:0:0 with SMTP id m6csp226010wrb; Thu, 2 Mar 2023 19:00:55 -0800 (PST) X-Google-Smtp-Source: AK7set+IlbibEjYSCdCdbwyCtR9ifaeC2nUi+PWqoAgaP66DfsfdtWxOq8MJZxYrCSbacdNCicTP X-Received: by 2002:a05:6214:405:b0:56e:bb5b:3dfc with SMTP id z5-20020a056214040500b0056ebb5b3dfcmr602838qvx.38.1677812454690; Thu, 02 Mar 2023 19:00:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677812454; cv=none; d=google.com; s=arc-20160816; b=X3IEYyzlHRvluo+8Zv4RgHcU69L4P8xQHqwwkg3Kmtzq02j+S57Du9pAH5Cyq3/Ln9 Rat9/hpoIPKl/LZtryDfSQGowcwa0Pqu6vXL0PqaFuT+grlq/HSh+rYDlfAmJ03fPMmI 0JPm7brn0e526aytw5f/Zn0ibMGXxYSwJIs4MGBBWQ1J+iJxnL5eXK101IVxem2p6+b7 10FUst+ko7E5loqWNoINrq7sHIZyRZ0wioXoFQ2rmm3qvHLqWjb/B3OBG09zSbt1o9Rl UmB7oxCLDaZCuPWdcmnu9qr4GbJ3jbeSEOtEGgTtoHvqXjO8NFWWuY9/SRvMvw/nB6st 3r0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Wh4TGmta6KxxW4dXBB2Rrca4W4QJFWocfsDlY9pkBAI=; b=w24oCrsYvjbo7yW6QGGTsY+0t7TfvCWq2RwaAF9zLM8GNhjArj7fbbWCcdjpyb+6Uw wXDmAQDoZ5NWuA1u9Qx7SI+srUe/gwKmN5hXM9QVm0zoPuEloeKCagh1DoWIz+TwyP0I 81iVkvi9V6w3dytJzh57VqrGm77j2p7cjhWDy8iU9EBhWXsxwUQ6n04BjRovZEh7GdSd qBWHDlJWXYOszvRkvPWWkqINwa1e8T7QNHX3e+/0udgi7sBQcjEL8zYpO5qJn5PiIbwH JAAcBH2oIVW/lvfyeL0qNb+v7jZdgww459h0fmUW37RPIcSMmfn7eIbXRWwFC/ohGi7Z cNeA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZDa5PO+z; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id q19-20020a0ce213000000b005722e511df1si676482qvl.194.2023.03.02.19.00.54 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 Mar 2023 19:00:54 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZDa5PO+z; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pXvcp-0007XL-Sp; Thu, 02 Mar 2023 21:58:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXvco-0007Vk-CV for qemu-devel@nongnu.org; Thu, 02 Mar 2023 21:58:26 -0500 Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pXvcl-0001s6-Vq for qemu-devel@nongnu.org; Thu, 02 Mar 2023 21:58:26 -0500 Received: by mail-pl1-x62b.google.com with SMTP id a2so1357344plm.4 for ; Thu, 02 Mar 2023 18:58:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1677812302; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Wh4TGmta6KxxW4dXBB2Rrca4W4QJFWocfsDlY9pkBAI=; b=ZDa5PO+zBCiVL2e0e6EO7+8jePdHFOXeUPD3s/Qks0ANq4FahMk39oKhOwOV2EFNLo 6u6YKkrJgXrAXbJa0VshPjxP2iEzox31MckeA+yYbaxgj+RIP8D43Ihxpo6WxEmmGdOj 0tb0UNFbTAieu8M0lHBMo0K7/a9v44UByCd5oGRDMZgDNBlZyrfhtX9WJ9pN2sr2TXYX mgrYxt5lkficjeoSQkVwLqfmvq1x57njBR7dY7NRul2/zABzYrb4gwObrJPoF+dLwySt 1BqkwmIM6h/2leA32kAnkqUg5FZ+SNc6MQm7wWbnTeyeWUlW7GDv/xOokxedqVcvV0zA 0xHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677812302; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Wh4TGmta6KxxW4dXBB2Rrca4W4QJFWocfsDlY9pkBAI=; b=tyIbFpmZEXxDXnBsSosKJUaBLXGQA+A5Ym2W4FExn/CqB4lc0qh6avw72kv6BKvLOK Kt604+v779ue4onRTEZC9le2z4DY8OL6/d8a5hipMBtVntoM5TQGevFyXe/rGBee7a+t g4KH7Y+pXhVZ+rFVCxXkoHBAyJ2lSfP7LRdqs+qtmzbND3gRQ4sa+9scR6rCm9BprxdP jLijfG3PsRwAvS91Koogo37Bq1GxvKY7/D1tT61jRad4RWvpjFRLKgXLEqno+wKF9jtb ENvQntruJodWpj7IUQCSXFfiwk5BYFMf0d5u3p7zzmRxJFavXK0VddxQDcnGSrlZoJJr gRcg== X-Gm-Message-State: AO0yUKW6YJEzmSQF+NjCC+YpCN0zEIFMWVEGfszEE7wS5rWlpMTh4dcE DOsRN8FI3kDz2Z0UHJIM2YGITMcmM+0SdMLm2aM= X-Received: by 2002:a17:902:e54f:b0:19c:b4e3:c65b with SMTP id n15-20020a170902e54f00b0019cb4e3c65bmr659386plf.8.1677812302499; Thu, 02 Mar 2023 18:58:22 -0800 (PST) Received: from stoup.. ([2602:ae:154a:9f01:f3e6:4626:fbc8:b2ce]) by smtp.gmail.com with ESMTPSA id e4-20020a17090301c400b001992e74d055sm372244plh.12.2023.03.02.18.58.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Mar 2023 18:58:22 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: alex.bennee@linaro.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH v4.5 18/29] gdbstub: fix address type of gdb_set_cpu_pc Date: Thu, 2 Mar 2023 18:57:54 -0800 Message-Id: <20230303025805.625589-19-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230303025805.625589-1-richard.henderson@linaro.org> References: <20230303025805.625589-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::62b; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Alex Bennée The underlying call uses vaddr and the comms API uses unsigned long long which will always fit. We don't need to deal in target_ulong here. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée Message-Id: <20230302190846.2593720-19-alex.bennee@linaro.org> --- gdbstub/gdbstub.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index 7301466ff5..b8aead03bd 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -535,7 +535,7 @@ static void gdb_process_breakpoint_remove_all(GDBProcess *p) } -static void gdb_set_cpu_pc(target_ulong pc) +static void gdb_set_cpu_pc(vaddr pc) { CPUState *cpu = gdbserver_state.c_cpu; @@ -1290,7 +1290,7 @@ static void handle_file_io(GArray *params, void *user_ctx) static void handle_step(GArray *params, void *user_ctx) { if (params->len) { - gdb_set_cpu_pc((target_ulong)get_param(params, 0)->val_ull); + gdb_set_cpu_pc(get_param(params, 0)->val_ull); } cpu_single_step(gdbserver_state.c_cpu, gdbserver_state.sstep_flags);