From patchwork Mon Mar 6 00:39:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 659191 Delivered-To: patch@linaro.org Received: by 2002:adf:a3c6:0:0:0:0:0 with SMTP id m6csp1575273wrb; Sun, 5 Mar 2023 16:52:09 -0800 (PST) X-Google-Smtp-Source: AK7set/4pt+/S0rgX9K4XgNMPkJEZtzvr5JbIFzx9MXvFkyGvXeHLv1MQBU7LwoKKLcld4C/WPvJ X-Received: by 2002:ad4:5f86:0:b0:56e:da8b:c4f2 with SMTP id jp6-20020ad45f86000000b0056eda8bc4f2mr16025809qvb.8.1678063929258; Sun, 05 Mar 2023 16:52:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678063929; cv=none; d=google.com; s=arc-20160816; b=ADBIqz96DJT6qmORfwoy+8N2JUWafh/Pdv/BCDcBLkQAm/WAn7Mc0ZBCazCPBawqho TkBcM0rt1sxUrd0PAZXX/om3dd2PqJ6CkrhIPhU5OPnCzapHnxFSe6Wc29DJ9UTcuf24 77NKWtCIxG2X1gn/+bMksYCYMgXOboR7WdNk5Q8FdHG4WXxu9WkdJDp/8sfjg7tpHMOo 0ygwpDba20P0hJrJM6FGORgb2NSnMTZlDdMNy+YprhQ/IeMklPfuDvUnfkcV0f1YsOGs v+WrTjPr3/lpL6syTGNR3hWE28yh2ZEmpYGf8QDUe0fBAKNSw+ZpS/VlKLv5hTRvbeWc zmAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=6I7Tkr0gEn5C9IQe3ln5Tw/bG/eqeOfdkUEZ9u/mHS8=; b=f/2gj9RYKxiC7sSJjp3mXnI4tDNyPbBHvN4CbYsqiW4YiI2hZ3wTt1fvENPAbYPQuV xc9XjIZFgNB7/LIVLq3uLw7eyaAuZt4VugH5UvYO3otCflmTKKhSi2ZXYKm5hGiYqduU dMKWR/WqZDooZHml7KeNp5bYQITpVjw/KHt9K2w2M4nbXA5t0ao3MIuH0S/fFF4GEPva lm5PlAPRk5iziqda/jlSp/BjpJZB30gFPOYVvCQzbXbWIcGsx1PqwhYbVj3mYqIz2kix m9RPwJu7ui+cC29AyttaY3OnQJTj5nie0eKGf5JTBOUZNdn+6F3qp5lmwiif149q6Cau Nwcg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=THFoH1Xy; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id q21-20020a374315000000b0073b83b0eccbsi5830548qka.296.2023.03.05.16.52.09 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 05 Mar 2023 16:52:09 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=THFoH1Xy; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pYyyG-00047e-FK; Sun, 05 Mar 2023 19:44:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYyxi-0002tK-Ts for qemu-devel@nongnu.org; Sun, 05 Mar 2023 19:44:25 -0500 Received: from mail-pg1-x532.google.com ([2607:f8b0:4864:20::532]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pYyxe-0007Lm-CK for qemu-devel@nongnu.org; Sun, 05 Mar 2023 19:44:19 -0500 Received: by mail-pg1-x532.google.com with SMTP id bn17so4535590pgb.10 for ; Sun, 05 Mar 2023 16:44:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678063457; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6I7Tkr0gEn5C9IQe3ln5Tw/bG/eqeOfdkUEZ9u/mHS8=; b=THFoH1XynQo5bP/ay+iwqFOwpGHuOTPZQrG0YZUYIFcync4c3dbMmx+mHshaeKKBNe +h6dPSt8VD0zRl3GA1hx75z8RCORr1b6jYVcvf+r/Qutsy5jND98BwE6x18PM14KUpiR OyLSdiQeW1NXkh2+HnL5RSt2j6T+knAYwNfnKzBm3u90jPkOpFHRCvDi+g1qmHsnedSc +ylB28ihEsQ6WV8lqVfwEZ82FP39K4CjFekXIm1dVzlCSrzJ5MxQeFuYaEajNu3oHpgs OtfcUe7/GonGTvO4VlLFTmRJDEPtWMFbcTyYomd7CtZz2/UmOJXYzf/PvGwTlcGwGW47 zisQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678063457; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6I7Tkr0gEn5C9IQe3ln5Tw/bG/eqeOfdkUEZ9u/mHS8=; b=PV9xRZfDN2v3lzg/wVzv1VtMVIFCUAuLNWgLpKv6cVnVM6vBfU70kl1fZTPnPlQX4b 4ysXot3qeA9TkzVuUEvOyKwIBOUqyMhYlNOWyxifp5wL/o3gzR02qIPykaE5YPUDx9og 6tcglcjyalX96f/H96gdy8YmosEBuAKkSFnfe5TQ1k3oVo0PsPxO/gBYn1GU3hwTWiYX yloxEvh35h2OtZfeHCG63IWm8BiP7cP7DzxGb+wXBMofPmmOoYEPqwPHQ1OMLUgDyEtp sHatQ5Xn0MRFbjmZkTQZHwGVLOXPrJy9MTILkqGXU9f/xKnxRY0Y7gBv+niqrJgH9CKO FQDQ== X-Gm-Message-State: AO0yUKV/wDJHotOHLx0Vzzj3mxmjpY4kp+U3psQ0nQXiWinT06VrbH+u jd4jCxDwRARyaBrJx8/lRFKJAKV6wroVaZTP5MAzxQ== X-Received: by 2002:a05:6a00:796:b0:5a8:e3d5:d7d4 with SMTP id g22-20020a056a00079600b005a8e3d5d7d4mr12449309pfu.7.1678063456757; Sun, 05 Mar 2023 16:44:16 -0800 (PST) Received: from stoup.. ([2602:ae:154a:9f01:87cc:49bb:2900:c08b]) by smtp.gmail.com with ESMTPSA id x52-20020a056a000bf400b005895f9657ebsm5045726pfu.70.2023.03.05.16.44.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Mar 2023 16:44:16 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, Daniel Henrique Barboza Subject: [PULL 68/84] docs/devel/tcg-ops: Drop recommendation to free temps Date: Sun, 5 Mar 2023 16:39:38 -0800 Message-Id: <20230306003954.1866998-69-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230306003954.1866998-1-richard.henderson@linaro.org> References: <20230306003954.1866998-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::532; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x532.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Reviewed-by: Daniel Henrique Barboza Signed-off-by: Richard Henderson --- docs/devel/tcg-ops.rst | 4 ---- 1 file changed, 4 deletions(-) diff --git a/docs/devel/tcg-ops.rst b/docs/devel/tcg-ops.rst index 561c416574..f3f451b77f 100644 --- a/docs/devel/tcg-ops.rst +++ b/docs/devel/tcg-ops.rst @@ -951,10 +951,6 @@ Recommended coding rules for best performance often modified, e.g. the integer registers and the condition codes. TCG will be able to use host registers to store them. -- Free temporaries when they are no longer used (``tcg_temp_free``). - Since ``tcg_const_x`` also creates a temporary, you should free it - after it is used. - - Don't hesitate to use helpers for complicated or seldom used guest instructions. There is little performance advantage in using TCG to implement guest instructions taking more than about twenty TCG