From patchwork Mon Mar 6 00:39:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 659179 Delivered-To: patch@linaro.org Received: by 2002:adf:a3c6:0:0:0:0:0 with SMTP id m6csp1574855wrb; Sun, 5 Mar 2023 16:50:29 -0800 (PST) X-Google-Smtp-Source: AK7set8fOCE9Y/oZTnmyb/CYbJBPJe/oM6JDS8UDdNnl0tLQgoliMbgb2zHhqyULALNb21UTrUl8 X-Received: by 2002:ac8:5c87:0:b0:3bf:e005:3a85 with SMTP id r7-20020ac85c87000000b003bfe0053a85mr15872424qta.5.1678063828949; Sun, 05 Mar 2023 16:50:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678063828; cv=none; d=google.com; s=arc-20160816; b=Hx68s4W/JCP3iqksLamLnShBxsBQkvq1CTssLHMjTONa7uXMXv/kHgMP+pmVeXmBcg hvR2hNcFh/SnCbBqexO7IjECsa8/VcZRu9tS+B0JSw+37H1RPMxy0KVC00xV05nwDymn KOTNCL7vpHx/yPNVMJ6PqcHp3f1kSzCL/KbUswog930a3W6o4HZyJ1AbTcRiCAnpZ5Cl /PPF53kBHbGNDZ9aI+7qhPrU0v3/KDmTGYxWB/jNMY5ZdiTJ4aeYcb5xsfz/oku9+R0/ H1ChPCDbK9xSq2W8WwYlnh+vgBxUQUIwNj1SvypnncNSCHZN0c1hNYa3rCl+Ln1rB8kD 06Uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=QiUF3mqm6DS60wxBfGio8dJ1EJJ98ZEumCYG4irApQg=; b=KL0GyeltJs9aiXvU15iV1P0F/fyrvsxXooiztRZhrrByyd85CUnzyG8/R0su7QeiUb euTMj/CbKXShg4u803Gd5FnP51qn8H69WEFYBCvt2WNel/YtkC2NEFgdZiQoBvZbTUsD fWVIVpD9+cL/7uc2uFZBBUr1kuQ34644KieJI3oqW5LNKNiuqSOsVYAKrIi6Ila0dyV/ is8y7forn9c4ULSfLDlzZl+mW7UfU7pgLD4XD/CpzvkEPPsF1bGcpaMm/f+F/jEo0wNT cpTEyKIsXeDrz9GlCLAyVe6zJnb5PTS93/Sdq/ch6DJgNEM0I9W47Ln52Z+X/kjobjiC SZwQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=q0ZOPzDS; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id c22-20020ac87dd6000000b003bfb988bfdcsi6548502qte.222.2023.03.05.16.50.28 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 05 Mar 2023 16:50:28 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=q0ZOPzDS; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pYyyK-0004Mo-7m; Sun, 05 Mar 2023 19:45:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYyxn-000301-0h for qemu-devel@nongnu.org; Sun, 05 Mar 2023 19:44:27 -0500 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pYyxi-0007MN-M2 for qemu-devel@nongnu.org; Sun, 05 Mar 2023 19:44:25 -0500 Received: by mail-pg1-x541.google.com with SMTP id 132so4526935pgh.13 for ; Sun, 05 Mar 2023 16:44:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678063460; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QiUF3mqm6DS60wxBfGio8dJ1EJJ98ZEumCYG4irApQg=; b=q0ZOPzDSwwVLOO/U2wjY7mJSyZzsDYlDeS8aWIcLiQJiztj5DGBI6l+Cc3p8RsFuza V5dH9yPUp+P+7MFdsNfQgneqVkoXZX5oHHsPK83K5uUCb0MTn/U/JYV5HbhAr02yRDxY wjDS1QZaRldimNWfO5PXSSaZpKo19GtkuS9ZzLo54C70t1o3pnAoV2wDf02BlR33ZT2E pXk83xdp3J1xLcSAGn9/3dlrNRoBaDMtECuv0wrF53lGJ3TjXDMCbCMZzjXEpapQt8rf uoT2oHcfEnmPX7IJ5N0igfv46Ji6fVeW5EbwOWAQuqJmQQ9OGwr4HuKExSvGYyGCOJLT GW7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678063460; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QiUF3mqm6DS60wxBfGio8dJ1EJJ98ZEumCYG4irApQg=; b=RfN43dFIFd8YXcmUjkyY0HvpcRcK/7X3u5BypRzsOUol7bl1r7+XqlsIVBW8uFOOdf p/YT71cSlXa0slri0JpbMvPgJ4f6Z//XAzDZEGhUys7MTsrkWBrRZcerbJJbwEUzC5F+ Hqy0Kv2YVVw+Yo5utxyMz0/XrO++QaD9BLFUTSb9swJNxD8CyiUstO6miWoe4xchWnku B6uKrPgtZ8+VsrNrk3O4TjBi8UP4x5ppOSqHSi+I/B7ZO5nBts/XcgjanjipupgN+ByA yCrdzQ0fI0GyP71DI6K+2AeWqiQ4T1bJWbY4wq+r3i/OgtVTAnbJRve48GUNgx0k/4hh mllg== X-Gm-Message-State: AO0yUKUJBQWSjHxfZ3VbGDf5hSVuBBjVeKlLo52Q6/+TGnU61isGMKE5 RNFpa9ONRsbVXbaUT3ng+KSu9mH9rWLppX7OUBw7ZSq1 X-Received: by 2002:a62:3182:0:b0:617:bce6:f033 with SMTP id x124-20020a623182000000b00617bce6f033mr4655356pfx.14.1678063460197; Sun, 05 Mar 2023 16:44:20 -0800 (PST) Received: from stoup.. ([2602:ae:154a:9f01:87cc:49bb:2900:c08b]) by smtp.gmail.com with ESMTPSA id x52-20020a056a000bf400b005895f9657ebsm5045726pfu.70.2023.03.05.16.44.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Mar 2023 16:44:19 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, Taylor Simpson Subject: [PULL 72/84] target/hexagon/idef-parser: Use gen_tmp for gen_rvalue_pred Date: Sun, 5 Mar 2023 16:39:42 -0800 Message-Id: <20230306003954.1866998-73-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230306003954.1866998-1-richard.henderson@linaro.org> References: <20230306003954.1866998-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::541; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x541.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org The allocation is immediately followed by either tcg_gen_mov_i32 or gen_read_preg (which contains tcg_gen_mov_i32), so the zero initialization is immediately discarded. Reviewed-by: Taylor Simpson Signed-off-by: Richard Henderson --- target/hexagon/idef-parser/parser-helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/hexagon/idef-parser/parser-helpers.c b/target/hexagon/idef-parser/parser-helpers.c index 760e499149..c0e6f2190c 100644 --- a/target/hexagon/idef-parser/parser-helpers.c +++ b/target/hexagon/idef-parser/parser-helpers.c @@ -1889,7 +1889,7 @@ HexValue gen_rvalue_pred(Context *c, YYLTYPE *locp, HexValue *pred) bool is_dotnew = pred->is_dotnew; char predicate_id[2] = { pred->pred.id, '\0' }; char *pred_str = (char *) &predicate_id; - *pred = gen_tmp_value(c, locp, "0", 32, UNSIGNED); + *pred = gen_tmp(c, locp, 32, UNSIGNED); if (is_dotnew) { OUT(c, locp, "tcg_gen_mov_i32(", pred, ", hex_new_pred_value[");